Linux block layer
 help / color / mirror / Atom feed
From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Christoph Hellwig <hch@lst.de>, 0wnerD1ed <l7z@0b1t.tech>
Cc: Jens Axboe <axboe@kernel.dk>,
	Christian Brauner <brauner@kernel.org>,
	 "Darrick J. Wong" <djwong@kernel.org>,
	Carlos Maiolino <cem@kernel.org>,
	 Tal Zussman <tz2294@columbia.edu>,
	Anuj Gupta <anuj20.g@samsung.com>,
	linux-block@vger.kernel.org,  linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 13/16] xfs: add support for lazy direct read bounce buffering
Date: Mon, 21 Sep 2026 15:40:00 +0900	[thread overview]
Message-ID: <arDN1UdZIydNLUjz@shinmob> (raw)
In-Reply-To: <20260909060924.1102037-14-hch@lst.de>

To+: 0wnerD1ed <l7z@0b1t.tech>

On Sep 09, 2026 / 09:09, Christoph Hellwig wrote:
> Currently direct I/O reads always bounce buffer the I/O to deal with
> the case where userspace is modifying the buffer in-flight while
> reading data into it.
> 
> This is a very expensive countermeasure for something no sane application
> should do, so try to avoid it by reading without a bounce buffer first,
> and retrying the read on a checksum failure.  This avoids the cost of
> bounce buffering for sanely behave applications.  For the rare case of
> an application regularly modifying in-flight buffers, allow forcing the
> always bounce buffer behavior through sysfs.  And now that we have that
> knob, allow disabling read-side bounce buffering entirely for those who
> live fast and dangerous.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

I found that recent blktests CI trial runs started reporting the failure of
the test case block/046 [1]. I confirmed that it is observed with the kernel at
the linux-block for-next branch. I bisected and found the this commit triggers
the failure. The error message "preadv returned -1 (errno 22)" was printed at
src/bio-bounce-read.c line 121 [2].

AFAIU, the test case does direct read to a null_blk with bounce buffer, and the
kernel side introduced some new requirements to use bounce buffer for direct
I/Os. Then, I guess the test case requires some refinements to meet the new
requirements.

0wnerD1ed, may I ask your help to fix this failure? At this moment, I don't have
much time to dig into this.


[1] failure console log

block/046 (test partial bounced direct read bvec alignment)  [failed]
    runtime  1.174s  ...  1.199s
    --- tests/block/046.out     2026-08-03 19:26:40.410053604 +0900
    +++ /home/shin/Blktests/blktests/results/nodev/block/046.out.bad    2026-09-20 20:14:33.795794868 +0900
    @@ -1,2 +1,4 @@
     Running block/046
    +bio-bounce-read: preadv returned -1 (errno 22)
    +bio-bounce-read helper failed
     Test complete

[2] https://github.com/linux-blktests/blktests/blob/f0603f960dcc2fc215161545b4b94633222a35ac/src/bio-bounce-read.c#L121

  reply	other threads:[~2026-09-21  6:40 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-09  6:08 lazy bounce buffering for checksummed reads v3 Christoph Hellwig
2026-09-09  6:08 ` [PATCH 01/16] block: split bio_iov_iter_bounce_write Christoph Hellwig
2026-09-11 16:41   ` Jens Axboe
2026-09-09  6:08 ` [PATCH 02/16] block: export fs_bio_integrity_{alloc,free} Christoph Hellwig
2026-09-09  6:08 ` [PATCH 03/16] block: add a bio_prepare_reissue helper Christoph Hellwig
2026-09-09 16:05   ` Darrick J. Wong
2026-09-09  6:08 ` [PATCH 04/16] iomap: respect maximum I/O size in iomap_dio_bio_iter_one Christoph Hellwig
2026-09-09  6:08 ` [PATCH 05/16] iomap: add a iomap_ioend_flags helper Christoph Hellwig
2026-09-09  6:08 ` [PATCH 06/16] iomap: add a IOMAP_IOEND_INTEGRITY flag Christoph Hellwig
2026-09-09  6:08 ` [PATCH 07/16] iomap,xfs: move T10 PI handling for direct I/O into ->submit_io Christoph Hellwig
2026-09-09  6:08 ` [PATCH 08/16] xfs: move PI generation into xfs_submit_zoned_bio Christoph Hellwig
2026-09-09 16:06   ` Darrick J. Wong
2026-09-09  6:08 ` [PATCH 09/16] block,iomap: fix protection information verification with initial bvec offset Christoph Hellwig
2026-09-09  6:08 ` [PATCH 10/16] iomap: better read bounce buffering support Christoph Hellwig
2026-09-09  6:09 ` [PATCH 11/16] xfs: use BIO_COMPLETE_IN_TASK for bounce buffered read I/Os Christoph Hellwig
2026-09-09  6:09 ` [PATCH 12/16] iomap,xfs: move integrity verification to the file system Christoph Hellwig
2026-09-09  6:09 ` [PATCH 13/16] xfs: add support for lazy direct read bounce buffering Christoph Hellwig
2026-09-21  6:40   ` Shin'ichiro Kawasaki [this message]
2026-09-21  7:10     ` Christoph Hellwig
2026-09-21  8:05     ` 0wnerD1ed
2026-09-21  8:22       ` Christoph Hellwig
2026-09-09  6:09 ` [PATCH 14/16] xfs: add error injection for lazy " Christoph Hellwig
2026-09-09  6:09 ` [PATCH 15/16] xfs: log a message at mount time when using integrity protection Christoph Hellwig
2026-09-09  6:09 ` [PATCH 16/16] block,iomap: remove the old read side bounce buffering support Christoph Hellwig
2026-09-09 16:15   ` Darrick J. Wong
2026-09-10 20:50 ` lazy bounce buffering for checksummed reads v3 Jens Axboe
2026-09-10 20:51   ` Jens Axboe
2026-09-11 11:44     ` Christoph Hellwig
2026-09-11 13:38       ` Jens Axboe
2026-09-11  3:57 ` Anuj gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arDN1UdZIydNLUjz@shinmob \
    --to=shinichiro.kawasaki@wdc.com \
    --cc=anuj20.g@samsung.com \
    --cc=axboe@kernel.dk \
    --cc=brauner@kernel.org \
    --cc=cem@kernel.org \
    --cc=djwong@kernel.org \
    --cc=hch@lst.de \
    --cc=l7z@0b1t.tech \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=tz2294@columbia.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox