[PATCH blktests v2] block/049: test polled dio with user PI metadata

[PATCH blktests v2] block/049: test polled dio with user PI metadata

[Yang Xiuwei]

IOPOLL combined with a PI attribute used to leave iocb->private as a
uio_meta and oops in bio_poll(). The kernel rejects that combination
with -EOPNOTSUPP. Add a scsi_debug reproducer that expects this result.

Assisted-by: LLM
Signed-off-by: Yang Xiuwei <yangxiuwei@kylinos.cn>
---
v2:
- Resend now that 2a42e6fe1293 ("block: reject polled dio with user
  integrity metadata") is in Linus' tree.
- Add the copyright in src/metadata-iopoll.c.
- Use _have_loadable_scsi_debug instead of "_have_module scsi_debug".
- Skip kernels without IORING_FEAT_RW_ATTR.

v1: https://lore.kernel.org/linux-block/20260924025526.298050-1-yangxiuwei@kylinos.cn/

 src/Makefile          |   1 +
 src/metadata-iopoll.c | 112 ++++++++++++++++++++++++++++++++++++++++++
 tests/block/049       |  56 +++++++++++++++++++++
 tests/block/049.out   |   2 +
 4 files changed, 171 insertions(+)
 create mode 100644 src/metadata-iopoll.c
 create mode 100755 tests/block/049
 create mode 100644 tests/block/049.out

diff --git a/src/Makefile b/src/Makefile
index dd64694..1e571c6 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -31,6 +31,7 @@ C_TARGETS := \
 	zbdioctl
 
 C_URING_TARGETS := metadata \
+	metadata-iopoll \
 	nvme-passthru-admin-uring
 C_UBLK_TARGETS := miniublk
 
diff --git a/src/metadata-iopoll.c b/src/metadata-iopoll.c
new file mode 100644
index 0000000..a452b04
--- /dev/null
+++ b/src/metadata-iopoll.c
@@ -0,0 +1,112 @@
+// SPDX-License-Identifier: GPL-3.0+
+// Copyright (C) 2026 Yang Xiuwei <yangxiuwei@kylinos.cn>
+/*
+ * IOPOLL direct read with a PI attribute. The fixed kernel completes it
+ * with -EOPNOTSUPP.
+ */
+#include <errno.h>
+#include <fcntl.h>
+#include <signal.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <unistd.h>
+#include <liburing.h>
+
+#ifndef IORING_RW_ATTR_FLAG_PI
+#define PI_URING_COMPAT
+#define IORING_RW_ATTR_FLAG_PI (1U << 0)
+struct io_uring_attr_pi {
+	__u16 flags;
+	__u16 app_tag;
+	__u32 len;
+	__u64 addr;
+	__u64 seed;
+	__u64 rsvd;
+};
+#endif
+
+#ifndef IO_INTEGRITY_CHK_GUARD
+#define IO_INTEGRITY_CHK_GUARD  (1U << 0)
+#define IO_INTEGRITY_CHK_REFTAG (1U << 1)
+#endif
+
+#ifndef IORING_FEAT_RW_ATTR
+#define IORING_FEAT_RW_ATTR	(1U << 16)
+#endif
+
+#define DATA_LEN 4096
+#define META_LEN 64
+
+static void on_alarm(int sig)
+{
+	(void)sig;
+	dprintf(STDERR_FILENO, "timed out\n");
+	_exit(1);
+}
+
+int main(int argc, char **argv)
+{
+	struct io_uring ring;
+	struct io_uring_sqe *sqe;
+	struct io_uring_cqe *cqe;
+	struct io_uring_attr_pi pi = {
+		.flags = IO_INTEGRITY_CHK_GUARD | IO_INTEGRITY_CHK_REFTAG,
+		.len = META_LEN,
+		.seed = 1,
+	};
+	void *data, *meta;
+	int fd, ret;
+
+	if (argc != 2)
+		return 1;
+
+	signal(SIGALRM, on_alarm);
+	alarm(10);
+
+	fd = open(argv[1], O_RDONLY | O_DIRECT);
+	if (fd < 0) {
+		perror("open");
+		return 1;
+	}
+	if (posix_memalign(&data, 4096, DATA_LEN) ||
+	    posix_memalign(&meta, 4096, META_LEN)) {
+		perror("posix_memalign");
+		return 1;
+	}
+	pi.addr = (__u64)(uintptr_t)meta;
+
+	ret = io_uring_queue_init(8, &ring, IORING_SETUP_IOPOLL);
+	if (ret < 0) {
+		fprintf(stderr, "queue_init: %s\n", strerror(-ret));
+		return 1;
+	}
+	if (!(ring.features & IORING_FEAT_RW_ATTR))
+		return 2;
+	sqe = io_uring_get_sqe(&ring);
+	if (!sqe)
+		return 1;
+	io_uring_prep_read(sqe, fd, data, DATA_LEN, 0);
+#ifdef PI_URING_COMPAT
+	sqe->__pad2[0] = IORING_RW_ATTR_FLAG_PI;
+	sqe->addr3 = (__u64)&pi;
+#else
+	sqe->attr_type_mask = IORING_RW_ATTR_FLAG_PI;
+	sqe->attr_ptr = (__u64)&pi;
+#endif
+	ret = io_uring_submit(&ring);
+	if (ret < 1) {
+		fprintf(stderr, "submit: %d\n", ret);
+		return 1;
+	}
+	ret = io_uring_wait_cqe(&ring, &cqe);
+	if (ret < 0) {
+		fprintf(stderr, "wait: %s\n", strerror(-ret));
+		return 1;
+	}
+	if (cqe->res != -EOPNOTSUPP) {
+		fprintf(stderr, "cqe %d\n", cqe->res);
+		return 1;
+	}
+	return 0;
+}
diff --git a/tests/block/049 b/tests/block/049
new file mode 100755
index 0000000..5ceefbe
--- /dev/null
+++ b/tests/block/049
@@ -0,0 +1,56 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-3.0+
+# Copyright (C) 2026 Yang Xiuwei <yangxiuwei@kylinos.cn>
+#
+# IOPOLL combined with a PI attribute used to oops in bio_poll(). The kernel
+# rejects that combination with -EOPNOTSUPP.
+#
+# Regression test for kernel commit 2a42e6fe1293 ("block: reject polled dio
+# with user integrity metadata").
+#
+# Kernels without IORING_FEAT_RW_ATTR are skipped. Kernels that advertise the
+# feature but lack 2a42e6fe1293 oops in bio_poll().
+
+. tests/block/rc
+. common/scsi_debug
+
+DESCRIPTION="iopoll dio with user PI metadata returns -EOPNOTSUPP"
+QUICK=1
+
+requires() {
+	_have_kernel_option IO_URING
+	_have_kernel_option BLK_DEV_INTEGRITY
+	_have_loadable_scsi_debug
+	_have_src_program metadata-iopoll
+}
+
+test() {
+	echo "Running ${TEST_NAME}"
+
+	if ! _init_scsi_debug dif=1 dix=1 dev_size_mb=64 sector_size=512 \
+			submit_queues=2 poll_queues=1; then
+		return 1
+	fi
+
+	local dev="${SCSI_DEBUG_DEVICES[0]}"
+
+	if [[ "$(<"/sys/block/${dev}/queue/io_poll")" != 1 ]]; then
+		SKIP_REASONS+=("scsi_debug has no poll queue")
+		_exit_scsi_debug
+		return
+	fi
+
+	src/metadata-iopoll "/dev/${dev}" >>"$FULL" 2>&1
+	local rc=$?
+
+	_exit_scsi_debug
+	if ((rc == 2)); then
+		SKIP_REASONS+=("io_uring PI attributes not supported")
+		return
+	fi
+	if ((rc)); then
+		echo "metadata-iopoll failed"
+		return 1
+	fi
+	echo "Test complete"
+}
diff --git a/tests/block/049.out b/tests/block/049.out
new file mode 100644
index 0000000..c88edfe
--- /dev/null
+++ b/tests/block/049.out
@@ -0,0 +1,2 @@
+Running block/049
+Test complete
-- 
2.25.1

Re: [PATCH blktests v2] block/049: test polled dio with user PI metadata

[Shin'ichiro Kawasaki]

On Oct 08, 2026 / 11:17, Yang Xiuwei wrote:
> IOPOLL combined with a PI attribute used to leave iocb->private as a
> uio_meta and oops in bio_poll(). The kernel rejects that combination
> with -EOPNOTSUPP. Add a scsi_debug reproducer that expects this result.

I applied this v2 patch. Thanks!