From: Phillip Potter <phil@philpotter.co.uk>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-block@vger.kernel.org,
Phillip Potter <phil@philpotter.co.uk>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] cdrom: drop linux/fs.h from cdrom.h
Date: Fri, 23 Oct 2026 22:06:31 +0100 [thread overview]
Message-ID: <atvMV1rHU1nfcRwu@equinox> (raw)
In-Reply-To: <20261020170322.3687068-1-rdunlap@infradead.org>
On Tue, Oct 20, 2026 at 10:03:22AM -0700, Randy Dunlap wrote:
> The comment "not really needed" has been there since the inception
> of git history. I have done build testing of all files that use
> <linux/cdrom.h> with no problems found.
>
> <linux/libata.h> includes <linux/cdrom.h>. I have also build tested
> 99% of the files that use <linux/libata.h> with no build issues found.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Phillip Potter <phil@philpotter.co.uk>
> Cc: Jens Axboe <axboe@kernel.dk>
>
> include/linux/cdrom.h | 1 -
> 1 file changed, 1 deletion(-)
>
> --- linux-next-20261019.orig/include/linux/cdrom.h
> +++ linux-next-20261019/include/linux/cdrom.h
> @@ -11,7 +11,6 @@
> #ifndef _LINUX_CDROM_H
> #define _LINUX_CDROM_H
>
> -#include <linux/fs.h> /* not really needed, later.. */
> #include <linux/list.h>
> #include <linux/blkdev.h>
> #include <scsi/scsi_common.h>
Hi Randy,
Looks good to me, I've built and runtime tested this too.
Will pass on for inclusion, thanks.
Regards,
Phil
prev parent reply other threads:[~2026-10-23 21:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 17:03 [PATCH] cdrom: drop linux/fs.h from cdrom.h Randy Dunlap
2026-10-23 21:06 ` Phillip Potter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atvMV1rHU1nfcRwu@equinox \
--to=phil@philpotter.co.uk \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox