* [PATCH] cdrom: drop linux/fs.h from cdrom.h
@ 2026-10-20 17:03 Randy Dunlap
2026-10-23 21:06 ` Phillip Potter
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2026-10-20 17:03 UTC (permalink / raw)
To: linux-block; +Cc: Randy Dunlap, Phillip Potter, Jens Axboe
The comment "not really needed" has been there since the inception
of git history. I have done build testing of all files that use
<linux/cdrom.h> with no problems found.
<linux/libata.h> includes <linux/cdrom.h>. I have also build tested
99% of the files that use <linux/libata.h> with no build issues found.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Phillip Potter <phil@philpotter.co.uk>
Cc: Jens Axboe <axboe@kernel.dk>
include/linux/cdrom.h | 1 -
1 file changed, 1 deletion(-)
--- linux-next-20261019.orig/include/linux/cdrom.h
+++ linux-next-20261019/include/linux/cdrom.h
@@ -11,7 +11,6 @@
#ifndef _LINUX_CDROM_H
#define _LINUX_CDROM_H
-#include <linux/fs.h> /* not really needed, later.. */
#include <linux/list.h>
#include <linux/blkdev.h>
#include <scsi/scsi_common.h>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] cdrom: drop linux/fs.h from cdrom.h
2026-10-20 17:03 [PATCH] cdrom: drop linux/fs.h from cdrom.h Randy Dunlap
@ 2026-10-23 21:06 ` Phillip Potter
0 siblings, 0 replies; 2+ messages in thread
From: Phillip Potter @ 2026-10-23 21:06 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-block, Phillip Potter, Jens Axboe
On Tue, Oct 20, 2026 at 10:03:22AM -0700, Randy Dunlap wrote:
> The comment "not really needed" has been there since the inception
> of git history. I have done build testing of all files that use
> <linux/cdrom.h> with no problems found.
>
> <linux/libata.h> includes <linux/cdrom.h>. I have also build tested
> 99% of the files that use <linux/libata.h> with no build issues found.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Phillip Potter <phil@philpotter.co.uk>
> Cc: Jens Axboe <axboe@kernel.dk>
>
> include/linux/cdrom.h | 1 -
> 1 file changed, 1 deletion(-)
>
> --- linux-next-20261019.orig/include/linux/cdrom.h
> +++ linux-next-20261019/include/linux/cdrom.h
> @@ -11,7 +11,6 @@
> #ifndef _LINUX_CDROM_H
> #define _LINUX_CDROM_H
>
> -#include <linux/fs.h> /* not really needed, later.. */
> #include <linux/list.h>
> #include <linux/blkdev.h>
> #include <scsi/scsi_common.h>
Hi Randy,
Looks good to me, I've built and runtime tested this too.
Will pass on for inclusion, thanks.
Regards,
Phil
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-23 21:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-20 17:03 [PATCH] cdrom: drop linux/fs.h from cdrom.h Randy Dunlap
2026-10-23 21:06 ` Phillip Potter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox