[PATCH] floppy: fix the message printed by floppy_set_flags()

[PATCH] floppy: fix the message printed by floppy_set_flags()

[Denis Efremov (Oracle)]

floppy_set_flags() sets the flag in param2 when param is non-zero and
clears it otherwise, but its message picks "Setting" or "Clearing" from
param2 and prints param as the flag. So floppy=thinkpad prints "Setting
flag 0x1", and floppy=0,thinkpad prints "Setting flag 0x0" while it
clears FD_INVERTED_DCL.

Swap the two arguments, so that these print "Setting flag 0x80" and
"Clearing flag 0x80".

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Denis Efremov (Oracle) <efremov@linux.com>
---
 drivers/block/floppy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index f04397b8e381..b6f73a11bff4 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -4321,7 +4321,7 @@ static void __init floppy_set_flags(int *ints, int param, int param2)
 		else
 			default_drive_params[i].params.flags &= ~param2;
 	}
-	DPRINT("%s flag 0x%x\n", param2 ? "Setting" : "Clearing", param);
+	DPRINT("%s flag 0x%x\n", param ? "Setting" : "Clearing", param2);
 }
 
 static void __init daring(int *ints, int param, int param2)

base-commit: 3857c2fe5449541e24afc5efdb0f81a8a8f9a3a0
-- 
2.56.0

Re: [PATCH] floppy: fix the message printed by floppy_set_flags()

[shinichiro.kawasaki]

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

Dear patch submitter,

Blktests CI has tested the following submission:
Status:     FAILURE
Name:       floppy: fix the message printed by floppy_set_flags()
Patchwork:  https://patchwork.kernel.org/series/1182942/&state=*
Run record: https://github.com/linux-blktests/linux-block/actions/runs/42335906443


All test cases passed

Re: [PATCH] floppy: fix the message printed by floppy_set_flags()

[Shin'ichiro Kawasaki]

Please ignore this report. It was sent unexpectedly by blktestes-ci
misconfiguration. Sorry for the noise.