From: Hannes Reinecke <hare@suse.de>
To: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Yu Kuai <yukuai3@huawei.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V3 4/6] block: mtip32xx: don't touch q->queue_hw_ctx
Date: Mon, 7 Mar 2022 08:36:51 +0100 [thread overview]
Message-ID: <bf5c7f13-62d6-23cb-9ce0-2856c86d4b30@suse.de> (raw)
In-Reply-To: <20220307064401.30056-5-ming.lei@redhat.com>
On 3/7/22 07:43, Ming Lei wrote:
> q->queue_hw_ctx is really one blk-mq internal structure for retrieving
> hctx via its index, not supposed to be used by drivers. Meantime drivers
> can get the tags structure easily from tagset.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
> drivers/block/mtip32xx/mtip32xx.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
next prev parent reply other threads:[~2022-03-07 7:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 6:43 [PATCH V3 0/6] blk-mq: update_nr_hw_queues related improvement & bugfix Ming Lei
2022-03-07 6:43 ` [PATCH V3 1/6] blk-mq: figure out correct numa node for hw queue Ming Lei
2022-03-07 7:34 ` Hannes Reinecke
2022-03-07 6:43 ` [PATCH V3 2/6] blk-mq: simplify reallocation of hw ctxs a bit Ming Lei
2022-03-07 7:35 ` Hannes Reinecke
2022-03-07 6:43 ` [PATCH V3 3/6] blk-mq: reconfigure poll after queue map is changed Ming Lei
2022-03-07 7:10 ` Christoph Hellwig
2022-03-07 7:36 ` Hannes Reinecke
2022-03-07 6:43 ` [PATCH V3 4/6] block: mtip32xx: don't touch q->queue_hw_ctx Ming Lei
2022-03-07 7:36 ` Hannes Reinecke [this message]
2022-03-07 6:44 ` [PATCH V3 5/6] blk-mq: prepare for implementing hctx table via xarray Ming Lei
2022-03-07 7:10 ` Christoph Hellwig
2022-03-07 7:38 ` Hannes Reinecke
2022-03-07 6:44 ` [PATCH V3 6/6] blk-mq: manage hctx map " Ming Lei
2022-03-07 7:13 ` Christoph Hellwig
2022-03-07 7:44 ` Ming Lei
2022-03-07 7:44 ` Hannes Reinecke
2022-03-07 7:49 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf5c7f13-62d6-23cb-9ce0-2856c86d4b30@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox