Linux block layer
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: Keith Busch <kbusch@kernel.org>, linux-block@vger.kernel.org
Subject: Re: cleanup for the recent bio_iov_iter_get_pages changes
Date: Tue, 7 Oct 2025 20:06:24 +1030	[thread overview]
Message-ID: <bf5d56b5-4212-4d83-b3da-51fd200a37cc@gmx.com> (raw)
In-Reply-To: <20251007090642.3251548-1-hch@lst.de>



在 2025/10/7 19:36, Christoph Hellwig 写道:
> Hi all,
> 
> while looking over the bio splitting issue reported by Qu, I noticed
> that some of the recent changes to bio_iov_iter_get_pages lead to
> more indirections than really needed, especially with the bcachefs
> abuse now removed in 6.18-rc.  This small series cleans this up
> an prepares for the file system block size splitting needed by
> btrfs bs > PAGE_SIZE support.

Looks good to me, and makes my later changes much easier.

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu
> 
> Diffstat:
>   block/bio.c            |    5 ++---
>   block/blk-map.c        |    6 +++++-
>   block/fops.c           |   13 ++++++++++---
>   fs/iomap/direct-io.c   |    3 ++-
>   include/linux/bio.h    |    7 +------
>   include/linux/blkdev.h |    7 -------
>   6 files changed, 20 insertions(+), 21 deletions(-)


  parent reply	other threads:[~2025-10-07  9:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-07  9:06 cleanup for the recent bio_iov_iter_get_pages changes Christoph Hellwig
2025-10-07  9:06 ` [PATCH 1/4] block: remove bio_iov_iter_get_pages Christoph Hellwig
2025-10-07  9:06 ` [PATCH 2/4] block: rename bio_iov_iter_get_pages_aligned to bio_iov_iter_get_pages Christoph Hellwig
2025-10-07  9:06 ` [PATCH 3/4] iomap: open code bio_iov_iter_get_bdev_pages Christoph Hellwig
2025-10-07  9:06 ` [PATCH 4/4] block: move bio_iov_iter_get_bdev_pages to block/fops.c Christoph Hellwig
2025-10-07 11:57   ` shinichiro.kawasaki
2025-10-07 12:57     ` Keith Busch
2025-10-08  0:07       ` Shinichiro Kawasaki
2025-10-07  9:36 ` Qu Wenruo [this message]
2025-10-07 12:46 ` cleanup for the recent bio_iov_iter_get_pages changes Keith Busch
2025-10-07 12:55 ` Johannes Thumshirn
2025-10-07 13:31 ` Martin K. Petersen
2025-10-07 14:06 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf5d56b5-4212-4d83-b3da-51fd200a37cc@gmx.com \
    --to=quwenruo.btrfs@gmx.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox