From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Qu Wenruo <quwenruo.btrfs@gmx.com>,
Keith Busch <kbusch@kernel.org>,
linux-block@vger.kernel.org
Subject: Re: cleanup for the recent bio_iov_iter_get_pages changes
Date: Tue, 07 Oct 2025 09:31:52 -0400 [thread overview]
Message-ID: <yq1qzveet3q.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20251007090642.3251548-1-hch@lst.de> (Christoph Hellwig's message of "Tue, 7 Oct 2025 11:06:24 +0200")
Christoph,
> while looking over the bio splitting issue reported by Qu, I noticed
> that some of the recent changes to bio_iov_iter_get_pages lead to more
> indirections than really needed, especially with the bcachefs abuse
> now removed in 6.18-rc. This small series cleans this up an prepares
> for the file system block size splitting needed by btrfs bs >
> PAGE_SIZE support.
Looks fine.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen
next prev parent reply other threads:[~2025-10-07 13:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 9:06 cleanup for the recent bio_iov_iter_get_pages changes Christoph Hellwig
2025-10-07 9:06 ` [PATCH 1/4] block: remove bio_iov_iter_get_pages Christoph Hellwig
2025-10-07 9:06 ` [PATCH 2/4] block: rename bio_iov_iter_get_pages_aligned to bio_iov_iter_get_pages Christoph Hellwig
2025-10-07 9:06 ` [PATCH 3/4] iomap: open code bio_iov_iter_get_bdev_pages Christoph Hellwig
2025-10-07 9:06 ` [PATCH 4/4] block: move bio_iov_iter_get_bdev_pages to block/fops.c Christoph Hellwig
2025-10-07 11:57 ` shinichiro.kawasaki
2025-10-07 12:57 ` Keith Busch
2025-10-08 0:07 ` Shinichiro Kawasaki
2025-10-07 9:36 ` cleanup for the recent bio_iov_iter_get_pages changes Qu Wenruo
2025-10-07 12:46 ` Keith Busch
2025-10-07 12:55 ` Johannes Thumshirn
2025-10-07 13:31 ` Martin K. Petersen [this message]
2025-10-07 14:06 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1qzveet3q.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox