Linux block layer
 help / color / mirror / Atom feed
From: Anuj Gupta/Anuj Gupta <anuj20.g@samsung.com>
To: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: "vincent.fu@samsung.com" <vincent.fu@samsung.com>,
	"anuj1072538@gmail.com" <anuj1072538@gmail.com>,
	"axboe@kernel.dk" <axboe@kernel.dk>,
	"hch@infradead.org" <hch@infradead.org>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"joshi.k@samsung.com" <joshi.k@samsung.com>,
	"gost.dev@samsung.com" <gost.dev@samsung.com>
Subject: Re: [blktests v1] block: add test for io_uring Protection Information (PI) interface using FS_IOC_GETLBMD_CAP
Date: Mon, 11 Aug 2025 16:33:03 +0530	[thread overview]
Message-ID: <c1d4d4b6-ef17-4726-bfbc-0ac1cd04c1ed@samsung.com> (raw)
In-Reply-To: <v23bumua6pdez2kizqihersvyp4c5i6d5mecagtddwl426aaec@wfnq7zumao5n>

On 8/8/2025 5:10 PM, Shinichiro Kawasaki wrote:
> On Aug 05, 2025 / 11:46, Anuj Gupta wrote:
>> This test verifies end-to-end support for integrity metadata via the
>> io-uring interface. It uses the FS_IOC_GETLBMD_CAP ioctl to query the
>> logical block metadata capabilities of the device. These values are then
>> passed to fio using the md_per_io_size option.
>>
>> io_uring PI interface: https://lore.kernel.org/all/20241128112240.8867-1-anuj20.g@samsung.com/
>> fio support for interface: https://lore.kernel.org/all/20250725175808.2632-2-vincent.fu@samsung.com/
>> ioctl: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git/log/?h=vfs-6.17.integrity
>> Signed-off-by: Anuj Gupta <anuj20.g@samsung.com>
>> Signed-off-by: Vincent Fu <vincent.fu@samsung.com>
> 
> Anuj, thank you for the patch.
> 
> I wonder which test group this test case should go into, block or nvme. IIUC,
> this test case runs only for nvme devices. Said that, block group looks good for
> me since the test target ioctl interface belongs to the block layer.
> 
> I tried to run the test case using QEMU NVME emulation devices with some
> ms=X,pi=Y options, but the test runs failed. The kernel reported a number of
> "protection error"s. Can we run the test case with QEMU NVME emulation device?
> If so, could you share the recommended set up of the device?

Could you please share/paste the errors that you encountered?

The issue occurs because setting ms and pi in the QEMU command line is
not enough, the namespace still needs to be formatted. Could you please
run the test again after running the nvme format command on device with 
the desired LBA format (PI enabled).

Thanks,
Anuj





  reply	other threads:[~2025-08-11 16:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20250805061730epcas5p4ae7a8eda6d1d11cc90317a80738eb2ea@epcas5p4.samsung.com>
2025-08-05  6:16 ` [blktests v1] block: add test for io_uring Protection Information (PI) interface using FS_IOC_GETLBMD_CAP Anuj Gupta
2025-08-06  2:51   ` Martin K. Petersen
2025-08-08 11:40   ` Shinichiro Kawasaki
2025-08-11 11:03     ` Anuj Gupta/Anuj Gupta [this message]
2025-08-13 11:24       ` Shinichiro Kawasaki
2025-09-19 10:12         ` Anuj Gupta/Anuj Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1d4d4b6-ef17-4726-bfbc-0ac1cd04c1ed@samsung.com \
    --to=anuj20.g@samsung.com \
    --cc=anuj1072538@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=gost.dev@samsung.com \
    --cc=hch@infradead.org \
    --cc=joshi.k@samsung.com \
    --cc=linux-block@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=shinichiro.kawasaki@wdc.com \
    --cc=vincent.fu@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox