Linux block layer
 help / color / mirror / Atom feed
From: Anuj Gupta/Anuj Gupta <anuj20.g@samsung.com>
To: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: "vincent.fu@samsung.com" <vincent.fu@samsung.com>,
	"anuj1072538@gmail.com" <anuj1072538@gmail.com>,
	"axboe@kernel.dk" <axboe@kernel.dk>,
	"hch@infradead.org" <hch@infradead.org>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"joshi.k@samsung.com" <joshi.k@samsung.com>,
	"gost.dev@samsung.com" <gost.dev@samsung.com>
Subject: Re: [blktests v1] block: add test for io_uring Protection Information (PI) interface using FS_IOC_GETLBMD_CAP
Date: Fri, 19 Sep 2025 15:42:37 +0530	[thread overview]
Message-ID: <efe392a5-0634-4774-9db3-b10ae2bd9cf8@samsung.com> (raw)
In-Reply-To: <odm6y33y4fhk3tqtxtnldvqmw4l37mbuhztauofsttj4y5i7dt@a5wogxejzpki>

> The errors were as follows:
> 
> block/041 => nvme1n1 (io_uring read with PI metadata buffer on block device) [failed]
>      runtime    ...  0.354s
>      --- tests/block/041.out     2025-08-13 19:56:15.487074413 +0900
>      +++ /home/shin/Blktests/blktests/results/nvme1n1/block/041.out.bad  2025-08-13 20:06:23.199291948 +0900
>      @@ -1,2 +1,12 @@
>       Running block/041
>      +fio: io_u error on file /dev/nvme1n1: Invalid or incomplete multibyte or wide character: read offset=12288, buflen=4096
>      +fio: io_u error on file /dev/nvme1n1: Invalid or incomplete multibyte or wide character: read offset=688128, buflen=4096
>      +fio: io_u error on file /dev/nvme1n1: Invalid or incomplete multibyte or wide character: read offset=630784, buflen=4096
>      +fio: io_u error on file /dev/nvme1n1: Invalid or incomplete multibyte or wide character: read offset=905216, buflen=4096
>      +fio: io_u error on file /dev/nvme1n1: Invalid or incomplete multibyte or wide character: read offset=233472, buflen=4096
>      +fio: io_u error on file /dev/nvme1n1: Invalid or incomplete multibyte or wide character: read offset=540672, buflen=4096
>      ...
>      (Run 'diff -u tests/block/041.out /home/shin/Blktests/blktests/results/nvme1n1/block/041.out.bad' to see the entire diff)
> 
>>
>> The issue occurs because setting ms and pi in the QEMU command line is
>> not enough, the namespace still needs to be formatted. Could you please
>> run the test again after running the nvme format command on device with
>> the desired LBA format (PI enabled).
> 
> Ah, thanks. I ran "nvme format -i 1 /dev/nvme0n1" for the QEMU NVME device
> prepared with QEMU NVME option "ms=8,pi=1", then the test case passes. The
> test case looks working as expected :)

Hi Shinichiro,

Thanks a lot for your detailed review comments. Sorry for the delay in 
re-spinning - I had a few conflicting deadlines.
I have addressed your feedback and sent out a v2 here:
https://lore.kernel.org/linux-block/20250919101028.14245-1-anuj20.g@samsung.com/

Thanks,
Anuj Gupta


      reply	other threads:[~2025-09-19 10:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20250805061730epcas5p4ae7a8eda6d1d11cc90317a80738eb2ea@epcas5p4.samsung.com>
2025-08-05  6:16 ` [blktests v1] block: add test for io_uring Protection Information (PI) interface using FS_IOC_GETLBMD_CAP Anuj Gupta
2025-08-06  2:51   ` Martin K. Petersen
2025-08-08 11:40   ` Shinichiro Kawasaki
2025-08-11 11:03     ` Anuj Gupta/Anuj Gupta
2025-08-13 11:24       ` Shinichiro Kawasaki
2025-09-19 10:12         ` Anuj Gupta/Anuj Gupta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=efe392a5-0634-4774-9db3-b10ae2bd9cf8@samsung.com \
    --to=anuj20.g@samsung.com \
    --cc=anuj1072538@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=gost.dev@samsung.com \
    --cc=hch@infradead.org \
    --cc=joshi.k@samsung.com \
    --cc=linux-block@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=shinichiro.kawasaki@wdc.com \
    --cc=vincent.fu@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox