Re: [PATCH] nvme-cli: nvmf-autoconnect: Consolidate vendor-specific NVMe-oF udev rules into a single file

[Xose Vazquez Perez <xose.vazquez@gmail.com>]

On 11/9/26 11:09 AM, Martin Wilck wrote:

> On Mon, 2026-11-09 at 01:08 +0100, Xose Vazquez Perez wrote:
>> Cc: John Garry <john.garry@linux.dev>
>> Cc: Nilay Shroff <nilay@linux.ibm.com>
>> Cc: Guixin Liu <kanie@linux.alibaba.com>
>> Cc: Wayne Berthiaume <Wayne.Berthiaume@dell.com>
>> Cc: Vasuki Manikarnike <vasuki.manikarnike@hpe.com>
>> Cc: Matthias Rudolph <Matthias.Rudolph@hitachivantara.com>
>> Cc: Martin George <marting@netapp.com>
>> Cc: NetApp RDAC team <ng-eseries-upstream-maintainers@netapp.com>
>> Cc: Zou Ming <zouming.zouming@huawei.com>
>> Cc: Li Xiaokeng <lixiaokeng@huawei.com>
>> Cc: Randy Jennings <randyj@purestorage.com>
>> Cc: Jyoti Rani <jrani@purestorage.com>
>> Cc: Brian Bunker <brian@purestorage.com>
>> Cc: Uday Shankar <ushankar@purestorage.com>
>> Cc: Chaitanya Kulkarni <kch@nvidia.com>
>> Cc: Sagi Grimberg <sagi@grimberg.me>
>> Cc: Keith Busch <kbusch@kernel.org>
>> Cc: Christoph Hellwig <hch@lst.de>
>> Cc: Marco Patalano <mpatalan@redhat.com>
>> Cc: Ewan D. Milne <emilne@redhat.com>
>> Cc: John Meneghini <jmeneghi@redhat.com>
>> Cc: Daniel Wagner <dwagner@suse.de>
>> Cc: Daniel Wagner <wagi@monom.org>
>> Cc: Hannes Reinecke <hare@suse.de>
>> Cc: Martin Wilck <mwilck@suse.com>
>> Cc: Benjamin Marzinski <bmarzins@redhat.com>
>> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
>> Cc: BLOCK-ML <linux-block@vger.kernel.org>
>> Cc: NVME-ML <linux-nvme@lists.infradead.org>
>> Cc: SCSI-ML <linux-scsi@vger.kernel.org>
>> Cc: DM_DEVEL-ML <dm-devel@lists.linux.dev>
>> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>

> Generally a good idea, but I think nvme-cli has a GitHub based
> development workflow these days.

While GitHub is an option, web-based interfaces tend to limit patch
visibility and broad review reach across subsystems. Mailing lists
remain far more versatile for cross-project visibility and discussion.

> I'm not a fan of repeated lengthy match expressions in udev rules.
> Can we improve the readability by using GOTOs and LABELS?

Using GOTOs and LABELS cleans up the duplicated model match expressions nicely.
However, the scope of this patch is intentionally kept to a pure consolidation.