* [PATCH] nvme-cli: nvmf-autoconnect: Consolidate vendor-specific NVMe-oF udev rules into a single file
@ 2026-11-09 0:08 Xose Vazquez Perez
2026-11-09 10:09 ` Martin Wilck
0 siblings, 1 reply; 3+ messages in thread
From: Xose Vazquez Perez @ 2026-11-09 0:08 UTC (permalink / raw)
Cc: Xose Vazquez Perez, John Garry, Nilay Shroff, Guixin Liu,
Wayne Berthiaume, Vasuki Manikarnike, Matthias Rudolph,
Martin George, NetApp RDAC team, Zou Ming, Li Xiaokeng,
Randy Jennings, Jyoti Rani, Brian Bunker, Uday Shankar,
Chaitanya Kulkarni, Sagi Grimberg, Keith Busch, Christoph Hellwig,
Marco Patalano, Ewan D. Milne, John Meneghini, Daniel Wagner,
Daniel Wagner, Hannes Reinecke, Martin Wilck, Benjamin Marzinski,
Christophe Varoqui, BLOCK-ML, NVME-ML, SCSI-ML, DM_DEVEL-ML
Replace individual vendor udev rules (HPE, NetApp, and VAST Data) with
a unified 80-nvmf-storage_arrays.rules file, leaving the rules untouched.
This shifts execution to the 80 range for a logical sequence after base
discovery and autoconnect, while simplifying maintenance and packaging.
Cc: John Garry <john.garry@linux.dev>
Cc: Nilay Shroff <nilay@linux.ibm.com>
Cc: Guixin Liu <kanie@linux.alibaba.com>
Cc: Wayne Berthiaume <Wayne.Berthiaume@dell.com>
Cc: Vasuki Manikarnike <vasuki.manikarnike@hpe.com>
Cc: Matthias Rudolph <Matthias.Rudolph@hitachivantara.com>
Cc: Martin George <marting@netapp.com>
Cc: NetApp RDAC team <ng-eseries-upstream-maintainers@netapp.com>
Cc: Zou Ming <zouming.zouming@huawei.com>
Cc: Li Xiaokeng <lixiaokeng@huawei.com>
Cc: Randy Jennings <randyj@purestorage.com>
Cc: Jyoti Rani <jrani@purestorage.com>
Cc: Brian Bunker <brian@purestorage.com>
Cc: Uday Shankar <ushankar@purestorage.com>
Cc: Chaitanya Kulkarni <kch@nvidia.com>
Cc: Sagi Grimberg <sagi@grimberg.me>
Cc: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Marco Patalano <mpatalan@redhat.com>
Cc: Ewan D. Milne <emilne@redhat.com>
Cc: John Meneghini <jmeneghi@redhat.com>
Cc: Daniel Wagner <dwagner@suse.de>
Cc: Daniel Wagner <wagi@monom.org>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Martin Wilck <mwilck@suse.com>
Cc: Benjamin Marzinski <bmarzins@redhat.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: BLOCK-ML <linux-block@vger.kernel.org>
Cc: NVME-ML <linux-nvme@lists.infradead.org>
Cc: SCSI-ML <linux-scsi@vger.kernel.org>
Cc: DM_DEVEL-ML <dm-devel@lists.linux.dev>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
BTW, there are two new I/O policies in development:
https://lore.kernel.org/linux-nvme/20260815173502.1185929-1-nilay@linux.ibm.com/
https://lore.kernel.org/linux-nvme/20261026111019.3724465-1-kanie@linux.alibaba.com/
---
meson.build | 4 +---
nvme.spec.in | 4 +---
.../udev-rules/71-nvmf-hpe.rules.in | 5 ----
.../udev-rules/71-nvmf-netapp.rules.in | 6 -----
.../udev-rules/71-nvmf-vastdata.rules.in | 5 ----
.../80-nvmf-storage_arrays.rules.in | 23 +++++++++++++++++++
6 files changed, 25 insertions(+), 22 deletions(-)
delete mode 100644 nvmf-autoconnect/udev-rules/71-nvmf-hpe.rules.in
delete mode 100644 nvmf-autoconnect/udev-rules/71-nvmf-netapp.rules.in
delete mode 100644 nvmf-autoconnect/udev-rules/71-nvmf-vastdata.rules.in
create mode 100644 nvmf-autoconnect/udev-rules/80-nvmf-storage_arrays.rules.in
diff --git a/meson.build b/meson.build
index 90356ad94..00e9ad1be 100644
--- a/meson.build
+++ b/meson.build
@@ -894,9 +894,7 @@ if want_nvme
udev_files = {
'65-persistent-net-nbft.rules': 'nvmf',
'70-nvmf-keys.rules': 'nvmf-autoconnect',
- '71-nvmf-hpe.rules': 'nvmf',
- '71-nvmf-netapp.rules': 'nvmf',
- '71-nvmf-vastdata.rules': 'nvmf',
+ '80-nvmf-storage_arrays.rules': 'nvmf',
}
if want_nvmf_autoconnect
udev_files += {'70-nvmf-autoconnect.rules': 'nvmf-autoconnect'}
diff --git a/nvme.spec.in b/nvme.spec.in
index 23d3d3268..a37c1a08d 100644
--- a/nvme.spec.in
+++ b/nvme.spec.in
@@ -36,9 +36,7 @@ touch %{buildroot}@SYSCONFDIR@/nvme/hostid
@UDEVRULESDIR@/65-persistent-net-nbft.rules
@UDEVRULESDIR@/70-nvmf-autoconnect.rules
@UDEVRULESDIR@/70-nvmf-keys.rules
-@UDEVRULESDIR@/71-nvmf-hpe.rules
-@UDEVRULESDIR@/71-nvmf-netapp.rules
-@UDEVRULESDIR@/71-nvmf-vastdata.rules
+@UDEVRULESDIR@/80-nvmf-storage_arrays.rules
@DRACUTRULESDIR@/70-nvmf-autoconnect.conf
@SYSTEMDDIR@/nvmf-connect@.service
@SYSTEMDDIR@/nvmefc-boot-connections.service
diff --git a/nvmf-autoconnect/udev-rules/71-nvmf-hpe.rules.in b/nvmf-autoconnect/udev-rules/71-nvmf-hpe.rules.in
deleted file mode 100644
index b050dd502..000000000
--- a/nvmf-autoconnect/udev-rules/71-nvmf-hpe.rules.in
+++ /dev/null
@@ -1,5 +0,0 @@
-# Set appropriate iopolicy for HPE Alletra Storage MP
-ACTION=="add", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{model}=="HPE Alletra", ATTR{iopolicy}="round-robin"
-
-# Set ctrl_loss_tmo to -1 for HPE Alletra Storage MP NVMe/TCP
-ACTION!="remove", SUBSYSTEM=="nvme", KERNEL=="nvme*", ATTR{transport}=="tcp", ATTR{model}=="HPE Alletra", ATTR{ctrl_loss_tmo}="-1"
diff --git a/nvmf-autoconnect/udev-rules/71-nvmf-netapp.rules.in b/nvmf-autoconnect/udev-rules/71-nvmf-netapp.rules.in
deleted file mode 100644
index c76a3c434..000000000
--- a/nvmf-autoconnect/udev-rules/71-nvmf-netapp.rules.in
+++ /dev/null
@@ -1,6 +0,0 @@
-# Set appropriate iopolicy for NetApp ONTAP and NetApp E-Series
-ACTION=="add", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{model}=="NetApp ONTAP Controller", ATTR{iopolicy}="queue-depth"
-ACTION=="add", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{model}=="NetApp E-Series", ATTR{iopolicy}="round-robin"
-
-# Set ctrl_loss_tmo to -1 for NetApp ONTAP NVMe/TCP
-ACTION!="remove", SUBSYSTEM=="nvme", KERNEL=="nvme*", ATTR{transport}=="tcp", ATTR{model}=="NetApp ONTAP Controller", ATTR{ctrl_loss_tmo}="-1"
diff --git a/nvmf-autoconnect/udev-rules/71-nvmf-vastdata.rules.in b/nvmf-autoconnect/udev-rules/71-nvmf-vastdata.rules.in
deleted file mode 100644
index dcd6146d8..000000000
--- a/nvmf-autoconnect/udev-rules/71-nvmf-vastdata.rules.in
+++ /dev/null
@@ -1,5 +0,0 @@
-# Enable round-robin for Vast Data Block Subsystem
-ACTION=="add", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{model}=="VASTData", ATTR{iopolicy}="round-robin"
-
-# Set ctrl_loss_tmo to -1 for Vast Data Block Controller
-ACTION!="remove", SUBSYSTEM=="nvme", KERNEL=="nvme*", ATTR{model}=="VASTData", ATTR{ctrl_loss_tmo}="-1"
diff --git a/nvmf-autoconnect/udev-rules/80-nvmf-storage_arrays.rules.in b/nvmf-autoconnect/udev-rules/80-nvmf-storage_arrays.rules.in
new file mode 100644
index 000000000..1cd6c0c0b
--- /dev/null
+++ b/nvmf-autoconnect/udev-rules/80-nvmf-storage_arrays.rules.in
@@ -0,0 +1,23 @@
+##### Storage arrays
+
+#### Set iopolicy for NVMe-oF
+### iopolicy: numa (default), round-robin (>=5.1), or queue-depth (>=6.11)
+
+## HPE
+# Alletra 9000 / Alletra Storage MP / GreenLake Block Storage MP
+ACTION=="add", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{model}=="HPE Alletra", ATTR{iopolicy}="round-robin"
+ACTION!="remove", SUBSYSTEM=="nvme", KERNEL=="nvme*", ATTR{transport}=="tcp", ATTR{model}=="HPE Alletra", ATTR{ctrl_loss_tmo}="-1"
+
+## NetApp
+# ONTAP AFF/ASA Series
+ACTION=="add", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{model}=="NetApp ONTAP Controller", ATTR{iopolicy}="queue-depth"
+ACTION!="remove", SUBSYSTEM=="nvme", KERNEL=="nvme*", ATTR{transport}=="tcp", ATTR{model}=="NetApp ONTAP Controller", ATTR{ctrl_loss_tmo}="-1"
+# E/EF-Series
+ACTION=="add", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{model}=="NetApp E-Series", ATTR{iopolicy}="round-robin"
+
+## VAST Data
+# Block Subsystem
+ACTION=="add", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{model}=="VASTData", ATTR{iopolicy}="round-robin"
+ACTION!="remove", SUBSYSTEM=="nvme", KERNEL=="nvme*", ATTR{model}=="VASTData", ATTR{ctrl_loss_tmo}="-1"
+
+##### EOF
--
2.56.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme-cli: nvmf-autoconnect: Consolidate vendor-specific NVMe-oF udev rules into a single file
2026-11-09 0:08 [PATCH] nvme-cli: nvmf-autoconnect: Consolidate vendor-specific NVMe-oF udev rules into a single file Xose Vazquez Perez
@ 2026-11-09 10:09 ` Martin Wilck
2026-11-09 10:28 ` Xose Vazquez Perez
0 siblings, 1 reply; 3+ messages in thread
From: Martin Wilck @ 2026-11-09 10:09 UTC (permalink / raw)
To: Xose Vazquez Perez
Cc: John Garry, Nilay Shroff, Guixin Liu, Wayne Berthiaume,
Vasuki Manikarnike, Matthias Rudolph, Martin George,
NetApp RDAC team, Zou Ming, Li Xiaokeng, Randy Jennings,
Jyoti Rani, Brian Bunker, Uday Shankar, Chaitanya Kulkarni,
Sagi Grimberg, Keith Busch, Christoph Hellwig, Marco Patalano,
Ewan D. Milne, John Meneghini, Daniel Wagner, Daniel Wagner,
Hannes Reinecke, Benjamin Marzinski, Christophe Varoqui, BLOCK-ML,
NVME-ML, SCSI-ML, DM_DEVEL-ML
On Mon, 2026-11-09 at 01:08 +0100, Xose Vazquez Perez wrote:
> Replace individual vendor udev rules (HPE, NetApp, and VAST Data)
> with
> a unified 80-nvmf-storage_arrays.rules file, leaving the rules
> untouched.
>
> This shifts execution to the 80 range for a logical sequence after
> base
> discovery and autoconnect, while simplifying maintenance and
> packaging.
>
> Cc: John Garry <john.garry@linux.dev>
> Cc: Nilay Shroff <nilay@linux.ibm.com>
> Cc: Guixin Liu <kanie@linux.alibaba.com>
> Cc: Wayne Berthiaume <Wayne.Berthiaume@dell.com>
> Cc: Vasuki Manikarnike <vasuki.manikarnike@hpe.com>
> Cc: Matthias Rudolph <Matthias.Rudolph@hitachivantara.com>
> Cc: Martin George <marting@netapp.com>
> Cc: NetApp RDAC team <ng-eseries-upstream-maintainers@netapp.com>
> Cc: Zou Ming <zouming.zouming@huawei.com>
> Cc: Li Xiaokeng <lixiaokeng@huawei.com>
> Cc: Randy Jennings <randyj@purestorage.com>
> Cc: Jyoti Rani <jrani@purestorage.com>
> Cc: Brian Bunker <brian@purestorage.com>
> Cc: Uday Shankar <ushankar@purestorage.com>
> Cc: Chaitanya Kulkarni <kch@nvidia.com>
> Cc: Sagi Grimberg <sagi@grimberg.me>
> Cc: Keith Busch <kbusch@kernel.org>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Marco Patalano <mpatalan@redhat.com>
> Cc: Ewan D. Milne <emilne@redhat.com>
> Cc: John Meneghini <jmeneghi@redhat.com>
> Cc: Daniel Wagner <dwagner@suse.de>
> Cc: Daniel Wagner <wagi@monom.org>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: Martin Wilck <mwilck@suse.com>
> Cc: Benjamin Marzinski <bmarzins@redhat.com>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: BLOCK-ML <linux-block@vger.kernel.org>
> Cc: NVME-ML <linux-nvme@lists.infradead.org>
> Cc: SCSI-ML <linux-scsi@vger.kernel.org>
> Cc: DM_DEVEL-ML <dm-devel@lists.linux.dev>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
Generally a good idea, but I think nvme-cli has a GitHub based
development workflow these days.
> ---
> BTW, there are two new I/O policies in development:
> https://lore.kernel.org/linux-nvme/20260815173502.1185929-1-nilay@linux.ibm.com/
> https://lore.kernel.org/linux-nvme/20261026111019.3724465-1-kanie@linux.alibaba.com/
> ---
> meson.build | 4 +---
> nvme.spec.in | 4 +---
> .../udev-rules/71-nvmf-hpe.rules.in | 5 ----
> .../udev-rules/71-nvmf-netapp.rules.in | 6 -----
> .../udev-rules/71-nvmf-vastdata.rules.in | 5 ----
> .../80-nvmf-storage_arrays.rules.in | 23
> +++++++++++++++++++
> 6 files changed, 25 insertions(+), 22 deletions(-)
> delete mode 100644 nvmf-autoconnect/udev-rules/71-nvmf-hpe.rules.in
> delete mode 100644 nvmf-autoconnect/udev-rules/71-nvmf-
> netapp.rules.in
> delete mode 100644 nvmf-autoconnect/udev-rules/71-nvmf-
> vastdata.rules.in
> create mode 100644 nvmf-autoconnect/udev-rules/80-nvmf-
> storage_arrays.rules.in
>
> diff --git a/meson.build b/meson.build
> index 90356ad94..00e9ad1be 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -894,9 +894,7 @@ if want_nvme
> udev_files = {
> '65-persistent-net-nbft.rules': 'nvmf',
> '70-nvmf-keys.rules': 'nvmf-autoconnect',
> - '71-nvmf-hpe.rules': 'nvmf',
> - '71-nvmf-netapp.rules': 'nvmf',
> - '71-nvmf-vastdata.rules': 'nvmf',
> + '80-nvmf-storage_arrays.rules': 'nvmf',
> }
> if want_nvmf_autoconnect
> udev_files += {'70-nvmf-autoconnect.rules': 'nvmf-
> autoconnect'}
> diff --git a/nvme.spec.in b/nvme.spec.in
> index 23d3d3268..a37c1a08d 100644
> --- a/nvme.spec.in
> +++ b/nvme.spec.in
> @@ -36,9 +36,7 @@ touch %{buildroot}@SYSCONFDIR@/nvme/hostid
> @UDEVRULESDIR@/65-persistent-net-nbft.rules
> @UDEVRULESDIR@/70-nvmf-autoconnect.rules
> @UDEVRULESDIR@/70-nvmf-keys.rules
> -@UDEVRULESDIR@/71-nvmf-hpe.rules
> -@UDEVRULESDIR@/71-nvmf-netapp.rules
> -@UDEVRULESDIR@/71-nvmf-vastdata.rules
> +@UDEVRULESDIR@/80-nvmf-storage_arrays.rules
> @DRACUTRULESDIR@/70-nvmf-autoconnect.conf
> @SYSTEMDDIR@/nvmf-connect@.service
> @SYSTEMDDIR@/nvmefc-boot-connections.service
> diff --git a/nvmf-autoconnect/udev-rules/71-nvmf-hpe.rules.in b/nvmf-
> autoconnect/udev-rules/71-nvmf-hpe.rules.in
> deleted file mode 100644
> index b050dd502..000000000
> --- a/nvmf-autoconnect/udev-rules/71-nvmf-hpe.rules.in
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -# Set appropriate iopolicy for HPE Alletra Storage MP
> -ACTION=="add", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm",
> ATTR{model}=="HPE Alletra", ATTR{iopolicy}="round-robin"
> -
> -# Set ctrl_loss_tmo to -1 for HPE Alletra Storage MP NVMe/TCP
> -ACTION!="remove", SUBSYSTEM=="nvme", KERNEL=="nvme*",
> ATTR{transport}=="tcp", ATTR{model}=="HPE Alletra",
> ATTR{ctrl_loss_tmo}="-1"
> diff --git a/nvmf-autoconnect/udev-rules/71-nvmf-netapp.rules.in
> b/nvmf-autoconnect/udev-rules/71-nvmf-netapp.rules.in
> deleted file mode 100644
> index c76a3c434..000000000
> --- a/nvmf-autoconnect/udev-rules/71-nvmf-netapp.rules.in
> +++ /dev/null
> @@ -1,6 +0,0 @@
> -# Set appropriate iopolicy for NetApp ONTAP and NetApp E-Series
> -ACTION=="add", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm",
> ATTR{model}=="NetApp ONTAP Controller", ATTR{iopolicy}="queue-depth"
> -ACTION=="add", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm",
> ATTR{model}=="NetApp E-Series", ATTR{iopolicy}="round-robin"
> -
> -# Set ctrl_loss_tmo to -1 for NetApp ONTAP NVMe/TCP
> -ACTION!="remove", SUBSYSTEM=="nvme", KERNEL=="nvme*",
> ATTR{transport}=="tcp", ATTR{model}=="NetApp ONTAP Controller",
> ATTR{ctrl_loss_tmo}="-1"
> diff --git a/nvmf-autoconnect/udev-rules/71-nvmf-vastdata.rules.in
> b/nvmf-autoconnect/udev-rules/71-nvmf-vastdata.rules.in
> deleted file mode 100644
> index dcd6146d8..000000000
> --- a/nvmf-autoconnect/udev-rules/71-nvmf-vastdata.rules.in
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -# Enable round-robin for Vast Data Block Subsystem
> -ACTION=="add", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm",
> ATTR{model}=="VASTData", ATTR{iopolicy}="round-robin"
> -
> -# Set ctrl_loss_tmo to -1 for Vast Data Block Controller
> -ACTION!="remove", SUBSYSTEM=="nvme", KERNEL=="nvme*",
> ATTR{model}=="VASTData", ATTR{ctrl_loss_tmo}="-1"
> diff --git a/nvmf-autoconnect/udev-rules/80-nvmf-
> storage_arrays.rules.in b/nvmf-autoconnect/udev-rules/80-nvmf-
> storage_arrays.rules.in
> new file mode 100644
> index 000000000..1cd6c0c0b
> --- /dev/null
> +++ b/nvmf-autoconnect/udev-rules/80-nvmf-storage_arrays.rules.in
> @@ -0,0 +1,23 @@
> +##### Storage arrays
> +
> +#### Set iopolicy for NVMe-oF
> +### iopolicy: numa (default), round-robin (>=5.1), or queue-depth
> (>=6.11)
> +
> +## HPE
> +# Alletra 9000 / Alletra Storage MP / GreenLake Block Storage MP
> +ACTION=="add", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm",
> ATTR{model}=="HPE Alletra", ATTR{iopolicy}="round-robin"
> +ACTION!="remove", SUBSYSTEM=="nvme", KERNEL=="nvme*",
> ATTR{transport}=="tcp", ATTR{model}=="HPE Alletra",
> ATTR{ctrl_loss_tmo}="-1"
I'm not a fan of repeated lengthy match expressions in udev rules.
Can we improve the readability by using GOTOs and LABELS?
SUBSYSTEM!="nvme*", GOTO="nvmf_end"
ATTR{model}=="HPE Alletra", GOTO="Alletra"
ATTR{model}=="NetApp ONTAP Controller", GOTO="Ontap"
...
GOTO="nvmf_end"
LABEL="Alletra"
ACTION=="add", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", \
ATTR{iopolicy}="queue-depth"
ACTION!="remove", SUBSYSTEM=="nvme", KERNEL=="nvme*", \
ATTR{transport}=="tcp", ATTR{ctrl_loss_tmo}="-1"
GOTO="nvmf_end"
LABEL="Ontap"
...
LABEL="nvmf_end"
--
Dr. Martin Wilck <mwilck@suse.com>
SUSE Software Solutions Germany GmbH, Frankenstr. 146, 90461 Nürnberg,
Germany
Geschäftsführer: Stefan Gaiser, Jochen Jaser, Abhinav Puri (HRB
36809,AG Nürnberg)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme-cli: nvmf-autoconnect: Consolidate vendor-specific NVMe-oF udev rules into a single file
2026-11-09 10:09 ` Martin Wilck
@ 2026-11-09 10:28 ` Xose Vazquez Perez
0 siblings, 0 replies; 3+ messages in thread
From: Xose Vazquez Perez @ 2026-11-09 10:28 UTC (permalink / raw)
To: Martin Wilck
Cc: John Garry, Nilay Shroff, Guixin Liu, Matthias Rudolph,
Martin George, NetApp RDAC team, Zou Ming, Li Xiaokeng,
Randy Jennings, Jyoti Rani, Brian Bunker, Uday Shankar,
Chaitanya Kulkarni, Sagi Grimberg, Keith Busch, Christoph Hellwig,
Marco Patalano, Ewan D. Milne, John Meneghini, Daniel Wagner,
Daniel Wagner, Hannes Reinecke, Benjamin Marzinski,
Christophe Varoqui, BLOCK-ML, NVME-ML, SCSI-ML, DM_DEVEL-ML
On 11/9/26 11:09 AM, Martin Wilck wrote:
> On Mon, 2026-11-09 at 01:08 +0100, Xose Vazquez Perez wrote:
>> Cc: John Garry <john.garry@linux.dev>
>> Cc: Nilay Shroff <nilay@linux.ibm.com>
>> Cc: Guixin Liu <kanie@linux.alibaba.com>
>> Cc: Wayne Berthiaume <Wayne.Berthiaume@dell.com>
>> Cc: Vasuki Manikarnike <vasuki.manikarnike@hpe.com>
>> Cc: Matthias Rudolph <Matthias.Rudolph@hitachivantara.com>
>> Cc: Martin George <marting@netapp.com>
>> Cc: NetApp RDAC team <ng-eseries-upstream-maintainers@netapp.com>
>> Cc: Zou Ming <zouming.zouming@huawei.com>
>> Cc: Li Xiaokeng <lixiaokeng@huawei.com>
>> Cc: Randy Jennings <randyj@purestorage.com>
>> Cc: Jyoti Rani <jrani@purestorage.com>
>> Cc: Brian Bunker <brian@purestorage.com>
>> Cc: Uday Shankar <ushankar@purestorage.com>
>> Cc: Chaitanya Kulkarni <kch@nvidia.com>
>> Cc: Sagi Grimberg <sagi@grimberg.me>
>> Cc: Keith Busch <kbusch@kernel.org>
>> Cc: Christoph Hellwig <hch@lst.de>
>> Cc: Marco Patalano <mpatalan@redhat.com>
>> Cc: Ewan D. Milne <emilne@redhat.com>
>> Cc: John Meneghini <jmeneghi@redhat.com>
>> Cc: Daniel Wagner <dwagner@suse.de>
>> Cc: Daniel Wagner <wagi@monom.org>
>> Cc: Hannes Reinecke <hare@suse.de>
>> Cc: Martin Wilck <mwilck@suse.com>
>> Cc: Benjamin Marzinski <bmarzins@redhat.com>
>> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
>> Cc: BLOCK-ML <linux-block@vger.kernel.org>
>> Cc: NVME-ML <linux-nvme@lists.infradead.org>
>> Cc: SCSI-ML <linux-scsi@vger.kernel.org>
>> Cc: DM_DEVEL-ML <dm-devel@lists.linux.dev>
>> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> Generally a good idea, but I think nvme-cli has a GitHub based
> development workflow these days.
While GitHub is an option, web-based interfaces tend to limit patch
visibility and broad review reach across subsystems. Mailing lists
remain far more versatile for cross-project visibility and discussion.
> I'm not a fan of repeated lengthy match expressions in udev rules.
> Can we improve the readability by using GOTOs and LABELS?
Using GOTOs and LABELS cleans up the duplicated model match expressions nicely.
However, the scope of this patch is intentionally kept to a pure consolidation.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-09 10:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-09 0:08 [PATCH] nvme-cli: nvmf-autoconnect: Consolidate vendor-specific NVMe-oF udev rules into a single file Xose Vazquez Perez
2026-11-09 10:09 ` Martin Wilck
2026-11-09 10:28 ` Xose Vazquez Perez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox