Re: [PATCH 1/2] block: handle huge zero folios in bio_free_folios

[Hannes Reinecke <hare@suse.de>]

On 7/15/26 8:42 AM, Christoph Hellwig wrote:
> When CONFIG_PERSISTENT_HUGE_ZERO_FOLIO is enabled, iomap_dio_zero() can
> add a huge zero folio to a zeroing bio, which needs special treatment
> in bio_free_folios by also checking is_huge_zero_folio() in addition to
> is_zero_folio().
> 
> Fixes: 8dd5e7c75d7b ("block: add helpers to bounce buffer an iov_iter into bios")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>   block/bio.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/bio.c b/block/bio.c
> index f2a5f4d0a967..4d6e5f5f5710 100644
> --- a/block/bio.c
> +++ b/block/bio.c
> @@ -1302,7 +1302,7 @@ static void bio_free_folios(struct bio *bio)
>   	bio_for_each_bvec_all(bv, bio, i) {
>   		struct folio *folio = bvec_folio(bv);
>   
> -		if (!is_zero_folio(folio))
> +		if (!is_zero_folio(folio) && !is_huge_zero_folio(folio))
>   			folio_put(folio);
>   	}
>   }

Reviewed-by: Hannes Reinecke <hare@kernel.org>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich