From: Jens Axboe <axboe@kernel.dk>
To: Bart Van Assche <Bart.VanAssche@sandisk.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] blk-mq-sched: don't run the queue async from blk_mq_try_issue_directly()
Date: Tue, 14 Mar 2017 09:26:08 -0600 [thread overview]
Message-ID: <dccb2e2f-5576-4614-9797-d6cc2970e4d8@kernel.dk> (raw)
In-Reply-To: <1D08B61A9CF0974AA09887BE32D889DA0EC183@ULS-OP-MBXIP03.sdcorp.global.sandisk.com>
On 03/14/2017 09:17 AM, Bart Van Assche wrote:
> On 03/14/2017 07:57 AM, Jens Axboe wrote:
>> If we have scheduling enabled, we jump directly to insert-and-run.
>> That's fine, but we run the queue async and we don't pass in information
>> on whether we can block from this context or not. Fixup both these
>> cases.
>
> How about renaming "can_block" into "may_sleep"? Otherwise this patch
> looks fine to me.
Sure, either one is fine with me, at least to me they convey the same
information.
--
Jens Axboe
next prev parent reply other threads:[~2017-03-14 15:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 14:57 [PATCH] blk-mq-sched: don't run the queue async from blk_mq_try_issue_directly() Jens Axboe
2017-03-14 15:17 ` Bart Van Assche
2017-03-14 15:26 ` Jens Axboe [this message]
2017-03-14 17:48 ` Omar Sandoval
2017-03-14 17:51 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dccb2e2f-5576-4614-9797-d6cc2970e4d8@kernel.dk \
--to=axboe@kernel.dk \
--cc=Bart.VanAssche@sandisk.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox