From: Jens Axboe <axboe@kernel.dk>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: ming.lei@redhat.com, baolin.wang7@gmail.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk-mq: Remove unnecessary validation before calling blk_mq_sched_completed_request()
Date: Fri, 10 Jul 2020 08:00:14 -0600 [thread overview]
Message-ID: <eddd681b-6a80-486d-3655-e8810ba7b118@kernel.dk> (raw)
In-Reply-To: <969d0e9f637b2a0dbfb3d284abfbed6fc7665ea4.1593846855.git.baolin.wang7@gmail.com>
On 7/4/20 1:28 AM, Baolin Wang wrote:
> We've already validated the 'q->elevator' before calling ->ops.completed_request()
> in blk_mq_sched_completed_request(), thus no need to validate rq->internal_tag again,
> and remove it.
Applied, but I reformatted and edited your commit message.
--
Jens Axboe
prev parent reply other threads:[~2020-07-10 14:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-04 7:28 [PATCH] blk-mq: Remove unnecessary validation before calling blk_mq_sched_completed_request() Baolin Wang
2020-07-10 8:23 ` Baolin Wang
2020-07-10 9:47 ` Ming Lei
2020-07-10 14:00 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eddd681b-6a80-486d-3655-e8810ba7b118@kernel.dk \
--to=axboe@kernel.dk \
--cc=baolin.wang7@gmail.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox