From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Ilya Dryomov <idryomov@gmail.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Ceph Development <ceph-devel@vger.kernel.org>,
linux-block@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: blk_integrity_revalidate() clears BDI_CAP_STABLE_WRITES
Date: Thu, 23 Feb 2017 18:49:01 -0500 [thread overview]
Message-ID: <yq1fuj44geq.fsf@oracle.com> (raw)
In-Reply-To: <CAOi1vP-amFyFHbPV3FhG3F1Tp+df6V7a4mcP8LLWY0GZx+JsFw@mail.gmail.com> (Ilya Dryomov's message of "Wed, 22 Feb 2017 15:41:43 +0100")
>>>>> "Ilya" == Ilya Dryomov <idryomov@gmail.com> writes:
Ilya,
Ilya> Well, blk_integrity_revalidate() doesn't clear the profile, it
Ilya> just clears the stable pages flag. Whoever calls
Ilya> blk_integrity_unregister() to clear the profile can also clear the
Ilya> stable pages flag -- why not let blk_integrity_unregister() clear
Ilya> the flag like I suggested?
That's what it used to do.
blk_integrity_revalidate() was obviously introduced to overcome some
problem. Unfortunately, I can't recall what that was and Google isn't
being particularly helpful. I suspect it was either in the NVDIMM or
NVMe camps since that's where the churn was.
I don't have a problem with your patch as long as we're sure there are
no regressions. I would carry the gendisk check over, though.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-02-24 1:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 18:45 blk_integrity_revalidate() clears BDI_CAP_STABLE_WRITES Ilya Dryomov
2017-02-22 4:41 ` Martin K. Petersen
2017-02-22 14:41 ` Ilya Dryomov
2017-02-23 23:49 ` Martin K. Petersen [this message]
2017-02-28 8:19 ` Ilya Dryomov
2017-03-02 3:24 ` Martin K. Petersen
2017-03-10 16:49 ` Ilya Dryomov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1fuj44geq.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=ceph-devel@vger.kernel.org \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=idryomov@gmail.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox