From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Ric Wheeler <ricwheeler@gmail.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
lczerner@redhat.com
Subject: Re: Testing devices for discard support properly
Date: Wed, 08 May 2019 22:29:17 -0400 [thread overview]
Message-ID: <yq1lfzgicn6.fsf@oracle.com> (raw)
In-Reply-To: <20190508215832.GR1454@dread.disaster.area> (Dave Chinner's message of "Thu, 9 May 2019 07:58:32 +1000")
Dave,
>> > WRITE SAME also has an ANCHOR flag which provides a use case we
>> > currently don't have fallocate plumbing for: Allocating blocks without
>> > caring about their contents. I.e. the blocks described by the I/O are
>> > locked down to prevent ENOSPC for future writes.
>
> So WRITE_SAME (0) with an ANCHOR flag does not return zeroes on
> subsequent reads? i.e. it is effectively
> fallocate(FALLOC_FL_NO_HIDE_STALE) preallocation semantics?
The answer is that it depends. It can return zeroes or a device-specific
initialization pattern (oh joy).
> For many use cases cases we actually want zeroed space to be
> guaranteed so we don't expose stale data from previous device use into
> the new user's visibility - can that be done with WRITE_SAME and the
> ANCHOR flag?
That's just a regular zeroout.
We have:
Allocate and zero: FALLOC_FL_ZERO_RANGE
Deallocate and zero: FALLOC_FL_PUNCH_HOLE
Deallocate: FALLOC_FL_PUNCH_HOLE | FALLOC_FL_NO_HIDE_STALE
but are missing:
Allocate: FALLOC_FL_ZERO_RANGE | FALLOC_FL_NO_HIDE_STALE
The devices that implement anchor semantics are few and far between. I
have yet to see one.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-05-09 2:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 20:56 Testing devices for discard support properly Ric Wheeler
2019-05-07 7:10 ` Lukas Czerner
2019-05-07 8:48 ` Jan Tulak
2019-05-07 9:40 ` Lukas Czerner
2019-05-07 12:57 ` Ric Wheeler
2019-05-07 15:35 ` Bryan Gurney
2019-05-07 15:44 ` Ric Wheeler
2019-05-07 20:09 ` Bryan Gurney
2019-05-07 21:24 ` Chris Mason
2019-06-03 20:01 ` Ric Wheeler
2019-05-07 8:21 ` Nikolay Borisov
2019-05-07 22:04 ` Dave Chinner
2019-05-08 0:07 ` Ric Wheeler
2019-05-08 1:14 ` Dave Chinner
2019-05-08 15:05 ` Ric Wheeler
2019-05-08 17:03 ` Martin K. Petersen
2019-05-08 17:09 ` Ric Wheeler
2019-05-08 17:25 ` Martin K. Petersen
2019-05-08 18:12 ` Ric Wheeler
2019-05-09 16:02 ` Bryan Gurney
2019-05-09 17:27 ` Ric Wheeler
2019-05-09 20:35 ` Bryan Gurney
2019-05-08 21:58 ` Dave Chinner
2019-05-09 2:29 ` Martin K. Petersen [this message]
2019-05-09 3:20 ` Dave Chinner
2019-05-09 4:35 ` Martin K. Petersen
2019-05-08 16:16 ` Martin K. Petersen
2019-05-08 22:31 ` Dave Chinner
2019-05-09 3:55 ` Martin K. Petersen
2019-05-09 13:40 ` Ric Wheeler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1lfzgicn6.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=lczerner@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ricwheeler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox