* [PATCH] block: delete module stuff from t10-pi
@ 2024-08-12 18:10 Alexey Dobriyan
2024-08-12 19:17 ` Martin K. Petersen
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Alexey Dobriyan @ 2024-08-12 18:10 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-block
It is not possible to build t10-pi.ko anymore.
This file doesn't even export functions.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
block/t10-pi.c | 4 ----
1 file changed, 4 deletions(-)
--- a/block/t10-pi.c
+++ b/block/t10-pi.c
@@ -8,7 +8,6 @@
#include <linux/blk-integrity.h>
#include <linux/crc-t10dif.h>
#include <linux/crc64.h>
-#include <linux/module.h>
#include <net/checksum.h>
#include <asm/unaligned.h>
#include "blk.h"
@@ -472,6 +471,3 @@ void blk_integrity_complete(struct request *rq, unsigned int nr_bytes)
else
t10_pi_type1_complete(rq, nr_bytes);
}
-
-MODULE_DESCRIPTION("T10 Protection Information module");
-MODULE_LICENSE("GPL");
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] block: delete module stuff from t10-pi
2024-08-12 18:10 [PATCH] block: delete module stuff from t10-pi Alexey Dobriyan
@ 2024-08-12 19:17 ` Martin K. Petersen
2024-08-13 6:50 ` Christoph Hellwig
2024-08-13 12:20 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2024-08-12 19:17 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: Jens Axboe, linux-block
Alexey,
> It is not possible to build t10-pi.ko anymore.
>
> This file doesn't even export functions.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] block: delete module stuff from t10-pi
2024-08-12 18:10 [PATCH] block: delete module stuff from t10-pi Alexey Dobriyan
2024-08-12 19:17 ` Martin K. Petersen
@ 2024-08-13 6:50 ` Christoph Hellwig
2024-08-13 12:20 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2024-08-13 6:50 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: Jens Axboe, linux-block
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] block: delete module stuff from t10-pi
2024-08-12 18:10 [PATCH] block: delete module stuff from t10-pi Alexey Dobriyan
2024-08-12 19:17 ` Martin K. Petersen
2024-08-13 6:50 ` Christoph Hellwig
@ 2024-08-13 12:20 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2024-08-13 12:20 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: linux-block
On Mon, 12 Aug 2024 21:10:33 +0300, Alexey Dobriyan wrote:
> It is not possible to build t10-pi.ko anymore.
>
> This file doesn't even export functions.
>
>
Applied, thanks!
[1/1] block: delete module stuff from t10-pi
commit: 49923a0dff59fa6b34aa6cc16dc9eefdbbcd3846
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-08-13 12:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-12 18:10 [PATCH] block: delete module stuff from t10-pi Alexey Dobriyan
2024-08-12 19:17 ` Martin K. Petersen
2024-08-13 6:50 ` Christoph Hellwig
2024-08-13 12:20 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox