From: Gowtham Anandha Babu <gowtham.ab@samsung.com>
To: linux-bluetooth@vger.kernel.org
Subject: RE: [PATCH] gatt-server: Fix mutlpile definition of same func
Date: Fri, 13 Feb 2015 16:50:33 +0530 [thread overview]
Message-ID: <000801d0477f$1a2adde0$4e8099a0$@samsung.com> (raw)
In-Reply-To: <1423226839-23935-1-git-send-email-gowtham.ab@samsung.com>
Ping.
> -----Original Message-----
> From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-
> owner@vger.kernel.org] On Behalf Of Gowtham Anandha Babu
> Sent: Friday, February 06, 2015 6:17 PM
> To: linux-bluetooth@vger.kernel.org
> Cc: bharat.panda@samsung.com; cpgs@samsung.com; Gowtham Anandha
> Babu
> Subject: [PATCH] gatt-server: Fix mutlpile definition of same func
>
> Removed 'put_uuid_le' func from gatt-server, which was already defined in
> gatt-helpers.
> ---
> src/shared/gatt-helpers.c | 2 +-
> src/shared/gatt-helpers.h | 2 ++
> src/shared/gatt-server.c | 21 ---------------------
> 3 files changed, 3 insertions(+), 22 deletions(-)
>
> diff --git a/src/shared/gatt-helpers.c b/src/shared/gatt-helpers.c index
> a33f960..6dfc24f 100644
> --- a/src/shared/gatt-helpers.c
> +++ b/src/shared/gatt-helpers.c
> @@ -567,7 +567,7 @@ bool bt_gatt_exchange_mtu(struct bt_att *att,
> uint16_t client_rx_mtu,
> return true;
> }
>
> -static void put_uuid_le(const bt_uuid_t *src, void *dst)
> +void put_uuid_le(const bt_uuid_t *src, void *dst)
> {
> bt_uuid_t uuid;
>
> diff --git a/src/shared/gatt-helpers.h b/src/shared/gatt-helpers.h index
> 0217e82..7a2076b 100644
> --- a/src/shared/gatt-helpers.h
> +++ b/src/shared/gatt-helpers.h
> @@ -105,3 +105,5 @@ bool bt_gatt_read_by_type(struct bt_att *att,
> uint16_t start, uint16_t end,
> bt_gatt_discovery_callback_t
> callback,
> void *user_data,
> bt_gatt_destroy_func_t destroy);
> +
> +void put_uuid_le(const bt_uuid_t *src, void *dst);
> diff --git a/src/shared/gatt-server.c b/src/shared/gatt-server.c index
> 8f7b5cd..0652d3d 100644
> --- a/src/shared/gatt-server.c
> +++ b/src/shared/gatt-server.c
> @@ -499,27 +499,6 @@ error:
> queue_destroy(q, NULL);
> }
>
> -static void put_uuid_le(const bt_uuid_t *src, void *dst) -{
> - bt_uuid_t uuid;
> -
> - switch (src->type) {
> - case BT_UUID16:
> - put_le16(src->value.u16, dst);
> - break;
> - case BT_UUID128:
> - bswap_128(&src->value.u128, dst);
> - break;
> - case BT_UUID32:
> - bt_uuid_to_uuid128(src, &uuid);
> - bswap_128(&uuid.value.u128, dst);
> - break;
> - case BT_UUID_UNSPEC:
> - default:
> - break;
> - }
> -}
> -
> static bool encode_find_info_rsp(struct gatt_db *db, struct queue *q,
> uint16_t mtu,
> uint8_t *pdu, uint16_t *len)
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth"
in
> the body of a message to majordomo@vger.kernel.org More majordomo
> info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-02-13 11:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 12:47 [PATCH] gatt-server: Fix mutlpile definition of same func Gowtham Anandha Babu
2015-02-13 11:20 ` Gowtham Anandha Babu [this message]
2015-02-13 12:53 ` Luiz Augusto von Dentz
2015-02-13 11:33 ` Johan Hedberg
2015-02-13 13:49 ` Luiz Augusto von Dentz
2015-02-13 14:25 ` Gowtham Anandha Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000801d0477f$1a2adde0$4e8099a0$@samsung.com' \
--to=gowtham.ab@samsung.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox