From: Johan Hedberg <johan.hedberg@gmail.com>
To: Gowtham Anandha Babu <gowtham.ab@samsung.com>
Cc: linux-bluetooth@vger.kernel.org, bharat.panda@samsung.com,
cpgs@samsung.com
Subject: Re: [PATCH] gatt-server: Fix mutlpile definition of same func
Date: Fri, 13 Feb 2015 13:33:47 +0200 [thread overview]
Message-ID: <20150213113347.GA11794@t440s.ger.corp.intel.com> (raw)
In-Reply-To: <1423226839-23935-1-git-send-email-gowtham.ab@samsung.com>
Hi,
On Fri, Feb 06, 2015, Gowtham Anandha Babu wrote:
> --- a/src/shared/gatt-helpers.h
> +++ b/src/shared/gatt-helpers.h
> @@ -105,3 +105,5 @@ bool bt_gatt_read_by_type(struct bt_att *att, uint16_t start, uint16_t end,
> bt_gatt_discovery_callback_t callback,
> void *user_data,
> bt_gatt_destroy_func_t destroy);
> +
> +void put_uuid_le(const bt_uuid_t *src, void *dst);
gatt-helpers.h uses a namespace prefix of "bt_gatt" so you should at the
very least conform to that. The function name would then become e.g.
bt_gatt_put_uuid(). Besides that I don't have any objections to the
patch.
Johan
next prev parent reply other threads:[~2015-02-13 11:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 12:47 [PATCH] gatt-server: Fix mutlpile definition of same func Gowtham Anandha Babu
2015-02-13 11:20 ` Gowtham Anandha Babu
2015-02-13 12:53 ` Luiz Augusto von Dentz
2015-02-13 11:33 ` Johan Hedberg [this message]
2015-02-13 13:49 ` Luiz Augusto von Dentz
2015-02-13 14:25 ` Gowtham Anandha Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150213113347.GA11794@t440s.ger.corp.intel.com \
--to=johan.hedberg@gmail.com \
--cc=bharat.panda@samsung.com \
--cc=cpgs@samsung.com \
--cc=gowtham.ab@samsung.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox