From: Marcel Holtmann <marcel@holtmann.org>
To: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: hci_nokia: select BT_BCM for btbcm_set_bdaddr()
Date: Sun, 23 Jul 2017 09:40:20 +0200 [thread overview]
Message-ID: <0EEC0D61-D68F-4EDD-86C6-7447676AC232@holtmann.org> (raw)
In-Reply-To: <20170722211658.fdfcwoqshtrxqvwj@earth>
Hi Sebastian,
>>>> The Nokia devices require the setup of its Public Bluetooth Device
>>>> Address and for that it is required to depend on vendor specific
>>>> commands. For Broadcom based Nokia devices, that is part of btbcm
>>>> module and can be selected via BT_BCM config option.
>>>>
>>>> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
>>>
>>> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
>>
>> btw. we need to also provide the set_bdaddr for TI chips.
>
> The TI based chip in Nokia N950 has a proper address configured, so
> it works without set_bdaddr (it would still be nice of course). It
> also seems to be missing for hci_ll, though. So the required command
> is completly unknown?
actually a bunch of the TI HCI vendor command documents are public. We just need to figure out which one does the job. For the WiLink it is HCI_VS_Write_BD_Addr (0xFC06) which just takes the BD_ADDR as parameter.
Regards
Marcel
next prev parent reply other threads:[~2017-07-23 7:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-22 9:57 [PATCH] Bluetooth: hci_nokia: select BT_BCM for btbcm_set_bdaddr() Marcel Holtmann
2017-07-22 19:03 ` Sebastian Reichel
2017-07-22 19:08 ` Marcel Holtmann
2017-07-22 21:16 ` Sebastian Reichel
2017-07-23 7:32 ` Marcel Holtmann
2017-07-24 10:23 ` Sebastian Reichel
2017-07-24 15:27 ` Sebastian Reichel
2017-07-24 17:10 ` Marcel Holtmann
2017-07-24 17:09 ` Marcel Holtmann
2017-07-24 18:48 ` Sebastian Reichel
2017-07-23 7:40 ` Marcel Holtmann [this message]
2017-07-24 18:58 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0EEC0D61-D68F-4EDD-86C6-7447676AC232@holtmann.org \
--to=marcel@holtmann.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox