From: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: hci_nokia: select BT_BCM for btbcm_set_bdaddr()
Date: Sat, 22 Jul 2017 23:16:59 +0200 [thread overview]
Message-ID: <20170722211658.fdfcwoqshtrxqvwj@earth> (raw)
In-Reply-To: <DC17CA45-3AB5-4272-A12A-1C7BD4811258@holtmann.org>
[-- Attachment #1: Type: text/plain, Size: 805 bytes --]
Hi,
On Sat, Jul 22, 2017 at 09:08:15PM +0200, Marcel Holtmann wrote:
> >> The Nokia devices require the setup of its Public Bluetooth Device
> >> Address and for that it is required to depend on vendor specific
> >> commands. For Broadcom based Nokia devices, that is part of btbcm
> >> module and can be selected via BT_BCM config option.
> >>
> >> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> >
> > Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
>
> btw. we need to also provide the set_bdaddr for TI chips.
The TI based chip in Nokia N950 has a proper address configured, so
it works without set_bdaddr (it would still be nice of course). It
also seems to be missing for hci_ll, though. So the required command
is completly unknown?
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-07-22 21:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-22 9:57 [PATCH] Bluetooth: hci_nokia: select BT_BCM for btbcm_set_bdaddr() Marcel Holtmann
2017-07-22 19:03 ` Sebastian Reichel
2017-07-22 19:08 ` Marcel Holtmann
2017-07-22 21:16 ` Sebastian Reichel [this message]
2017-07-23 7:32 ` Marcel Holtmann
2017-07-24 10:23 ` Sebastian Reichel
2017-07-24 15:27 ` Sebastian Reichel
2017-07-24 17:10 ` Marcel Holtmann
2017-07-24 17:09 ` Marcel Holtmann
2017-07-24 18:48 ` Sebastian Reichel
2017-07-23 7:40 ` Marcel Holtmann
2017-07-24 18:58 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170722211658.fdfcwoqshtrxqvwj@earth \
--to=sebastian.reichel@collabora.co.uk \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox