[Bluez-users] patched script

[Bluez-users] patched script

[Michal Semler (volny.cz)]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

Hi Marcel,

sending patched script bluetooth for debian

1]added bthid daemon to start/stop sections
2]fixes variables to prevent atacker pass some extended values into them

Hope you`ll include it

Michal

[-- Attachment #2: bluetooth.rc.deb.new --]
[-- Type: text/x-diff, Size: 2314 bytes --]

--- /usr/src/bluez-utils-2.6/scripts/bluetooth.rc.deb	Fri Apr  2 03:21:04 2004
+++ bluetooth	Wed Apr 14 23:56:17 2004
@@ -11,6 +11,7 @@
 HCIATTACH=/usr/sbin/hciattach
 UART_CONF=/etc/bluetooth/uart
 SDPD=/usr/sbin/sdpd
+BTHID=/opt/bluetooth/sbin/bthid
 RFCOMM=/usr/bin/rfcomm
 RFCOMM_CONF=/etc/bluetooth/rfcomm.conf
 
@@ -18,30 +19,35 @@
 
 start_uarts() 
 {
-	[ -x $HCIATTACH -a -f $UART_CONF ] || return
-	grep -v '^#' $UART_CONF | while read i; do
-		$HCIATTACH $i
+	[ -x "$HCIATTACH" -a -f "$UART_CONF" ] || return
+	grep -v '^#' "$UART_CONF" | while read i; do
+		"$HCIATTACH" "$i"
 	done
 }
 
 stop_uarts()
 {
-	killall $HCIATTACH > /dev/null 2>&1 || true
+	killall "$HCIATTACH" > /dev/null 2>&1 || true
 }
 
 case "$1" in
   start)
 	echo -n "Starting $DESC:"
-	if [ -x $HCID -a -f $HCID_CONF ] ; then
-		$HCID -f $HCID_CONF
+	if [ -x "$HCID" -a -f "$HCID_CONF" ] ; then
+		"$HCID" -f "$HCID_CONF"
 		echo -n " hcid"
 	fi
-	if [ -x $SDPD ] ; then
-		$SDPD
+	if [ -x "$SDPD" ] ; then
+		"$SDPD"
 		echo -n " sdpd"
 	fi
-	if [ -x $RFCOMM -a -f $RFCOMM_CONF ] ; then
-		$RFCOMM -f $RFCOMM_CONF bind all
+        if [ -x "$BTHID" ] ; then
+		"$BTHID" -d
+		echo -n " bthid"
+	fi
+
+	if [ -x "$RFCOMM" -a -f "$RFCOMM_CONF" ] ; then
+		"$RFCOMM" -f "$RFCOMM_CONF" bind all
 		echo -n " rfcomm"
 	fi
 	echo "."
@@ -49,30 +55,32 @@
 	;;
   stop)
 	echo -n "Stopping $DESC:"
-	if [ -x $RFCOMM ] ; then
+	if [ -x "$RFCOMM" ] ; then
 		echo -n " rfcomm"
-		$RFCOMM release all
+		"$RFCOMM" release all
 	fi
 	echo -n " sdpd"
-	killall $SDPD > /dev/null 2>&1 || true
+	killall "$SDPD" > /dev/null 2>&1 || true
 	echo -n " hcid"
-	killall $HCID > /dev/null 2>&1 || true
+	killall "$HCID" > /dev/null 2>&1 || true
+	echo -n " bthid"
+	killall "$BTHID" > /dev/null 2>&1 || true
 	echo "."
 	stop_uarts
 	;;
   restart|force-reload)
 	echo -n "Restarting $DESC:"
 	echo -n " hcid"
-	killall $HCID > /dev/null 2>&1 || true
+	killall "$HCID" > /dev/null 2>&1 || true
 	sleep 1
-	if [ -x $HCID -a -f $HCID_CONF ] ; then
-		$HCID -f $HCID_CONF
+	if [ -x "$HCID" -a -f "$HCID_CONF" ] ; then
+		"$HCID" -f "$HCID_CONF"
 	fi
 	echo -n " sdpd"
-	killall $SDPD > /dev/null 2>&1 || true
+	killall "$SDPD" > /dev/null 2>&1 || true
 	sleep 1
-	if [ -x $SDPD ] ; then
-		$SDPD
+	if [ -x "$SDPD" ] ; then
+		"$SDPD"
 	fi
 	echo "."
 	;;

Re: [Bluez-users] patched script

[Marcel Holtmann]

Hi Michal,

> sending patched script bluetooth for debian
> 
> 1]added bthid daemon to start/stop sections
> 2]fixes variables to prevent atacker pass some extended values into them
> 
> Hope you`ll include it

nice script, but I don't include it. However I am going to include dund
and pand into the utils package and I also wanna put a version of the
bthid into it that uses the old SDP library.

Right now there are three Debian init script from bluez-utils, bluez-sdp
and bluez-pan package. If you wanna do me a favour, write a complete new
one with the same features and the settings in /etc/default/bluetooth
and I am going to include that one.

And please use "hidd" as name for the HID daemon, because I am going to
use that name to keep the namespace a little bit cleaner.

Regards

Marcel




-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
Bluez-users mailing list
Bluez-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-users

Re: [Bluez-users] patched script

[Michal Semler (volny.cz)]

Hi Marcel,

I rewrited script to use /etc/default/bluetooth, but can't find existing 
scripts for pand, dund? sdpd is in script included.

Send me that ones and I'll include them. Problem is, that I don't use pand and 
dund so I don't know how they should work

Thanks

Michal

Dne so 17. dubna 2004 02:01 jste napsal(a):
> Hi Michal,
>
> > sending patched script bluetooth for debian
> >
> > 1]added bthid daemon to start/stop sections
> > 2]fixes variables to prevent atacker pass some extended values into them
> >
> > Hope you`ll include it
>
> nice script, but I don't include it. However I am going to include dund
> and pand into the utils package and I also wanna put a version of the
> bthid into it that uses the old SDP library.
>
> Right now there are three Debian init script from bluez-utils, bluez-sdp
> and bluez-pan package. If you wanna do me a favour, write a complete new
> one with the same features and the settings in /etc/default/bluetooth
> and I am going to include that one.
>
> And please use "hidd" as name for the HID daemon, because I am going to
> use that name to keep the namespace a little bit cleaner.
>
> Regards
>
> Marcel


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
Bluez-users mailing list
Bluez-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-users