From: "Gregory M. Turner" <gmt@be-evil.net>
To: linux-bluetooth@vger.kernel.org, Marcel Holtmann <marcel@holtmann.org>
Subject: Re: [PATCH] bluetooth/l2cap: silence framedrop kmsg noise
Date: Mon, 23 Feb 2015 16:31:54 -0800 [thread overview]
Message-ID: <10888960.rEuGP2Y2Ro@moneypit> (raw)
In-Reply-To: <99FAFB7A-43DF-47DF-B6B1-D62311227073@holtmann.org>
On Monday 23 February 2015 13:18:39 Marcel Holtmann wrote:
> So I am fine adding a patch that rate limits it.
While I'm at it, I'd might as well go whole-hog and implement
BT_*_RATELIMITED, no? Since, obviously, 50 lines of elegant 90% untested code
is way better than two lines of ugly 100% tested code* :)
To that end, I notice bt_{err,info} are exports in lib.c, while the rest are
macros. I'm trying to determine how tragic and/or useful it would be if those
symbols proliferated into bt_{err,info}{,_ratelimited}.
"git blame" suggests they are object-file-size optimizations and therefore,
there is probably no good reason not to just make them macros -- since there
will only be the single consumer.
Any objections out there?
-
* Just kidding, sort of -- I'd at least make sure they work, by means of some
ugly offline experiment.
-gmt
prev parent reply other threads:[~2015-02-24 0:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-22 20:36 [PATCH] bluetooth/l2cap: silence framedrop kmsg noise Gregory M. Turner
2015-02-22 20:53 ` Marcel Holtmann
2015-02-22 22:04 ` Greg Turner
2015-02-23 0:05 ` Marcel Holtmann
2015-02-23 21:09 ` Gregory M. Turner
2015-02-23 21:18 ` Marcel Holtmann
2015-02-23 22:49 ` Gregory M. Turner
2015-02-23 23:00 ` Gregory M. Turner
2015-02-24 0:31 ` Gregory M. Turner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10888960.rEuGP2Y2Ro@moneypit \
--to=gmt@be-evil.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox