From: "Gregory M. Turner" <gmt@be-evil.net>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH] bluetooth/l2cap: silence framedrop kmsg noise
Date: Sun, 22 Feb 2015 12:36:41 -0800 [thread overview]
Message-ID: <1832240.mNuY6LIF5L@moneypit> (raw)
>From b222223a4410587ea21b20841581f22614432b77 Mon Sep 17 00:00:00 2001
From: "Gregory M. Turner" <gmt@be-evil.net>
Date: Sun, 22 Feb 2015 10:54:06 -0800
Subject: [PATCH] bluetooth/l2cap: silence framedrop kmsg noise
For years, my logs have often looked like this:
# dmesg | wc -lc ; \
dmesg | grep -v \
'Bluetooth: Unexpected continuation frame (len 0)' \
| wc -lc
32769 2096857
85 5081
Google suggests I'm not alone in this. AFAICT, it means:
"Hey, kernel, here. I was trying to talk to some gizmo by way
of your tiny $2.50 USB dongle broadcasting a 2.4Ghz near-field
RF protocol. Inexplicably, there was some sort of RFI or
dropout! I'm deeply offended, and taking it personally. I'll
remind you again a few microseconds if the problem continues."
Surely this is causing more harm than benefit; silence the kmsg
unless the frame is nonempty.
Signed-off-by: Gregory M. Turner <gmt@be-evil.net>
---
net/bluetooth/l2cap_core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index 6ba33f9..dcec242 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -7493,7 +7493,8 @@ int l2cap_recv_acldata(struct hci_conn *hcon, struct sk_buff *skb, u16 flags)
BT_DBG("Cont: frag len %d (expecting %d)", skb->len, conn->rx_len);
if (!conn->rx_len) {
- BT_ERR("Unexpected continuation frame (len %d)", skb->len);
+ if (skb->len)
+ BT_ERR("Unexpected continuation frame (len %d)", skb->len);
l2cap_conn_unreliable(conn, ECOMM);
goto drop;
}
--
2.3.0
next reply other threads:[~2015-02-22 20:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-22 20:36 Gregory M. Turner [this message]
2015-02-22 20:53 ` [PATCH] bluetooth/l2cap: silence framedrop kmsg noise Marcel Holtmann
2015-02-22 22:04 ` Greg Turner
2015-02-23 0:05 ` Marcel Holtmann
2015-02-23 21:09 ` Gregory M. Turner
2015-02-23 21:18 ` Marcel Holtmann
2015-02-23 22:49 ` Gregory M. Turner
2015-02-23 23:00 ` Gregory M. Turner
2015-02-24 0:31 ` Gregory M. Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1832240.mNuY6LIF5L@moneypit \
--to=gmt@be-evil.net \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox