public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Bhatt Abhi-ABHATT <ABHISHEK.BHATT@motorola.com>
Cc: BlueZ Mailing List <bluez-devel@lists.sourceforge.net>
Subject: Re: [Bluez-devel] Possible bug in hci_core.h ?
Date: Mon, 01 Nov 2004 16:15:42 +0100	[thread overview]
Message-ID: <1099322142.16247.107.camel@pegasus> (raw)
In-Reply-To: <5987A7CB1694D811A04D0002B32C289601BF3C16@il93exb05.corp.mot.com>

Hi Abhi,

> Version: Kernel 2.6.9 with bluez patch 2.6.9-mh3
> 
> File: hci_core.h
> 
> Line: 234
> 
>  
> 
> Shouldn't line 234 be h->acl_num--;
> 
>  
> 
> 229: static inline void hci_conn_hash_del(struct hci_dev *hdev, struct
> hci_conn *c)
> 
> 230: {
> 
> 231:          struct hci_conn_hash *h = &hdev->conn_hash;
> 
> 232:          list_del(&c->list);
> 
> 233:          if (c->type == ACL_LINK)
> 
> 234:                  h->acl_num++;
> 
> 235:          else
> 
> 236:                  h->sco_num--;
> 
> 237: }

you are right. Looks like a stupid copy and paste bug. I will fix it and
send it to mainline.

Regards

Marcel




-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

      reply	other threads:[~2004-11-01 15:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-01 14:28 [Bluez-devel] Possible bug in hci_core.h ? Bhatt Abhi-ABHATT
2004-11-01 15:15 ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1099322142.16247.107.camel@pegasus \
    --to=marcel@holtmann.org \
    --cc=ABHISHEK.BHATT@motorola.com \
    --cc=bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox