[Bluez-devel] Possible bug in hci_core.h ?

[Bluez-devel] Possible bug in hci_core.h ?

[Bhatt Abhi-ABHATT]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

 

Version: Kernel 2.6.9 with bluez patch 2.6.9-mh3

File: hci_core.h

Line: 234

 

Shouldn't line 234 be h->acl_num--; 

 

229: static inline void hci_conn_hash_del(struct hci_dev *hdev, struct hci_conn *c)

230: {

231:          struct hci_conn_hash *h = &hdev->conn_hash;

232:          list_del(&c->list);

233:          if (c->type == ACL_LINK)

234:                  h->acl_num++;

235:          else

236:                  h->sco_num--;

237: }

 

Regards

Abhi


[-- Attachment #2: Type: text/html, Size: 4242 bytes --]

Re: [Bluez-devel] Possible bug in hci_core.h ?

[Marcel Holtmann]

Hi Abhi,

> Version: Kernel 2.6.9 with bluez patch 2.6.9-mh3
> 
> File: hci_core.h
> 
> Line: 234
> 
>  
> 
> Shouldn't line 234 be h->acl_num--;
> 
>  
> 
> 229: static inline void hci_conn_hash_del(struct hci_dev *hdev, struct
> hci_conn *c)
> 
> 230: {
> 
> 231:          struct hci_conn_hash *h = &hdev->conn_hash;
> 
> 232:          list_del(&c->list);
> 
> 233:          if (c->type == ACL_LINK)
> 
> 234:                  h->acl_num++;
> 
> 235:          else
> 
> 236:                  h->sco_num--;
> 
> 237: }

you are right. Looks like a stupid copy and paste bug. I will fix it and
send it to mainline.

Regards

Marcel




-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel