Re: [Bluez-users] Re: PROBLEM: Apple powerbook, Apple BT keyboard, keyboard does not reconnect on reboot

[Marcel Holtmann <marcel@holtmann.org>]

Hi Matthew,

> Real reason for it is this, user-space thinks cnum field is 16 bit, kernel 
> thinks it is 32 bit.  Bug only shows up in big-endian architectures as result
> count is returned in top byte of what is received from the kernel, whereas on
> i386 it is in the lowest where by fluke it works...
> 
> Mismatch in the kernel and user-space  header files:
> 
> in the kernel, net/bluetooth/hid/hdip.h: 
> 
> struct hidp_connlist_req {
>         __u32  cnum;
>         struct hidp_conninfo __user *ci;
> };
> 
> in libbluetoth, include/bluetooth/hidp.h:
> 
> struct hidp_connlist_req {
>         uint16_t cnum;
>         struct hidp_conninfo *ci;
> };
> 
> Which way should we go here?  We need to fix kernel or user-space, and I need your 
> 'official' touch before I post a patch in the Debian bug report I am going to submit.
> The fix I prefer affects the user-space bluetooth include files.

thanks for finding this mismatch. We change the userspace, because the
kernel interface should stay stable. Actually I looked also at BNEP and
CMTP and found that we have the same problem in CMTP. So I must have
done this wrong in the early days of CMTP and then copied over to HIDP.
A patch for this is in the CVS now.

Regards

Marcel




-------------------------------------------------------
This SF.Net email is sponsored by: InterSystems CACHE
FREE OODBMS DOWNLOAD - A multidimensional database that combines
robust object and relational technologies, making it a perfect match
for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
_______________________________________________
Bluez-users mailing list
Bluez-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-users/listinfo/bluez-users