[Bluez-devel] marshalling SDP_URL_STR

[Bluez-devel] marshalling SDP_URL_STR

[Stephen Crane]

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

Hello again,
It looks as if these types aren't being marshalled properly in the SDP
library. (They should be treated identically to SDP_TEXT_STR.)

The current code causes 1 byte too many to be allocated to them in the
marshalled form which results in garbage when it is read out of the
buffer.

The attached patch treats them the same as SDP_TEXT_STR, aside from the
DTD of course.

Cheers,
Steve

[-- Attachment #2: sdp.c.patch --]
[-- Type: text/plain, Size: 716 bytes --]

Index: sdp.c
===================================================================
RCS file: /cvsroot/bluez/libs/src/sdp.c,v
retrieving revision 1.70
diff -u -r1.70 sdp.c
--- sdp.c	9 Nov 2006 21:25:30 -0000	1.70
+++ sdp.c	23 Jan 2007 15:38:33 -0000
@@ -741,15 +741,11 @@
 	case SDP_TEXT_STR8:
 	case SDP_TEXT_STR16:
 	case SDP_TEXT_STR32:
-		src = (unsigned char *)d->val.str;
-		data_size = d->unitSize - sizeof(uint8_t);
-		sdp_set_seq_len(seqp, data_size);
-		break;
 	case SDP_URL_STR8:
 	case SDP_URL_STR16:
 	case SDP_URL_STR32:
 		src = (unsigned char *)d->val.str;
-		data_size = strlen(d->val.str);
+		data_size = d->unitSize - sizeof(uint8_t);
 		sdp_set_seq_len(seqp, data_size);
 		break;
 	case SDP_SEQ8:

[-- Attachment #3: Type: text/plain, Size: 347 bytes --]

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

[-- Attachment #4: Type: text/plain, Size: 164 bytes --]

_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] marshalling SDP_URL_STR

[Marcel Holtmann]

Hi Steve,

> It looks as if these types aren't being marshalled properly in the SDP
> library. (They should be treated identically to SDP_TEXT_STR.)
> 
> The current code causes 1 byte too many to be allocated to them in the
> marshalled form which results in garbage when it is read out of the
> buffer.
> 
> The attached patch treats them the same as SDP_TEXT_STR, aside from the
> DTD of course.

are you sure that this doesn't break anything?

Regards

Marcel



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel