Re: [Bluez-devel] pan profile sdp record

[Marcel Holtmann <marcel@holtmann.org>]

Hi Frederic,

> >> There are several issues to the problem :
> >> - patching pand is easy but some more options are needed to customize 
> >> fields (unless good defaults exists)
> >>     
> >
> > we need good default values and some extra parameters to change them. I
> > am all for this way.
> >   
> 
> What about this patch then?

looks good, but ...

Why do we need add_lang_attr(). This is actually not mandatory as far as I remember.

Do we have to make name and description configurable. Do you need it?

The security_desc should be automatically determined from the actually -E, -A or -S parameters.

The network access type and rate make sense to me. However I prefer if we simply hand them over via parameters instead of creating another struct.

> I still have a modified rfcomm man page, so I put it together...

Please separate patches.

> Also, Olivier from access once submitted a dev-down patch. As the patch 
> has not been adopted I was wondering if something could be mde better or 
> if it was just missed ?

I was actually sure that I didn't miss any patches, but that can
happens. Simply re-send it.

Regards

Marcel



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel