Re: [Bluez-devel] pan profile sdp record

["Frédéric DALLEAU" <frederic.dalleau@access-company.com>]

>>>> There are several issues to the problem :
>>>> - patching pand is easy but some more options are needed to customize 
>>>> fields (unless good defaults exists)
>>>>     
>>>>         
>>> we need good default values and some extra parameters to change them. I
>>> am all for this way.
>>>   
>>>       
>> What about this patch then?
>>     
>
> looks good, but ...
>
> Why do we need add_lang_attr(). This is actually not mandatory as far as I remember.
>
> Do we have to make name and description configurable. Do you need it?
>
> The security_desc should be automatically determined from the actually -E, -A or -S parameters.
>
> The network access type and rate make sense to me. However I prefer if we simply hand them over via parameters instead of creating another struct.
>
>   
lang, name, description are all mandatory attributes. I'm not sure if 
their actually must have a language in the list.
I have no specific requirement according to their values yet.
Using a struct allows to make name and desc configurable without adding 
new parameters and forwarding from function to function.

So two choices remains :
- keeping only the sdp.c part is enough to conform the spec.
- Doing everything and making all values configurable is quick (but the 
option letters will be strange ;) ).



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel