Re: [Bluez-devel] Another bluez-gnome patch

[Bastien Nocera <hadess@hadess.net>]

On Sat, 2007-02-24 at 16:43 +0100, Marcel Holtmann wrote:
> Hi Bastien,
> 
> > Here's an updated patch for the bluez-gnome applet and properties:
> > - Use HAL to determine the device class, if HAL is available
> 
> I added this part to the CVS now. However we need another GConf setting
> that allows the user to control if HAL should be used or not.
> 
> The properties dialog needs a setting to control the HAL usage and show
> or hide the class of device box according to it.

That sounds like over-engineering to me. What is the use case of the
applet? If it's only going to be used on desktops, what's the matter
with leaving the HAL support on? If the applet is to be used in embedded
systems, surely those systems would make mofidications to the applet to
fit their usage, and could turn off HAL support.

> > - Fix translation of scanning mode changes (modes weren't translated at
> > all, and the string used could only be used in English)
> 
> Fixed that and did a little rewording.

Cool.

> > - Don't show the notification bubble when switching the bluetooth device
> > on/off, and we're only showing the icon if a device is present. The icon
> > appearing/disappearing should be enough
> 
> We need to show when it goes back into connectable mode, because that
> happens if you use the discoverable timeout.

Then we should save the mode before the change of mode_changed signal,
and only popup the notification if the previous mode was discoverable.

> > - Fix excessive markup in the properties labels
> 
> Done a little bit different, but with the same result.

OK.

> > Once you've accepted this patch, my next step is to implement the
> > software enable/disable for laptops in the applet (that would use HAL as
> > well).
> 
> I really like to see that. We need that feature.

Cool, I'll get onto that in the near future, hopefully.

-- 
Bastien Nocera <hadess@hadess.net> 


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel