Re: [Bluez-devel] Another bluez-gnome patch

[Bastien Nocera <hadess@hadess.net>]

Hey Marcel,

On Sat, 2007-02-24 at 18:25 +0100, Marcel Holtmann wrote:
> Hi Bastien,
> 
> > > > Here's an updated patch for the bluez-gnome applet and properties:
> > > > - Use HAL to determine the device class, if HAL is available
> > > 
> > > I added this part to the CVS now. However we need another GConf setting
> > > that allows the user to control if HAL should be used or not.
> > > 
> > > The properties dialog needs a setting to control the HAL usage and show
> > > or hide the class of device box according to it.
> > 
> > That sounds like over-engineering to me. What is the use case of the
> > applet? If it's only going to be used on desktops, what's the matter
> > with leaving the HAL support on? If the applet is to be used in embedded
> > systems, surely those systems would make mofidications to the applet to
> > fit their usage, and could turn off HAL support.
> 
> it is not over-engineered for people that don't have the HAL formfactor
> setting to be used as base for the Bluetooth class of device. It also
> makes the properties application simpler since it doesn't have to check
> for HAL at all. It simply only sets a GConf value and applet acts
> depending on this value.

I still don't understand why you would want to give the user the choice
of using HAL or not. If it's there, use it! The information is always
available (it's given out by the BIOS/firmware), and if it's not
accurate, it can be overridden using an .fdi file.

What does the user gain from being able to enable/disable HAL support
themselves?

> > > > - Don't show the notification bubble when switching the bluetooth device
> > > > on/off, and we're only showing the icon if a device is present. The icon
> > > > appearing/disappearing should be enough
> > > 
> > > We need to show when it goes back into connectable mode, because that
> > > happens if you use the discoverable timeout.
> > 
> > Then we should save the mode before the change of mode_changed signal,
> > and only popup the notification if the previous mode was discoverable.
> 
> Good idea. Was actually to lazy to do it by myself. Then we can also
> change the wording to discoverable/non-discoverable.

I'll try and fix that then.

Cheers

-- 
Bastien Nocera <hadess@hadess.net> 


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel