From: Bastien Nocera <hadess@hadess.net>
To: BlueZ development <bluez-devel@lists.sourceforge.net>
Subject: Re: [Bluez-devel] non-ASCII chars in device names
Date: Wed, 07 Mar 2007 13:05:08 +0000 [thread overview]
Message-ID: <1173272708.10237.81.camel@cookie.hadess.net> (raw)
In-Reply-To: <1173267255.28512.3.camel@aeonflux.holtmann.net>
On Wed, 2007-03-07 at 12:34 +0100, Marcel Holtmann wrote:
> Hi Bastien,
>
> > I got this report for gnome-bluetooth some time ago:
> > http://bugzilla.gnome.org/show_bug.cgi?id=380408
> >
> > I fixed the problem altogether by replacing this code by D-Bus code
> > calling hcid. The problem is that the name of the device only shows up
> > the very first time the device is discovered, and it seems to me that
> > the cache is busted:
> >
> > In hcid/storage.c:
> > for (i = 0; i < 248 && name[i]; i++)
> > if ((unsigned char) name[i] < 32 || name[i] == 127)
> > str[i] = '.';
> > else
> > str[i] = name[i];
> >
> > Why? If the data is correct UTF-8, it could be saved as-is in the file,
> > minus any tabs, unbreakable spaces, or line feeds.
>
> I don't see any problem with this code. It only replaces all ASCII
> control characters (including delete). So this must be an issue with
> still having the old name in the cache.
It wasn't the old cache (as I delete it, to be sure) but an old
bluez-utils (3.7) that had this problem. Works fine with 3.9.
Cheers
--
Bastien Nocera <hadess@hadess.net>
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel
next prev parent reply other threads:[~2007-03-07 13:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 0:27 [Bluez-devel] non-ASCII chars in device names Bastien Nocera
2007-03-07 11:34 ` Marcel Holtmann
2007-03-07 13:05 ` Bastien Nocera [this message]
2007-03-07 3:31 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1173272708.10237.81.camel@cookie.hadess.net \
--to=hadess@hadess.net \
--cc=bluez-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).