[Bluez-devel] non-ASCII chars in device names

[Bluez-devel] non-ASCII chars in device names

[Bastien Nocera]

Heya,

I got this report for gnome-bluetooth some time ago:
http://bugzilla.gnome.org/show_bug.cgi?id=380408

I fixed the problem altogether by replacing this code by D-Bus code
calling hcid. The problem is that the name of the device only shows up
the very first time the device is discovered, and it seems to me that
the cache is busted:

In hcid/storage.c:
        for (i = 0; i < 248 && name[i]; i++)
                if ((unsigned char) name[i] < 32 || name[i] == 127)
                        str[i] = '.';
                else
                        str[i] = name[i];

Why? If the data is correct UTF-8, it could be saved as-is in the file,
minus any tabs, unbreakable spaces, or line feeds.

-- 
Bastien Nocera <hadess@hadess.net> 


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] non-ASCII chars in device names

[Marcel Holtmann]

Hi Bastien,

> I got this report for gnome-bluetooth some time ago:
> http://bugzilla.gnome.org/show_bug.cgi?id=380408
> 
> I fixed the problem altogether by replacing this code by D-Bus code
> calling hcid. The problem is that the name of the device only shows up
> the very first time the device is discovered, and it seems to me that
> the cache is busted:
> 
> In hcid/storage.c:
>         for (i = 0; i < 248 && name[i]; i++)
>                 if ((unsigned char) name[i] < 32 || name[i] == 127)
>                         str[i] = '.';
>                 else
>                         str[i] = name[i];
> 
> Why? If the data is correct UTF-8, it could be saved as-is in the file,
> minus any tabs, unbreakable spaces, or line feeds.

I don't see any problem with this code. It only replaces all ASCII
control characters (including delete). So this must be an issue with
still having the old name in the cache.

Regards

Marcel



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] non-ASCII chars in device names

[Bastien Nocera]

On Wed, 2007-03-07 at 12:34 +0100, Marcel Holtmann wrote:
> Hi Bastien,
> 
> > I got this report for gnome-bluetooth some time ago:
> > http://bugzilla.gnome.org/show_bug.cgi?id=380408
> > 
> > I fixed the problem altogether by replacing this code by D-Bus code
> > calling hcid. The problem is that the name of the device only shows up
> > the very first time the device is discovered, and it seems to me that
> > the cache is busted:
> > 
> > In hcid/storage.c:
> >         for (i = 0; i < 248 && name[i]; i++)
> >                 if ((unsigned char) name[i] < 32 || name[i] == 127)
> >                         str[i] = '.';
> >                 else
> >                         str[i] = name[i];
> > 
> > Why? If the data is correct UTF-8, it could be saved as-is in the file,
> > minus any tabs, unbreakable spaces, or line feeds.
> 
> I don't see any problem with this code. It only replaces all ASCII
> control characters (including delete). So this must be an issue with
> still having the old name in the cache.

It wasn't the old cache (as I delete it, to be sure) but an old
bluez-utils (3.7) that had this problem. Works fine with 3.9.

Cheers

-- 
Bastien Nocera <hadess@hadess.net> 


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] non-ASCII chars in device names

[Johan Hedberg]

Hi Bastien,

On Wed, Mar 07, 2007, Bastien Nocera wrote:
> > > In hcid/storage.c:
> > >         for (i = 0; i < 248 && name[i]; i++)
> > >                 if ((unsigned char) name[i] < 32 || name[i] == 127)
> > >                         str[i] = '.';
> > >                 else
> > >                         str[i] = name[i];
> > > 
> > > Why? If the data is correct UTF-8, it could be saved as-is in the file,
> > > minus any tabs, unbreakable spaces, or line feeds.
> > 
> > I don't see any problem with this code. It only replaces all ASCII
> > control characters (including delete). So this must be an issue with
> > still having the old name in the cache.
> 
> It wasn't the old cache (as I delete it, to be sure) but an old
> bluez-utils (3.7) that had this problem. Works fine with 3.9.

Yep, in 3.7 the unsigned char typecast was missing which caused all 
greater than 7 bit characters to be replaced by '.'

Johan

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel