[Bluez-devel] [PATCH] Fix sensitivity in the wizard

[Bluez-devel] [PATCH] Fix sensitivity in the wizard

[Bastien Nocera]

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

- Go to the device selection page
- Select a device (next button is sensitive)
- Unselect device (using Ctrl+Click) button stays sensitive

I also switched to using the signal instead of the property, removes a
bit of code.

-- 
Bastien Nocera <hadess@hadess.net> 

[-- Attachment #2: bluez-gnome-fix-selection-sensitivity.patch --]
[-- Type: text/x-patch, Size: 1427 bytes --]

Index: main.c
===================================================================
RCS file: /cvsroot/bluez/gnome/wizard/main.c,v
retrieving revision 1.18
diff -u -p -r1.18 main.c
--- main.c	26 Jul 2007 08:05:40 -0000	1.18
+++ main.c	26 Jul 2007 10:06:21 -0000
@@ -294,13 +294,10 @@ static void create_type(GtkWidget *assis
 	gtk_box_pack_start(GTK_BOX(vbox), button, FALSE, FALSE, 0);
 }
 
-static void select_callback(GObject *object,
-				GParamSpec *spec, gpointer user_data)
+static void select_callback(BluetoothDeviceSelection *sel,
+				gchar *selected, gpointer user_data)
 {
 	GtkAssistant *assistant = user_data;
-	gchar *selected;
-
-	g_object_get(object, "device-selected", &selected, NULL);
 
 	if (selected != NULL) {
 		g_free(address);
@@ -309,9 +306,7 @@ static void select_callback(GObject *obj
 
 		gtk_assistant_set_page_complete(assistant, page_search, TRUE);
 	} else
-		gtk_assistant_set_page_complete(assistant, page_search, TRUE);
-
-	g_free(selected);
+		gtk_assistant_set_page_complete(assistant, page_search, FALSE);
 }
 
 static void create_search(GtkWidget *assistant)
@@ -325,7 +320,7 @@ static void create_search(GtkWidget *ass
 
 	selector = bluetooth_device_selection_new(NULL);
 
-	g_signal_connect(selector, "notify::device-selected",
+	g_signal_connect(selector, "selected-device-changed",
 				G_CALLBACK(select_callback), assistant);
 
 	gtk_container_add(GTK_CONTAINER(vbox), selector);

[-- Attachment #3: Type: text/plain, Size: 315 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

[-- Attachment #4: Type: text/plain, Size: 164 bytes --]

_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] [PATCH] Fix sensitivity in the wizard

[Marcel Holtmann]

Hi Bastien,

> - Go to the device selection page
> - Select a device (next button is sensitive)
> - Unselect device (using Ctrl+Click) button stays sensitive
> 
> I also switched to using the signal instead of the property, removes a
> bit of code.

patch has been applied. Thanks.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel