From: Marcel Holtmann <marcel@holtmann.org>
To: Fabien Chevalier <fabchevalier@free.fr>
Cc: BlueZ development <bluez-devel@lists.sourceforge.net>,
Johan Hedberg <johan.hedberg@nokia.com>
Subject: Re: [Bluez-devel] [PATCH] Bluez exceptions refactoring updated patch
Date: Mon, 26 Nov 2007 06:47:31 +0100 [thread overview]
Message-ID: <1196056051.4217.51.camel@aeonflux> (raw)
In-Reply-To: <4749E9DB.3020801@free.fr>
Hi Fabien,
> I finally managed to spend a few hours of my spare time on Bluez.
>
> As a result i updated the patch that updates the common/ directory as
> well as the various services to share the exceptions definition.
>
> Changes compared to previous version:
> - renamed the common .h and .c as error.h and error.c
> - completely removed various error.{c,h} from services directory
> - updated api documentation (dbus-api.txt + services api definition).
>
> The patch is pretty big, if needed i can provided splitted patches for
> various directories.
I think we should do it in a few steps to make it actually readable if
we ever have to track this down:
- Create common/error.[ch]
- Update dbus-api.txt
- Remove error.[ch] from every service and use common/error.h
It should be one patch per service and also update its API
document
Two comments on your patch itself. The copyright on common/error.[ch] is
not only yours. Keep the original copyright of the files.
It is great that you added comments for each function, but they belong
inside the *.c files. The rule is that they should be placed where the
actual function body is defined.
Regards
Marcel
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel
next prev parent reply other threads:[~2007-11-26 5:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-25 21:32 [PATCH] Bluez exceptions refactoring updated patch Fabien Chevalier
2007-11-26 5:47 ` Marcel Holtmann [this message]
2007-11-26 16:12 ` Fabien Chevalier
2007-11-27 20:54 ` [Bluez-devel] " Marcel Holtmann
2007-11-30 9:01 ` Fabien Chevalier
2007-11-30 9:41 ` Marcel Holtmann
2007-11-26 14:12 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196056051.4217.51.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=bluez-devel@lists.sourceforge.net \
--cc=fabchevalier@free.fr \
--cc=johan.hedberg@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox