[PATCH] Bluez build system

[PATCH] Bluez build system

[Jaap A. Haitsma]

[-- Attachment #1: Type: text/plain, Size: 1360 bytes --]

Hi Marcel,

With a couple of months delay but here it is.

Attached you find autogen.sh. Just put this file in the gnome
directory of bluez and gnome-bluetooth can be build with jhbuild. NOTE
you need to have the package gnome-common installed. gnome-common
contains common scripts and macros to make developing GNOME apps
easier

The files bootstrap and bootstrap-configure can be removed because
autogen.sh is now doing that job.

Jaap



On Sep 2, 2007 10:33 PM, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Jaap,
>
> > I was looking into bluez and noticed that you don't use the standard
> > autogen.sh way to build your the bluez programs. I noticed this when
> > trying to add bluez-gnome to jhbuild [1].
> >
> > I wouldn't mind writing the patch so that at least the gnome part uses
> > the standard way that GNOME builds modules. I'd like to know if you
> > accept such a patch.
>
> post a patch to the bluez-devel mailing list and I take a look at it.
> Never used jhbuild before.
>
> > BTW I noticed that mailing lists contains a lot of SPAM. Is there
> > anything you can do about that? I'd like to contribute to bluez now
> > and then and follow the devel discussions but I don't like the SPAM
>
> Take this up with the Sourceforge.net admins. It is totally their fault.
> For me my spam filters catch most of it.
>
> Regards
>
> Marcel
>
>
>

[-- Attachment #2: autogen.sh --]
[-- Type: application/x-sh, Size: 608 bytes --]

Re: [Bluez-devel] [PATCH] Bluez build system

[Marcel Holtmann]

Hi Jaap,

> With a couple of months delay but here it is.
> 
> Attached you find autogen.sh. Just put this file in the gnome
> directory of bluez and gnome-bluetooth can be build with jhbuild. NOTE
> you need to have the package gnome-common installed. gnome-common
> contains common scripts and macros to make developing GNOME apps
> easier

that is not gonna happen since even if it is called bluez-gnome, it can
be build and used without GNOME. Its only dependency is GTK+. So
depending on gnome-common is not an option.

> The files bootstrap and bootstrap-configure can be removed because
> autogen.sh is now doing that job.

I actually like bootstrap and bootstrap-configure, because they do
exactly the right job for the developers.

Regards

Marcel



-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [PATCH] Bluez build system

[Jaap A. Haitsma]

On Dec 16, 2007 10:49 PM, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Jaap,
>
> > With a couple of months delay but here it is.
> >
> > Attached you find autogen.sh. Just put this file in the gnome
> > directory of bluez and gnome-bluetooth can be build with jhbuild. NOTE
> > you need to have the package gnome-common installed. gnome-common
> > contains common scripts and macros to make developing GNOME apps
> > easier
>
> that is not gonna happen since even if it is called bluez-gnome, it can
> be build and used without GNOME. Its only dependency is GTK+. So
> depending on gnome-common is not an option.

It's a build time dependency only. There is no run time dependency.

> > The files bootstrap and bootstrap-configure can be removed because
> > autogen.sh is now doing that job.
>
> I actually like bootstrap and bootstrap-configure, because they do
> exactly the right job for the developers.
>
I'd like to have autogen.sh because then bluez gnome can get build with jhbuild
I then see two options
1) Add autogen.sh as is and also leave the bootstrap files in CVS
2) I'll need to hack up an autogen.sh which doesn't need gnome-common.
I'm not an autofoo expert but I guess that can be done

What's acceptable for you?

Jaap

Re: [Bluez-devel] [PATCH] Bluez build system

[Marcel Holtmann]

Hi Jaap,

> > > With a couple of months delay but here it is.
> > >
> > > Attached you find autogen.sh. Just put this file in the gnome
> > > directory of bluez and gnome-bluetooth can be build with jhbuild. NOTE
> > > you need to have the package gnome-common installed. gnome-common
> > > contains common scripts and macros to make developing GNOME apps
> > > easier
> >
> > that is not gonna happen since even if it is called bluez-gnome, it can
> > be build and used without GNOME. Its only dependency is GTK+. So
> > depending on gnome-common is not an option.
> 
> It's a build time dependency only. There is no run time dependency.

I am making no difference in build or runtime dependency here. Every
extra dependency is bad. Especially if they are useless.

> > > The files bootstrap and bootstrap-configure can be removed because
> > > autogen.sh is now doing that job.
> >
> > I actually like bootstrap and bootstrap-configure, because they do
> > exactly the right job for the developers.
> >
> I'd like to have autogen.sh because then bluez gnome can get build with jhbuild
> I then see two options
> 1) Add autogen.sh as is and also leave the bootstrap files in CVS
> 2) I'll need to hack up an autogen.sh which doesn't need gnome-common.
> I'm not an autofoo expert but I guess that can be done

Is it a modified autogen.sh or a standard one? Do it have to be inside
the tarball or is CVS enough?

Regards

Marcel



-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [PATCH] Bluez build system

[Jaap A. Haitsma]

On Dec 17, 2007 2:00 AM, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Jaap,
>
> > > > With a couple of months delay but here it is.
> > > >
> > > > Attached you find autogen.sh. Just put this file in the gnome
> > > > directory of bluez and gnome-bluetooth can be build with jhbuild. NOTE
> > > > you need to have the package gnome-common installed. gnome-common
> > > > contains common scripts and macros to make developing GNOME apps
> > > > easier
> > >
> > > that is not gonna happen since even if it is called bluez-gnome, it can
> > > be build and used without GNOME. Its only dependency is GTK+. So
> > > depending on gnome-common is not an option.
> >
> > It's a build time dependency only. There is no run time dependency.
>
> I am making no difference in build or runtime dependency here. Every
> extra dependency is bad. Especially if they are useless.
>
> > > > The files bootstrap and bootstrap-configure can be removed because
> > > > autogen.sh is now doing that job.
> > >
> > > I actually like bootstrap and bootstrap-configure, because they do
> > > exactly the right job for the developers.
> > >
> > I'd like to have autogen.sh because then bluez gnome can get build with jhbuild
> > I then see two options
> > 1) Add autogen.sh as is and also leave the bootstrap files in CVS
> > 2) I'll need to hack up an autogen.sh which doesn't need gnome-common.
> > I'm not an autofoo expert but I guess that can be done
>
> Is it a modified autogen.sh or a standard one? Do it have to be inside
> the tarball or is CVS enough?
>
Just needs to be in CVS. It won't be part of the tarball. I guess it's
just a standard one, but as I said I'm not an expert at it. I'll look
into other projects which use autogen.sh but don't use gnome-common

Jaap

Re: [Bluez-devel] [PATCH] Bluez build system

[Marcel Holtmann]

Hi Jaap,

> > > > > With a couple of months delay but here it is.
> > > > >
> > > > > Attached you find autogen.sh. Just put this file in the gnome
> > > > > directory of bluez and gnome-bluetooth can be build with jhbuild. NOTE
> > > > > you need to have the package gnome-common installed. gnome-common
> > > > > contains common scripts and macros to make developing GNOME apps
> > > > > easier
> > > >
> > > > that is not gonna happen since even if it is called bluez-gnome, it can
> > > > be build and used without GNOME. Its only dependency is GTK+. So
> > > > depending on gnome-common is not an option.
> > >
> > > It's a build time dependency only. There is no run time dependency.
> >
> > I am making no difference in build or runtime dependency here. Every
> > extra dependency is bad. Especially if they are useless.
> >
> > > > > The files bootstrap and bootstrap-configure can be removed because
> > > > > autogen.sh is now doing that job.
> > > >
> > > > I actually like bootstrap and bootstrap-configure, because they do
> > > > exactly the right job for the developers.
> > > >
> > > I'd like to have autogen.sh because then bluez gnome can get build with jhbuild
> > > I then see two options
> > > 1) Add autogen.sh as is and also leave the bootstrap files in CVS
> > > 2) I'll need to hack up an autogen.sh which doesn't need gnome-common.
> > > I'm not an autofoo expert but I guess that can be done
> >
> > Is it a modified autogen.sh or a standard one? Do it have to be inside
> > the tarball or is CVS enough?
> >
> Just needs to be in CVS. It won't be part of the tarball. I guess it's
> just a standard one, but as I said I'm not an expert at it. I'll look
> into other projects which use autogen.sh but don't use gnome-common

if it only will be in the CVS for jhbuild, then you don't have to modify
anything. Simply make sure it is a really default one and I put it
there.

Regards

Marcel



-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [PATCH] Bluez build system

[Jaap A. Haitsma]

[-- Attachment #1: Type: text/plain, Size: 2120 bytes --]

On Dec 17, 2007 8:06 PM, Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Jaap,
>
> > > > > > With a couple of months delay but here it is.
> > > > > >
> > > > > > Attached you find autogen.sh. Just put this file in the gnome
> > > > > > directory of bluez and gnome-bluetooth can be build with jhbuild. NOTE
> > > > > > you need to have the package gnome-common installed. gnome-common
> > > > > > contains common scripts and macros to make developing GNOME apps
> > > > > > easier
> > > > >
> > > > > that is not gonna happen since even if it is called bluez-gnome, it can
> > > > > be build and used without GNOME. Its only dependency is GTK+. So
> > > > > depending on gnome-common is not an option.
> > > >
> > > > It's a build time dependency only. There is no run time dependency.
> > >
> > > I am making no difference in build or runtime dependency here. Every
> > > extra dependency is bad. Especially if they are useless.
> > >
> > > > > > The files bootstrap and bootstrap-configure can be removed because
> > > > > > autogen.sh is now doing that job.
> > > > >
> > > > > I actually like bootstrap and bootstrap-configure, because they do
> > > > > exactly the right job for the developers.
> > > > >
> > > > I'd like to have autogen.sh because then bluez gnome can get build with jhbuild
> > > > I then see two options
> > > > 1) Add autogen.sh as is and also leave the bootstrap files in CVS
> > > > 2) I'll need to hack up an autogen.sh which doesn't need gnome-common.
> > > > I'm not an autofoo expert but I guess that can be done
> > >
> > > Is it a modified autogen.sh or a standard one? Do it have to be inside
> > > the tarball or is CVS enough?
> > >
> > Just needs to be in CVS. It won't be part of the tarball. I guess it's
> > just a standard one, but as I said I'm not an expert at it. I'll look
> > into other projects which use autogen.sh but don't use gnome-common
>
> if it only will be in the CVS for jhbuild, then you don't have to modify
> anything. Simply make sure it is a really default one and I put it
> there.
>
New autogen.sh with no dependencies on gnome-common attached

Jaap

[-- Attachment #2: autogen.sh --]
[-- Type: application/x-sh, Size: 917 bytes --]

Re: [Bluez-devel] [PATCH] Bluez build system

[Didier Link]

LS0tLS1CRUdJTiBQR1AgU0lHTkVEIE1FU1NBR0UtLS0tLQ0KSGFzaDogU0hBMQ0KDQoNCj4gTmV3
IGF1dG9nZW4uc2ggd2l0aCBubyBkZXBlbmRlbmNpZXMgb24gZ25vbWUtY29tbW9uIGF0dGFjaGVk
DQo+IA0KPiBKYWFwDQoNCkhpIEphYXAsDQoNCkkganVzdCBzZWUgeW91ciBhdXRvZ2VuLnNoIGFu
ZCBJIHRoaW5rIGFib3V0IGF1dG9yZWNvbmYuIFRoaXMgdG9vbCBjYW4NCnJlYnVpbGQgdGhlIGF1
dG90b29scyBpbiBhIHByb2plY3QgbGlrZSB5b3VyIGF1dG9nZW4uc2ggZG9lcy4NCg0KTXkgcHJv
amVjdCdzIGF1dG9nZW4uc2ggY29udGFpbnMgb25seSBvbmUgbGluZSA6IGF1dG9yZWNvbmYgLWYN
Cg0KSXQgaXMgaW5jbHVkZWQgaW4gYXV0b2NvbmYgcGFja2FnZSA7KQ0KDQpEaWRpZXINCg0KLSAt
LSANCkRpZGllciBMaW5rIDxkaWRpZXJAZmFtaWxsZS1saW5rLmZyPg0KSmFiYmVyIDogZGlkaWVy
X2xpbmtAamFiYmVyLmZyDQpNU04gOiB6YW5maWJAaG90bWFpbC5mcg0KU0lQIDogWmFuZmliQGVr
aWdhLm5ldA0KDQpDbMOpIEdQRyA6IDc1QkFDOUVFDQotLS0tLUJFR0lOIFBHUCBTSUdOQVRVUkUt
LS0tLQ0KVmVyc2lvbjogR251UEcgdjEuNC43IChHTlUvTGludXgpDQoNCmlEOERCUUZIYUV3aWt5
UHdpblc2eWU0UkFqcFZBSjR2Vk9tUWZKNkFMVW54N0JzYnNKTU90U3VaY2dDZmF2aloNCnRrTGJ2
M0VqTDZaU25SQjAvUkM3MmtnPQ0KPVpaeDUNCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQ0K
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLQpTRi5OZXQgZW1haWwgaXMgc3BvbnNvcmVkIGJ5OgpDaGVjayBvdXQg
dGhlIG5ldyBTb3VyY2VGb3JnZS5uZXQgTWFya2V0cGxhY2UuCkl0J3MgdGhlIGJlc3QgcGxhY2Ug
dG8gYnV5IG9yIHNlbGwgc2VydmljZXMKZm9yIGp1c3QgYWJvdXQgYW55dGhpbmcgT3BlbiBTb3Vy
Y2UuCmh0dHA6Ly9hZC5kb3VibGVjbGljay5uZXQvY2xrOzE2NDIxNjIzOTsxMzUwMzAzODt3P2h0
dHA6Ly9zZi5uZXQvbWFya2V0cGxhY2UKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX18KQmx1ZXotZGV2ZWwgbWFpbGluZyBsaXN0CkJsdWV6LWRldmVsQGxpc3Rz
LnNvdXJjZWZvcmdlLm5ldApodHRwczovL2xpc3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9saXN0
aW5mby9ibHVlei1kZXZlbAo=

Re: [Bluez-devel] [PATCH] Bluez build system

[Marcel Holtmann]

Hi Didier,

> I just see your autogen.sh and I think about autoreconf. This tool can
> rebuild the autotools in a project like your autogen.sh does.
> 
> My project's autogen.sh contains only one line : autoreconf -f

try it on a bare repository from CVS and you will see it fails. It is
not meant for bootstrapping things. And to be quite honest, if it works
for you, you have too many files in your repository that could be
auto-generated.

Regards

Marcel



-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] [PATCH] Bluez build system

[Marcel Holtmann]

Hi Jaap,

> > > > > > > With a couple of months delay but here it is.
> > > > > > >
> > > > > > > Attached you find autogen.sh. Just put this file in the gnome
> > > > > > > directory of bluez and gnome-bluetooth can be build with jhbuild. NOTE
> > > > > > > you need to have the package gnome-common installed. gnome-common
> > > > > > > contains common scripts and macros to make developing GNOME apps
> > > > > > > easier
> > > > > >
> > > > > > that is not gonna happen since even if it is called bluez-gnome, it can
> > > > > > be build and used without GNOME. Its only dependency is GTK+. So
> > > > > > depending on gnome-common is not an option.
> > > > >
> > > > > It's a build time dependency only. There is no run time dependency.
> > > >
> > > > I am making no difference in build or runtime dependency here. Every
> > > > extra dependency is bad. Especially if they are useless.
> > > >
> > > > > > > The files bootstrap and bootstrap-configure can be removed because
> > > > > > > autogen.sh is now doing that job.
> > > > > >
> > > > > > I actually like bootstrap and bootstrap-configure, because they do
> > > > > > exactly the right job for the developers.
> > > > > >
> > > > > I'd like to have autogen.sh because then bluez gnome can get build with jhbuild
> > > > > I then see two options
> > > > > 1) Add autogen.sh as is and also leave the bootstrap files in CVS
> > > > > 2) I'll need to hack up an autogen.sh which doesn't need gnome-common.
> > > > > I'm not an autofoo expert but I guess that can be done
> > > >
> > > > Is it a modified autogen.sh or a standard one? Do it have to be inside
> > > > the tarball or is CVS enough?
> > > >
> > > Just needs to be in CVS. It won't be part of the tarball. I guess it's
> > > just a standard one, but as I said I'm not an expert at it. I'll look
> > > into other projects which use autogen.sh but don't use gnome-common
> >
> > if it only will be in the CVS for jhbuild, then you don't have to modify
> > anything. Simply make sure it is a really default one and I put it
> > there.
> >
> New autogen.sh with no dependencies on gnome-common attached

I put that on into the CVS now. Everything should be good then.

Regards

Marcel



-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel