[Bluez-devel] HT820, capture and eSCO

[Bluez-devel] HT820, capture and eSCO

[Guillaume Bedot]

Hello,

I have issues using "voice"/HSP/HFP profiles with this headset and
latest kernels/bluez cvs.

It seems it tries to use extended SCO when it shouldn't...

hcitool info xx:xx:xx:xx:xx:xx
Requesting information ...
	BD Address:  xx:xx:xx:xx:xx:xx
	Device Name: Motorola HT820
	LMP Version: 2.0 (0x3) LMP Subversion: 0xa41
	Manufacturer: Cambridge Silicon Radio (10)
	Features: 0xff 0xff 0x8b 0x78 0x18 0x18 0x00 0x80
		<3-slot packets> <5-slot packets> <encryption> <slot offset> 
		<timing accuracy> <role switch> <hold mode> <sniff mode> 
		<park state> <RSSI> <channel quality> <SCO link> <HV2 packets> 
		<HV3 packets> <u-law log> <A-law log> <CVSD> <paging scheme> 
		<transparent SCO> <broadcast encrypt> <enhanced iscan> 
		<interlaced iscan> <interlaced pscan> <inquiry with RSSI> 
		<AFH cap. slave> <AFH class. slave> <AFH cap. master> 
		<AFH class. master> <extended features> 

An other headset which support eSCO, works fine :

hcitool info xx:xx:xx:xx:xx:xx
Requesting information ...
	BD Address:  xx:xx:xx:xx:xx:xx
	Device Name: PROF PBH-6W
	LMP Version: 2.0 (0x3) LMP Subversion: 0x978
	Manufacturer: Cambridge Silicon Radio (10)
	Features: 0xfd 0xfe 0x8f 0x80 0x0b 0xa8 0x00 0x80
		<3-slot packets> <encryption> <slot offset> <timing accuracy> 
		<role switch> <hold mode> <sniff mode> <RSSI> 
		<channel quality> <SCO link> <HV2 packets> <HV3 packets> 
		<u-law log> <A-law log> <CVSD> <paging scheme> <power control> 
		<transparent SCO> <broadcast encrypt> <extended SCO> 
		<EV4 packets> <EV5 packets> <AFH cap. slave> <AFH cap. master> 
		<EDR eSCO 2 Mbps> <3-slot EDR eSCO> <extended features> 

What can I do to help now ?

Best regards,

Guillaume B.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] HT820, capture and eSCO

[Guillaume Bedot]

On sam, 2008-01-26 at 09:39 +0100, Guillaume Bedot wrote:
> Hello,
> 
> I have issues using "voice"/HSP/HFP profiles with this headset and
> latest kernels/bluez cvs.
> 
> It seems it tries to use extended SCO when it shouldn't...
> 
> hcitool info xx:xx:xx:xx:xx:xx
> Requesting information ...
> 	BD Address:  xx:xx:xx:xx:xx:xx
> 	Device Name: Motorola HT820
> 	LMP Version: 2.0 (0x3) LMP Subversion: 0xa41
> 	Manufacturer: Cambridge Silicon Radio (10)
> 	Features: 0xff 0xff 0x8b 0x78 0x18 0x18 0x00 0x80
> 		<3-slot packets> <5-slot packets> <encryption> <slot offset> 
> 		<timing accuracy> <role switch> <hold mode> <sniff mode> 
> 		<park state> <RSSI> <channel quality> <SCO link> <HV2 packets> 
> 		<HV3 packets> <u-law log> <A-law log> <CVSD> <paging scheme> 
> 		<transparent SCO> <broadcast encrypt> <enhanced iscan> 
> 		<interlaced iscan> <interlaced pscan> <inquiry with RSSI> 
> 		<AFH cap. slave> <AFH class. slave> <AFH cap. master> 
> 		<AFH class. master> <extended features> 

If it can help, I noticed there are a lot of these messages in syslog :

Jan 26 07:52:05 littletux kernel: hci_scodata_packet: hci0 SCO packet
for unknown connection handle 1

And with "hifi" profile, the headset playback works although it seems to
use eSCO too :

hcitool con
Connections:
	> ACL xx:xx:xx:xx:xx:xx handle 11 state 1 lm SLAVE AUTH ENCRYPT SECURE 
	< eSCO xx:xx:xx:xx:xx:xx handle 0 state 8 lm SLAVE 

I'm not sure what the problem is anymore...

Best regards,

Guillaume B.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] HT820, capture and eSCO

[Guillaume Bedot]

U29ycnkgZm9yIHRyaXBsZSBwb3N0aW5nIC4uLgoKTGUgc2FtZWRpIDI2IGphbnZpZXIgMjAwOCDD
oCAxMDowMSArMDEwMCwgR3VpbGxhdW1lIEJlZG90IGEgw6ljcml0IDoKPiBoY2l0b29sIGNvbgo+
IENvbm5lY3Rpb25zOgo+IAk+IEFDTCB4eDp4eDp4eDp4eDp4eDp4eCBoYW5kbGUgMTEgc3RhdGUg
MSBsbSBTTEFWRSBBVVRIIEVOQ1JZUFQgU0VDVVJFIAo+IAk8IGVTQ08geHg6eHg6eHg6eHg6eHg6
eHggaGFuZGxlIDAgc3RhdGUgOCBsbSBTTEFWRSAKCk9rYXksIHRoaXMgY29ubmV4aW9uIHdhcyBr
ZXB0IGFsaXZlIGJ1dCBpc24ndCB1c2VkIGZvciBwbGF5YmFjay4KCkFuZCBJIGZvcmdvdCB0byB0
ZWxsIHRoZSBjYXB0dXJlIHdvcmtzIHdpdGggYW4gb2xkZXIga2VybmVsIDoKdW5hbWUgLWEKTGlu
dXggbG9jYWxob3N0IDIuNi4yMi4xMi1kZXNrdG9wLTFtZHYgIzEgU01QIFR1ZSBOb3YgMjAgMDg6
Mzg6MjcgRVNUCjIwMDcgaTY4NiBBTUQgQXRobG9uKHRtKSBYUCAxODAwKyBHTlUvTGludXgKCmNv
bm5leGlvbiBvcGVuZWQgd2hlbiB1c2luZyAiaGlmaSIgKHBsYXliYWNrKSA6CmhjaXRvb2wgY29u
CkNvbm5lY3Rpb25zOgogICAgICAgID4gQUNMIDAwOjA3OkE0OkYyOkJDOjNGIGhhbmRsZSAxMSBz
dGF0ZSAxIGxtIFNMQVZFIEFVVEggRU5DUllQVApTRUNVUkUgCgpjb25uZXhpb24gb3BlbmVkIHdo
ZW4gdXNpbmcgInZvaWNlIiAoY2FwdHVyZSBhbmQgcGxheWJhY2spIDoKaGNpdG9vbCBjb24KQ29u
bmVjdGlvbnM6CiAgICAgICAgPCBTQ08geHg6eHg6eHg6eHg6eHg6eHggaGFuZGxlIDEgc3RhdGUg
MSBsbSBTTEFWRSAKICAgICAgICA+IEFDTCB4eDp4eDp4eDp4eDp4eDp4eCBoYW5kbGUgMTEgc3Rh
dGUgMSBsbSBTTEFWRSBBVVRIIEVOQ1JZUFQKU0VDVVJFIAoKU28sIGhvdyBjYW4gSSBmb3JjZSB1
c2Ugb2YgU0NPIGluc3RlYWQgb2YgZVNDTyA/CgpCZXN0IHJlZ2FyZHMsCgpHdWlsbGF1bWUgQi4K
CgotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tClRoaXMgU0YubmV0IGVtYWlsIGlzIHNwb25zb3JlZCBieTogTWlj
cm9zb2Z0CkRlZnkgYWxsIGNoYWxsZW5nZXMuIE1pY3Jvc29mdChSKSBWaXN1YWwgU3R1ZGlvIDIw
MDguCmh0dHA6Ly9jbGsuYXRkbXQuY29tL01SVC9nby92c2UwMTIwMDAwMDcwbXJ0L2RpcmVjdC8w
MS8KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KQmx1ZXot
ZGV2ZWwgbWFpbGluZyBsaXN0CkJsdWV6LWRldmVsQGxpc3RzLnNvdXJjZWZvcmdlLm5ldApodHRw
czovL2xpc3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9saXN0aW5mby9ibHVlei1kZXZlbAo=

Re: [Bluez-devel] HT820, capture and eSCO

[Guillaume Bedot]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

Re,

An other (ugly?) patch that fixes this issue for me.

There are an other case, for incoming connections (headset->dongle), I
guess, which is not taken into account, because i'm not sure what to
do / how to test.

Best regards,

Guillaume B.

[-- Attachment #2: kernel-2.6.24-check-both-ends-for-esco-features.patch --]
[-- Type: text/x-patch, Size: 1201 bytes --]

--- net/bluetooth/hci_conn.c.orig	2008-01-28 09:15:50.000000000 +0100
+++ net/bluetooth/hci_conn.c	2008-01-28 09:25:19.000000000 +0100
@@ -332,6 +332,11 @@
 	if (type == ACL_LINK)
 		return acl;
 
+	if (lmp_esco_capable(hdev) && lmp_esco_capable(acl)) {
+		type=ESCO_LINK;
+	} else {
+		type=SCO_LINK;
+	}
 	if (!(sco = hci_conn_hash_lookup_ba(hdev, type, dst))) {
 		if (!(sco = hci_conn_add(hdev, type, dst))) {
 			hci_conn_put(acl);
@@ -346,7 +351,7 @@
 
 	if (acl->state == BT_CONNECTED &&
 			(sco->state == BT_OPEN || sco->state == BT_CLOSED)) {
-		if (lmp_esco_capable(hdev))
+		if (type==ESCO_LINK)
 			hci_setup_sync(sco, acl->handle);
 		else
 			hci_add_sco(sco, acl->handle);
--- net/bluetooth/sco.c.orig	2008-01-28 09:15:14.000000000 +0100
+++ net/bluetooth/sco.c	2008-01-28 09:21:00.000000000 +0100
@@ -189,7 +189,7 @@
 	struct sco_conn *conn;
 	struct hci_conn *hcon;
 	struct hci_dev  *hdev;
-	int err, type;
+	int err;
 
 	BT_DBG("%s -> %s", batostr(src), batostr(dst));
 
@@ -200,9 +200,7 @@
 
 	err = -ENOMEM;
 
-	type = lmp_esco_capable(hdev) ? ESCO_LINK : SCO_LINK;
-
-	hcon = hci_connect(hdev, type, dst);
+	hcon = hci_connect(hdev, SCO_LINK, dst);
 	if (!hcon)
 		goto done;
 

[-- Attachment #3: Type: text/plain, Size: 228 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[-- Attachment #4: Type: text/plain, Size: 164 bytes --]

_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] [PATCH] HT820, capture and eSCO

[Guillaume Bedot]

[-- Attachment #1: Type: text/plain, Size: 88 bytes --]

Re,

New version of the patch with some unneeded lines removed.

Regards,

Guillaume B.

[-- Attachment #2: kernel-2.6.24-check-both-ends-for-esco-feature-v2.patch --]
[-- Type: text/x-patch, Size: 1165 bytes --]

--- net/bluetooth/hci_conn.c.orig	2008-01-28 09:15:50.000000000 +0100
+++ net/bluetooth/hci_conn.c	2008-01-28 09:25:19.000000000 +0100
@@ -332,6 +332,8 @@
 	if (type == ACL_LINK)
 		return acl;
 
+	if (lmp_esco_capable(hdev) && lmp_esco_capable(acl))
+		type=ESCO_LINK;
 	if (!(sco = hci_conn_hash_lookup_ba(hdev, type, dst))) {
 		if (!(sco = hci_conn_add(hdev, type, dst))) {
 			hci_conn_put(acl);
@@ -346,7 +351,7 @@
 
 	if (acl->state == BT_CONNECTED &&
 			(sco->state == BT_OPEN || sco->state == BT_CLOSED)) {
-		if (lmp_esco_capable(hdev))
+		if (type==ESCO_LINK)
 			hci_setup_sync(sco, acl->handle);
 		else
 			hci_add_sco(sco, acl->handle);
--- net/bluetooth/sco.c.orig	2008-01-28 09:15:14.000000000 +0100
+++ net/bluetooth/sco.c	2008-01-28 09:21:00.000000000 +0100
@@ -189,7 +189,7 @@
 	struct sco_conn *conn;
 	struct hci_conn *hcon;
 	struct hci_dev  *hdev;
-	int err, type;
+	int err;
 
 	BT_DBG("%s -> %s", batostr(src), batostr(dst));
 
@@ -200,9 +200,7 @@
 
 	err = -ENOMEM;
 
-	type = lmp_esco_capable(hdev) ? ESCO_LINK : SCO_LINK;
-
-	hcon = hci_connect(hdev, type, dst);
+	hcon = hci_connect(hdev, SCO_LINK, dst);
 	if (!hcon)
 		goto done;
 

[-- Attachment #3: Type: text/plain, Size: 228 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[-- Attachment #4: Type: text/plain, Size: 164 bytes --]

_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] [PATCH] HT820, capture and eSCO

[Guillaume Bedot]

[-- Attachment #1: Type: text/plain, Size: 107 bytes --]

Re,

I'm really sorry, I forgot a part of the patch....

Here is a full version.

Regards,

Guillaume B.



[-- Attachment #2: kernel-2.6.24-check-both-ends-for-esco-feature-v3.patch --]
[-- Type: text/x-patch, Size: 1579 bytes --]

--- net/bluetooth/hci_conn.c.orig	2008-01-28 09:15:50.000000000 +0100
+++ net/bluetooth/hci_conn.c	2008-01-28 18:21:45.000000000 +0100
@@ -332,6 +332,8 @@
 	if (type == ACL_LINK)
 		return acl;
 
+	if (lmp_esco_capable(hdev) && lmp_esco_capable(acl))
+		type=ESCO_LINK;
 	if (!(sco = hci_conn_hash_lookup_ba(hdev, type, dst))) {
 		if (!(sco = hci_conn_add(hdev, type, dst))) {
 			hci_conn_put(acl);
@@ -346,7 +349,7 @@
 
 	if (acl->state == BT_CONNECTED &&
 			(sco->state == BT_OPEN || sco->state == BT_CLOSED)) {
-		if (lmp_esco_capable(hdev))
+		if (type==ESCO_LINK)
 			hci_setup_sync(sco, acl->handle);
 		else
 			hci_add_sco(sco, acl->handle);
--- net/bluetooth/sco.c.orig	2008-01-28 09:15:14.000000000 +0100
+++ net/bluetooth/sco.c	2008-01-28 09:21:00.000000000 +0100
@@ -189,7 +189,7 @@
 	struct sco_conn *conn;
 	struct hci_conn *hcon;
 	struct hci_dev  *hdev;
-	int err, type;
+	int err;
 
 	BT_DBG("%s -> %s", batostr(src), batostr(dst));
 
@@ -200,9 +200,7 @@
 
 	err = -ENOMEM;
 
-	type = lmp_esco_capable(hdev) ? ESCO_LINK : SCO_LINK;
-
-	hcon = hci_connect(hdev, type, dst);
+	hcon = hci_connect(hdev, SCO_LINK, dst);
 	if (!hcon)
 		goto done;
 
--- net/bluetooth/hci_event.c.orig	2008-01-28 09:15:31.000000000 +0100
+++ net/bluetooth/hci_event.c	2008-01-28 18:17:16.000000000 +0100
@@ -720,7 +720,7 @@
 		struct hci_conn *sco = conn->link;
 		if (sco) {
 			if (!ev->status) {
-				if (lmp_esco_capable(hdev))
+				if (lmp_esco_capable(hdev) && lmp_esco_capable(conn))
 					hci_setup_sync(sco, conn->handle);
 				else
 					hci_add_sco(sco, conn->handle);


[-- Attachment #3: Type: text/plain, Size: 228 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[-- Attachment #4: Type: text/plain, Size: 164 bytes --]

_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel