From: Marcel Holtmann <marcel@holtmann.org>
To: BlueZ development <bluez-devel@lists.sourceforge.net>
Subject: Re: [Bluez-devel] [PATCH] Split agents
Date: Sun, 10 Feb 2008 02:21:04 +0100 [thread overview]
Message-ID: <1202606464.7664.27.camel@violet> (raw)
In-Reply-To: <1202346828.3491.47.camel@cookie.hadess.net>
Hi Bastien,
> > > First draft patch to split the agents away from the main program. Seems
> > > to work fine for me.
> > >
> > > This is mostly moving functions around though.
> >
> > Updated patch following the comments from Marcel.
>
> Patch that compiles again.
I like the split of the notifications. Can we do that first in a
separate patch. Looks simple enough and makes the history a lot cleaner
compared to a big one.
Three small things with it:
* Please use notify.[ch] as filename. I don't like too long file names.
* No need to include <glib/gi18n.h>. No translations in this file.
* I saw some whitespaces and empty line things mistakes.
Regards
Marcel
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel
next prev parent reply other threads:[~2008-02-10 1:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 17:44 [Bluez-devel] [PATCH] Split agents Bastien Nocera
2008-02-06 13:46 ` Bastien Nocera
2008-02-07 1:13 ` Bastien Nocera
2008-02-10 1:21 ` Marcel Holtmann [this message]
2008-02-10 2:02 ` Marcel Holtmann
2008-02-10 4:00 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202606464.7664.27.camel@violet \
--to=marcel@holtmann.org \
--cc=bluez-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox