public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
* [Bluez-devel] [PATCH] Set "filter" property correctly
@ 2008-03-05 21:58 Bastien Nocera
  2008-03-06 10:51 ` Marcel Holtmann
  0 siblings, 1 reply; 2+ messages in thread
From: Bastien Nocera @ 2008-03-05 21:58 UTC (permalink / raw)
  To: BlueZ Hackers

[-- Attachment #1: Type: text/plain, Size: 141 bytes --]

Heya,

- Set the default property to "phones" in the test application
- Fix setting filter properties in the device selection widget

Cheers

[-- Attachment #2: bluez-gnome-set-filter-property.patch --]
[-- Type: text/x-patch, Size: 1918 bytes --]

Index: bluetooth-device-selection.c
===================================================================
RCS file: /cvsroot/bluez/gnome/common/bluetooth-device-selection.c,v
retrieving revision 1.17
diff -u -p -u -p -r1.17 bluetooth-device-selection.c
--- bluetooth-device-selection.c	12 Feb 2008 17:26:57 -0000	1.17
+++ bluetooth-device-selection.c	5 Mar 2008 21:56:29 -0000
@@ -656,7 +656,7 @@ bluetooth_device_selection_set_property 
 		break;
 	case PROP_DEVICE_TYPE_FILTER:
 		priv->device_type_filter = g_value_get_int (value);
-		gtk_combo_box_set_active (GTK_COMBO_BOX(priv->device_type), priv->device_type_filter);
+		gtk_combo_box_set_active (GTK_COMBO_BOX(priv->device_type), priv->device_type_filter >> 1);
 		break;
 	case PROP_DEVICE_CATEGORY_FILTER:
 		priv->device_category_filter = g_value_get_int (value);
Index: test-deviceselection.c
===================================================================
RCS file: /cvsroot/bluez/gnome/common/test-deviceselection.c,v
retrieving revision 1.6
diff -u -p -u -p -r1.6 test-deviceselection.c
--- test-deviceselection.c	2 Feb 2008 04:09:39 -0000	1.6
+++ test-deviceselection.c	5 Mar 2008 21:56:29 -0000
@@ -29,6 +29,7 @@
 #include <gtk/gtk.h>
 
 #include "bluetooth-device-selection.h"
+#include "client.h"
 
 static void device_selected_cb(GObject *object,
 			       GParamSpec *spec, gpointer user_data)
@@ -78,7 +79,10 @@ int main(int argc, char **argv)
 	selector = bluetooth_device_selection_new("Select a Device to Setup");
 	gtk_container_set_border_width(GTK_CONTAINER(selector), 5);
 	gtk_widget_show(selector);
-	g_object_set(selector, "show-search", TRUE, NULL);
+	g_object_set(selector,
+		     "show-search", TRUE,
+		     "device-type-filter", BLUETOOTH_TYPE_PHONE,
+		     NULL);
 	g_signal_connect(selector, "selected-device-changed",
 			 G_CALLBACK(select_device_changed), dialog);
 	g_signal_connect(selector, "notify::device-selected",

[-- Attachment #3: Type: text/plain, Size: 228 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[-- Attachment #4: Type: text/plain, Size: 164 bytes --]

_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Bluez-devel] [PATCH] Set "filter" property correctly
  2008-03-05 21:58 [Bluez-devel] [PATCH] Set "filter" property correctly Bastien Nocera
@ 2008-03-06 10:51 ` Marcel Holtmann
  0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2008-03-06 10:51 UTC (permalink / raw)
  To: BlueZ development

Hi Bastien,

> - Set the default property to "phones" in the test application
> - Fix setting filter properties in the device selection widget

patch has been applied. Thanks.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-03-06 10:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-05 21:58 [Bluez-devel] [PATCH] Set "filter" property correctly Bastien Nocera
2008-03-06 10:51 ` Marcel Holtmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox