public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
* question on btusb_open()
@ 2008-08-19 12:25 Oliver Neukum
  2008-08-19 12:36 ` Marcel Holtmann
  0 siblings, 1 reply; 3+ messages in thread
From: Oliver Neukum @ 2008-08-19 12:25 UTC (permalink / raw)
  To: Marcel Holtmann; +Cc: linux-bluetooth, linux-usb

Hi,

if this function is reentered there's a race with the error path. Can
it be reentered?

	Regards
		Oliver

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: question on btusb_open()
  2008-08-19 12:25 question on btusb_open() Oliver Neukum
@ 2008-08-19 12:36 ` Marcel Holtmann
  2008-08-19 12:57   ` Oliver Neukum
  0 siblings, 1 reply; 3+ messages in thread
From: Marcel Holtmann @ 2008-08-19 12:36 UTC (permalink / raw)
  To: Oliver Neukum; +Cc: linux-bluetooth, linux-usb

Hi Oliver,

> if this function is reentered there's a race with the error path. Can
> it be reentered?

no. The Bluetooth core will protect against it. The open callback will
be triggered by "hciconfig hci0 up" or hcid/bluetoothd.

Regards

Marcel



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: question on btusb_open()
  2008-08-19 12:36 ` Marcel Holtmann
@ 2008-08-19 12:57   ` Oliver Neukum
  0 siblings, 0 replies; 3+ messages in thread
From: Oliver Neukum @ 2008-08-19 12:57 UTC (permalink / raw)
  To: Marcel Holtmann; +Cc: linux-bluetooth, linux-usb

Am Dienstag 19 August 2008 14:36:14 schrieben Sie:
> Hi Oliver,
> 
> > if this function is reentered there's a race with the error path. Can
> > it be reentered?
> 
> no. The Bluetooth core will protect against it. The open callback will
> be triggered by "hciconfig hci0 up" or hcid/bluetoothd.

Good. I can see no further obvious bugs in btusb. I am going on to do
power management for it.

	Regards
		Oliver

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-08-19 12:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-19 12:25 question on btusb_open() Oliver Neukum
2008-08-19 12:36 ` Marcel Holtmann
2008-08-19 12:57   ` Oliver Neukum

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox