public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Default bluez-gnome UI to a connectable state
@ 2008-09-27 19:44 Mario_Limonciello
  2008-09-29  1:52 ` Marcel Holtmann
  0 siblings, 1 reply; 2+ messages in thread
From: Mario_Limonciello @ 2008-09-27 19:44 UTC (permalink / raw)
  To: linux-bluetooth

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

Looking through the code, it appears that bluetoothd does start up connectable, but the UI doesn't reflect this from the first boot.  This patch should address it.

Mario Limonciello 
Dell | Linux Engineering 
Mario_Limonciello@Dell.com 

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 03_default_connectable.patch --]
[-- Type: text/x-patch; name="03_default_connectable.patch", Size: 687 bytes --]

diff -Nur -x '*.orig' -x '*~' bluez-gnome-1.5/properties/adapter.c bluez-gnome-1.5.new/properties/adapter.c
--- bluez-gnome-1.5/properties/adapter.c	2008-08-24 16:14:24.000000000 -0500
+++ bluez-gnome-1.5.new/properties/adapter.c	2008-09-27 03:52:57.000000000 -0500
@@ -408,9 +408,8 @@
 					_("Other devices can connect"));
 	group = gtk_radio_button_get_group(GTK_RADIO_BUTTON(button));
 	gtk_box_pack_start(GTK_BOX(vbox), button, FALSE, FALSE, 0);
-
-	if (mode && g_ascii_strcasecmp(mode, "connectable") == 0)
-		gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(button), TRUE);
+	
+	gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(button), TRUE);
 
 	adapter->button_connect = button;
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Default bluez-gnome UI to a connectable state
  2008-09-27 19:44 [PATCH] Default bluez-gnome UI to a connectable state Mario_Limonciello
@ 2008-09-29  1:52 ` Marcel Holtmann
  0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2008-09-29  1:52 UTC (permalink / raw)
  To: Mario_Limonciello; +Cc: linux-bluetooth

Hi Mario,

> Looking through the code, it appears that bluetoothd does start up connectable, but the UI doesn't reflect this from the first boot.  This patch should address it.

this patch can't be right. It can happen that the device starts up in
off mode. You need to figure out why the mode variable doesn't correctly
point to connectable.

Regards

Marcel



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-09-29  1:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-27 19:44 [PATCH] Default bluez-gnome UI to a connectable state Mario_Limonciello
2008-09-29  1:52 ` Marcel Holtmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox