[PATCH] Start wizard when left clicked

[PATCH] Start wizard when left clicked

[Mario_Limonciello]

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

Hi:

Currently the applet doesn't seem to respond to any actions when left clicked unless it's blinking.  This is counter intuitive from the expectation that something will happen when left clicked.  Attached is a patch that will spawn the wizard when left clicked, or stop blinking if it was.

Regards

Mario Limonciello 
Dell | Linux Engineering 
Mario_Limonciello@Dell.com 

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 08_start_wizard_left_click.patch --]
[-- Type: text/x-patch; name="08_start_wizard_left_click.patch", Size: 1270 bytes --]

diff -Nur -x '*.orig' -x '*~' bluez-gnome-1.5/applet/main.c bluez-gnome-1.5.new/applet/main.c
--- bluez-gnome-1.5/applet/main.c	2008-09-13 12:34:11.000000000 -0500
+++ bluez-gnome-1.5.new/applet/main.c	2008-09-28 12:37:53.000000000 -0500
@@ -176,7 +176,10 @@
 
 static void activate_callback(GObject *widget, gpointer user_data)
 {
-	show_agents();
+	if (query_blinking())
+		show_agents();
+	else
+		wizard_callback(widget,user_data);
 }
 
 static void popup_callback(GObject *widget, guint button,
diff -Nur -x '*.orig' -x '*~' bluez-gnome-1.5/applet/notify.c bluez-gnome-1.5.new/applet/notify.c
--- bluez-gnome-1.5/applet/notify.c	2008-08-24 11:05:50.000000000 -0500
+++ bluez-gnome-1.5.new/applet/notify.c	2008-09-28 12:37:56.000000000 -0500
@@ -130,3 +130,8 @@
 {
 	gtk_status_icon_set_blinking(statusicon, FALSE);
 }
+
+gboolean query_blinking(void)
+{
+	return gtk_status_icon_get_blinking(statusicon);
+}
diff -Nur -x '*.orig' -x '*~' bluez-gnome-1.5/applet/notify.h bluez-gnome-1.5.new/applet/notify.h
--- bluez-gnome-1.5/applet/notify.h	2008-08-24 11:05:50.000000000 -0500
+++ bluez-gnome-1.5.new/applet/notify.h	2008-09-28 12:37:56.000000000 -0500
@@ -34,3 +34,4 @@
 
 void enable_blinking(void);
 void disable_blinking(void);
+gboolean query_blinking(void);

Re: [PATCH] Start wizard when left clicked

[Bastien Nocera]

On Sun, 2008-09-28 at 12:45 -0500, Mario_Limonciello@Dell.com wrote:
> Hi:
> 
> Currently the applet doesn't seem to respond to any actions when left
> clicked unless it's blinking.  This is counter intuitive from the
> expectation that something will happen when left clicked.  Attached is
> a patch that will spawn the wizard when left clicked, or stop blinking
> if it was.

I'd rather it popped up the right-click menu instead of popping up the
wizard.

Re: [PATCH] Start wizard when left clicked

[Marcel Holtmann]

Hi Bastien,

> > Currently the applet doesn't seem to respond to any actions when left
> > clicked unless it's blinking.  This is counter intuitive from the
> > expectation that something will happen when left clicked.  Attached is
> > a patch that will spawn the wizard when left clicked, or stop blinking
> > if it was.
> 
> I'd rather it popped up the right-click menu instead of popping up the
> wizard.

I added a simple menu to the left-click to allow starting the wizard.

Regards

Marcel

Re: [PATCH] Start wizard when left clicked

[Bastien Nocera]

On Mon, 2008-09-29 at 11:05 +0200, Marcel Holtmann wrote:
> Hi Bastien,
> 
> > > Currently the applet doesn't seem to respond to any actions when left
> > > clicked unless it's blinking.  This is counter intuitive from the
> > > expectation that something will happen when left clicked.  Attached is
> > > a patch that will spawn the wizard when left clicked, or stop blinking
> > > if it was.
> > 
> > I'd rather it popped up the right-click menu instead of popping up the
> > wizard.
> 
> I added a simple menu to the left-click to allow starting the wizard.

Why a separate/different menu?

Re: [PATCH] Start wizard when left clicked

[Marcel Holtmann]

Hi Bastien,

> > > > Currently the applet doesn't seem to respond to any actions when left
> > > > clicked unless it's blinking.  This is counter intuitive from the
> > > > expectation that something will happen when left clicked.  Attached is
> > > > a patch that will spawn the wizard when left clicked, or stop blinking
> > > > if it was.
> > > 
> > > I'd rather it popped up the right-click menu instead of popping up the
> > > wizard.
> > 
> > I added a simple menu to the left-click to allow starting the wizard.
> 
> Why a separate/different menu?

because I wanna use the left-click menu for the known devices and an
easy access to connect them.

Regards

Marcel