public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Make bluetooth-properties fit on smaller displays
@ 2008-09-28 17:44 Mario_Limonciello
  2008-09-29  9:07 ` Marcel Holtmann
  0 siblings, 1 reply; 14+ messages in thread
From: Mario_Limonciello @ 2008-09-28 17:44 UTC (permalink / raw)
  To: linux-bluetooth

[-- Attachment #1: Type: text/plain, Size: 400 bytes --]

Hi:

Ubuntu was carrying a "hildon" patch to make the bluetooth-properties application fit on smaller form factors for lpia.  We've adapted the patch to be applicable to all platforms.  It changes the layout of the bluetooth-properties window to be better for small displays without a loss of functionality.

Regards

Mario Limonciello 
Dell | Linux Engineering 
Mario_Limonciello@Dell.com 

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 06_preferences-horizontal-layout.patch --]
[-- Type: text/x-patch; name="06_preferences-horizontal-layout.patch", Size: 1867 bytes --]

diff -Nur -x '*.orig' -x '*~' bluez-gnome-1.5/properties/adapter.c bluez-gnome-1.5.new/properties/adapter.c
--- bluez-gnome-1.5/properties/adapter.c	2008-09-28 11:47:41.000000000 -0500
+++ bluez-gnome-1.5.new/properties/adapter.c	2008-09-28 11:47:51.000000000 -0500
@@ -208,11 +208,7 @@
 	}
 
 	update_buttons(adapter, paired, trusted, connected);
-
-	if (selected == TRUE)
-		gtk_widget_show(adapter->button_trusted);
-	else
-		gtk_widget_hide(adapter->button_trusted);
+	gtk_widget_set_sensitive(adapter->button_trusted, selected);
 }
 
 static void row_callback(GtkTreeModel *model, GtkTreePath  *path,
@@ -379,7 +375,7 @@
 		timeout = 0;
 	}
 
-	mainbox = gtk_vbox_new(FALSE, 18);
+	mainbox = gtk_hbox_new(FALSE, 12);
 	gtk_container_set_border_width(GTK_CONTAINER(mainbox), 12);
 
 	gtk_notebook_prepend_page(GTK_NOTEBOOK(adapter->notebook),
@@ -389,6 +385,9 @@
 
 	adapter->child = mainbox;
 
+	mainbox = gtk_vbox_new (FALSE, 18);
+	gtk_container_add(GTK_CONTAINER (GTK_CONTAINER (adapter->child)), mainbox);
+
 	vbox = gtk_vbox_new(FALSE, 6);
 	gtk_box_pack_start(GTK_BOX(mainbox), vbox, FALSE, FALSE, 0);
 
@@ -489,7 +488,7 @@
 					G_CALLBACK(focus_callback), adapter);
 
 	vbox = gtk_vbox_new(FALSE, 6);
-	gtk_box_pack_start(GTK_BOX(mainbox), vbox, TRUE, TRUE, 0);
+	gtk_box_pack_start(GTK_BOX(adapter->child), vbox, TRUE, TRUE, 0);
 
 	label = create_label(_("Known devices"));
 	gtk_box_pack_start(GTK_BOX(vbox), label, FALSE, FALSE, 0);
@@ -535,9 +534,9 @@
 	adapter->button_delete = button;
 
 	button = gtk_button_new_with_mnemonic(NULL);
-	gtk_widget_set_no_show_all(button, TRUE);
 	gtk_container_add(GTK_CONTAINER(buttonbox), button);
-
+	gtk_button_set_label(GTK_BUTTON(button),_("Set _Trusted"));
+	gtk_widget_set_sensitive(GTK_WIDGET(button), FALSE);
 	g_signal_connect(G_OBJECT(button), "clicked",
 				G_CALLBACK(trusted_callback), adapter);
 

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] Make bluetooth-properties fit on smaller displays
  2008-09-28 17:44 [PATCH] Make bluetooth-properties fit on smaller displays Mario_Limonciello
@ 2008-09-29  9:07 ` Marcel Holtmann
  2008-09-29  9:15   ` Bastien Nocera
  0 siblings, 1 reply; 14+ messages in thread
From: Marcel Holtmann @ 2008-09-29  9:07 UTC (permalink / raw)
  To: Mario_Limonciello; +Cc: linux-bluetooth

Hi Mario,

> Ubuntu was carrying a "hildon" patch to make the bluetooth-properties application fit on smaller form factors for lpia.  We've adapted the patch to be applicable to all platforms.  It changes the layout of the bluetooth-properties window to be better for small displays without a loss of functionality.

I have no idea what this patch tries to achieve. How will this save
space on small displays?

Regards

Marcel



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] Make bluetooth-properties fit on smaller displays
  2008-09-29  9:07 ` Marcel Holtmann
@ 2008-09-29  9:15   ` Bastien Nocera
  2008-09-29 15:05     ` Mario_Limonciello
  0 siblings, 1 reply; 14+ messages in thread
From: Bastien Nocera @ 2008-09-29  9:15 UTC (permalink / raw)
  To: Marcel Holtmann; +Cc: Mario_Limonciello, linux-bluetooth

On Mon, 2008-09-29 at 11:07 +0200, Marcel Holtmann wrote:
> Hi Mario,
> 
> > Ubuntu was carrying a "hildon" patch to make the bluetooth-properties application fit on smaller form factors for lpia.  We've adapted the patch to be applicable to all platforms.  It changes the layout of the bluetooth-properties window to be better for small displays without a loss of functionality.
> 
> I have no idea what this patch tries to achieve. How will this save
> space on small displays?

A before/after screenshot would be useful indeed. If it's a good layout,
it should probably be used by default.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* RE: [PATCH] Make bluetooth-properties fit on smaller displays
  2008-09-29  9:15   ` Bastien Nocera
@ 2008-09-29 15:05     ` Mario_Limonciello
  2008-09-29 15:22       ` Bastien Nocera
  0 siblings, 1 reply; 14+ messages in thread
From: Mario_Limonciello @ 2008-09-29 15:05 UTC (permalink / raw)
  To: hadess, marcel; +Cc: linux-bluetooth

[-- Attachment #1: Type: text/plain, Size: 1594 bytes --]

Hi Bastien & Marcel:

Here's the screenshots as requested:

Old: http://imagebin.org/27644

New: http://imagebin.org/27643

A lot of these MID devices don't have screens bigger than 1024x600 (some 800x600 depending on their aspect ratio).  This change really just reorganizes the GUI so that both laptops and MID devices can use the same layout.  I'm attaching an updated patch relative to 1.6.

Regards

Mario Limonciello 
Dell | Linux Engineering 
Mario_Limonciello@Dell.com 



-----Original Message-----
From: linux-bluetooth-owner@vger.kernel.org on behalf of Bastien Nocera
Sent: Mon 9/29/2008 4:15 AM
To: Marcel Holtmann
Cc: Limonciello, Mario; linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Make bluetooth-properties fit on smaller displays
 
On Mon, 2008-09-29 at 11:07 +0200, Marcel Holtmann wrote:
> Hi Mario,
> 
> > Ubuntu was carrying a "hildon" patch to make the bluetooth-properties application fit on smaller form factors for lpia.  We've adapted the patch to be applicable to all platforms.  It changes the layout of the bluetooth-properties window to be better for small displays without a loss of functionality.
> 
> I have no idea what this patch tries to achieve. How will this save
> space on small displays?

A before/after screenshot would be useful indeed. If it's a good layout,
it should probably be used by default.

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 06_preferences-horizontal-layout.patch --]
[-- Type: text/x-patch; name="06_preferences-horizontal-layout.patch", Size: 3441 bytes --]

diff -Nur -x '*.orig' -x '*~' bluez-gnome-1.6/properties/adapter.c bluez-gnome-1.6.new/properties/adapter.c
--- bluez-gnome-1.6/properties/adapter.c	2008-09-29 07:08:50.000000000 -0500
+++ bluez-gnome-1.6.new/properties/adapter.c	2008-09-29 09:55:36.000000000 -0500
@@ -246,16 +246,10 @@
 	}
 
 	update_buttons(adapter, paired, trusted, connected);
-
-	if (selected == TRUE) {
-		gtk_widget_show(adapter->button_disconnect);
-		gtk_widget_show(adapter->button_trusted);
-		gtk_widget_show(adapter->button_delete);
-	} else {
-		gtk_widget_hide(adapter->button_disconnect);
-		gtk_widget_hide(adapter->button_trusted);
-		gtk_widget_hide(adapter->button_delete);
-	}
+	
+	gtk_widget_set_sensitive(adapter->button_disconnect,selected);
+	gtk_widget_set_sensitive(adapter->button_trusted,selected);
+	gtk_widget_set_sensitive(adapter->button_delete,selected);
 }
 
 static void row_callback(GtkTreeModel *model, GtkTreePath  *path,
@@ -461,7 +455,7 @@
 	adapter->discoverable = discoverable;
 	adapter->timeout_value = timeout;
 
-	mainbox = gtk_vbox_new(FALSE, 18);
+	mainbox = gtk_hbox_new(FALSE, 12);
 	gtk_container_set_border_width(GTK_CONTAINER(mainbox), 12);
 
 	gtk_notebook_prepend_page(GTK_NOTEBOOK(adapter->notebook),
@@ -471,6 +465,9 @@
 
 	adapter->child = mainbox;
 
+	mainbox = gtk_vbox_new (FALSE, 18);
+	gtk_container_add(GTK_CONTAINER (GTK_CONTAINER (adapter->child)), mainbox);
+
 	vbox = gtk_vbox_new(FALSE, 6);
 	gtk_box_pack_start(GTK_BOX(mainbox), vbox, FALSE, FALSE, 0);
 
@@ -569,7 +566,7 @@
 	entry = gtk_entry_new();
 	gtk_entry_set_max_length(GTK_ENTRY(entry), 248);
 	gtk_widget_set_size_request(entry, 240, -1);
-	gtk_box_pack_start(GTK_BOX(vbox), entry, TRUE, TRUE, 0);
+	gtk_box_pack_start(GTK_BOX(vbox), entry, FALSE, FALSE, 0);
 
 	if (name != NULL)
 		gtk_entry_set_text(GTK_ENTRY(entry), name);
@@ -582,7 +579,7 @@
 					G_CALLBACK(focus_callback), adapter);
 
 	vbox = gtk_vbox_new(FALSE, 6);
-	gtk_box_pack_start(GTK_BOX(mainbox), vbox, TRUE, TRUE, 0);
+	gtk_box_pack_start(GTK_BOX(adapter->child), vbox, TRUE, TRUE, 0);
 
 	label = create_label(_("Known devices"));
 	gtk_box_pack_start(GTK_BOX(vbox), label, FALSE, FALSE, 0);
@@ -634,8 +631,8 @@
 						GTK_ICON_SIZE_BUTTON);
 	gtk_container_add(GTK_CONTAINER(button), image);
 	gtk_container_set_border_width(GTK_CONTAINER(button), 0);
-	gtk_widget_set_no_show_all(button, TRUE);
 	gtk_widget_show(image);
+	gtk_widget_set_sensitive(button,FALSE);
 	gtk_box_pack_end(GTK_BOX(buttonbox), button, FALSE, FALSE, 0);
 	gtk_button_box_set_child_secondary(GTK_BUTTON_BOX(buttonbox),
 								button, TRUE);
@@ -651,8 +648,8 @@
 						GTK_ICON_SIZE_BUTTON);
 	gtk_container_add(GTK_CONTAINER(button), image);
 	gtk_container_set_border_width(GTK_CONTAINER(button), 0);
-	gtk_widget_set_no_show_all(button, TRUE);
 	gtk_widget_show(image);
+	gtk_widget_set_sensitive(button,FALSE);
 	gtk_box_pack_end(GTK_BOX(buttonbox), button, FALSE, FALSE, 0);
 	gtk_button_box_set_child_secondary(GTK_BUTTON_BOX(buttonbox),
 								button, TRUE);
@@ -668,8 +665,8 @@
 						GTK_ICON_SIZE_BUTTON);
 	gtk_container_add(GTK_CONTAINER(button), image);
 	gtk_container_set_border_width(GTK_CONTAINER(button), 0);
-	gtk_widget_set_no_show_all(button, TRUE);
 	gtk_widget_show(image);
+	gtk_widget_set_sensitive(button,FALSE);
 	gtk_box_pack_end(GTK_BOX(buttonbox), button, FALSE, FALSE, 0);
 	gtk_button_box_set_child_secondary(GTK_BUTTON_BOX(buttonbox),
 								button, TRUE);

^ permalink raw reply	[flat|nested] 14+ messages in thread

* RE: [PATCH] Make bluetooth-properties fit on smaller displays
  2008-09-29 15:05     ` Mario_Limonciello
@ 2008-09-29 15:22       ` Bastien Nocera
  2008-09-29 16:47         ` Emmet Hikory
                           ` (2 more replies)
  0 siblings, 3 replies; 14+ messages in thread
From: Bastien Nocera @ 2008-09-29 15:22 UTC (permalink / raw)
  To: Mario_Limonciello; +Cc: marcel, linux-bluetooth

On Mon, 2008-09-29 at 10:05 -0500, Mario_Limonciello@Dell.com wrote:
> Hi Bastien & Marcel:
> 
> Here's the screenshots as requested:
> 
> Old: http://imagebin.org/27644
> 
> New: http://imagebin.org/27643
> 
> A lot of these MID devices don't have screens bigger than 1024x600
> (some 800x600 depending on their aspect ratio).  This change really
> just reorganizes the GUI so that both laptops and MID devices can use
> the same layout.  I'm attaching an updated patch relative to 1.6.

Both versions would fit on both those screens. What's wrong with leaving
it as is? In the worst case, I'd move the contextual buttons to the side
of the treeview, instead of underneath, and add labels to those buttons.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] Make bluetooth-properties fit on smaller displays
  2008-09-29 15:22       ` Bastien Nocera
@ 2008-09-29 16:47         ` Emmet Hikory
  2008-09-29 23:41         ` Marcel Holtmann
  2008-09-30  8:00         ` David Sainty
  2 siblings, 0 replies; 14+ messages in thread
From: Emmet Hikory @ 2008-09-29 16:47 UTC (permalink / raw)
  To: Bastien Nocera; +Cc: Mario_Limonciello, marcel, linux-bluetooth

On Tue, Sep 30, 2008 at 12:22 AM, Bastien Nocera <hadess@hadess.net> wrote:
> On Mon, 2008-09-29 at 10:05 -0500, Mario_Limonciello@Dell.com wrote:
>> Hi Bastien & Marcel:
>>
>> Here's the screenshots as requested:
>>
>> Old: http://imagebin.org/27644
>>
>> New: http://imagebin.org/27643
>>
>> A lot of these MID devices don't have screens bigger than 1024x600
>> (some 800x600 depending on their aspect ratio).  This change really
>> just reorganizes the GUI so that both laptops and MID devices can use
>> the same layout.  I'm attaching an updated patch relative to 1.6.
>
> Both versions would fit on both those screens. What's wrong with leaving
> it as is? In the worst case, I'd move the contextual buttons to the side
> of the treeview, instead of underneath, and add labels to those buttons.

    Good day.  I adapted the suggested patch for this from one
previously shipped in Ubuntu by Michael Frey and Loic Minier.

    My actual test screens were 1024x600 (intel driver) and 800x600
(vesa driver), running under the hildon-desktop environment.  If I'm
running in clean GNOME@96DPI, the default looks OK, but there is only
space for two or three devices.  If I'm running under hildon-desktop,
there's only space for one device.  As one of these screens is
actually 247 DPI, running at 96 DPI tends to make everything nearly
unreadably small.  Note that I've also tested with GNOME+devilspie, to
force maximisation, which created a bit more space, but not hugely
more space.

    In practice, I use a keyboard, headset, communication to a yet
smaller portable device, and communication to my laptop.  I'd like to
add a mouse, GPS device, and printer.  I'm experimenting with a
"bluetooth handset" for making VoIP calls, which would be a separate
audio device for ekiga/empathy.  As a result, my device listing easily
exceeds the limits imposed by the vertical layout on a small screen.
Whlie this may be an exceptional case, I think "mouse, keyboard,
headset, phone, printer" isn't an unreasonable list of accessories,
even for a regular laptop user.

    One possible solution would be to write a separate hildon front
end, which is probably the best solution for 640x480 or 800x480, but
for 800x600 and 1024x600, the use case for using themed GNOME with
higher DPI hinting is strong enough that having a separate front-end
seems confusing.

    Mind you, I don't want to limit the experience on high-resolution
low-DPI screens, and will admit that I don't have the equipment to
properly test this use case.  If the consensus is that it the result
of moving the device listing to the right creates an unpleasant
experience for these users, then perhaps it is not a sensible default.

-- 
Emmet HIKORY

^ permalink raw reply	[flat|nested] 14+ messages in thread

* RE: [PATCH] Make bluetooth-properties fit on smaller displays
  2008-09-29 15:22       ` Bastien Nocera
  2008-09-29 16:47         ` Emmet Hikory
@ 2008-09-29 23:41         ` Marcel Holtmann
  2008-09-30  8:00         ` David Sainty
  2 siblings, 0 replies; 14+ messages in thread
From: Marcel Holtmann @ 2008-09-29 23:41 UTC (permalink / raw)
  To: Bastien Nocera; +Cc: Mario_Limonciello, linux-bluetooth

Hi Bastien,

> > Here's the screenshots as requested:
> > 
> > Old: http://imagebin.org/27644
> > 
> > New: http://imagebin.org/27643
> > 
> > A lot of these MID devices don't have screens bigger than 1024x600
> > (some 800x600 depending on their aspect ratio).  This change really
> > just reorganizes the GUI so that both laptops and MID devices can use
> > the same layout.  I'm attaching an updated patch relative to 1.6.
> 
> Both versions would fit on both those screens. What's wrong with leaving
> it as is? In the worst case, I'd move the contextual buttons to the side
> of the treeview, instead of underneath, and add labels to those buttons.

I really don't see the advantage of the vertical layout. For the buttons
I tried to use a ToolBar, but that looks ugly since I can get rid of the
top and bottom frame. Otherwise we could have put that to the right of
the TreeView and saved the extra space you guys need.

Regards

Marcel




^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] Make bluetooth-properties fit on smaller displays
  2008-09-29 15:22       ` Bastien Nocera
  2008-09-29 16:47         ` Emmet Hikory
  2008-09-29 23:41         ` Marcel Holtmann
@ 2008-09-30  8:00         ` David Sainty
  2008-09-30  8:17           ` Marcel Holtmann
  2 siblings, 1 reply; 14+ messages in thread
From: David Sainty @ 2008-09-30  8:00 UTC (permalink / raw)
  To: Bastien Nocera; +Cc: Mario_Limonciello, marcel, linux-bluetooth

Bastien Nocera wrote:
> On Mon, 2008-09-29 at 10:05 -0500, Mario_Limonciello@Dell.com wrote:
>   
>> Hi Bastien & Marcel:
>>
>> Here's the screenshots as requested:
>>
>> Old: http://imagebin.org/27644
>>
>> New: http://imagebin.org/27643
>>
>> A lot of these MID devices don't have screens bigger than 1024x600
>> (some 800x600 depending on their aspect ratio).  This change really
>> just reorganizes the GUI so that both laptops and MID devices can use
>> the same layout.  I'm attaching an updated patch relative to 1.6.
>>     
>
> Both versions would fit on both those screens. What's wrong with leaving
> it as is? In the worst case, I'd move the contextual buttons to the side
> of the treeview, instead of underneath, and add labels to those buttons.
>   
The preferences dialog on an Eee PC (701) screen is a real pain, it is 
too big vertically.  800x480 screen, plus a window manager bar at the 
bottom, plus some chunky window decorations up the top.  For a window to 
fit conveniently on a standard Eee PC screen it needs to be 422 pixels 
vertically it looks like (the standard decorations are VERY chunky :)

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] Make bluetooth-properties fit on smaller displays
  2008-09-30  8:00         ` David Sainty
@ 2008-09-30  8:17           ` Marcel Holtmann
  2008-09-30  8:56             ` David Sainty
  0 siblings, 1 reply; 14+ messages in thread
From: Marcel Holtmann @ 2008-09-30  8:17 UTC (permalink / raw)
  To: David Sainty; +Cc: Bastien Nocera, Mario_Limonciello, linux-bluetooth

Hi David,

> >> A lot of these MID devices don't have screens bigger than 1024x600
> >> (some 800x600 depending on their aspect ratio).  This change really
> >> just reorganizes the GUI so that both laptops and MID devices can use
> >> the same layout.  I'm attaching an updated patch relative to 1.6.
> >>     
> >
> > Both versions would fit on both those screens. What's wrong with leaving
> > it as is? In the worst case, I'd move the contextual buttons to the side
> > of the treeview, instead of underneath, and add labels to those buttons.
> >   
> The preferences dialog on an Eee PC (701) screen is a real pain, it is 
> too big vertically.  800x480 screen, plus a window manager bar at the 
> bottom, plus some chunky window decorations up the top.  For a window to 
> fit conveniently on a standard Eee PC screen it needs to be 422 pixels 
> vertically it looks like (the standard decorations are VERY chunky :)

the dialog ix 420x420 and thus it should fit.

Regards

Marcel



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] Make bluetooth-properties fit on smaller displays
  2008-09-30  8:17           ` Marcel Holtmann
@ 2008-09-30  8:56             ` David Sainty
  2008-09-30 13:38               ` Mario_Limonciello
  0 siblings, 1 reply; 14+ messages in thread
From: David Sainty @ 2008-09-30  8:56 UTC (permalink / raw)
  To: Marcel Holtmann; +Cc: Bastien Nocera, Mario_Limonciello, linux-bluetooth

Marcel Holtmann wrote:
> Hi David,
>
>   
>>>> A lot of these MID devices don't have screens bigger than 1024x600
>>>> (some 800x600 depending on their aspect ratio).  This change really
>>>> just reorganizes the GUI so that both laptops and MID devices can use
>>>> the same layout.  I'm attaching an updated patch relative to 1.6.
>>>>     
>>>>         
>>> Both versions would fit on both those screens. What's wrong with leaving
>>> it as is? In the worst case, I'd move the contextual buttons to the side
>>> of the treeview, instead of underneath, and add labels to those buttons.
>>>   
>>>       
>> The preferences dialog on an Eee PC (701) screen is a real pain, it is 
>> too big vertically.  800x480 screen, plus a window manager bar at the 
>> bottom, plus some chunky window decorations up the top.  For a window to 
>> fit conveniently on a standard Eee PC screen it needs to be 422 pixels 
>> vertically it looks like (the standard decorations are VERY chunky :)
>>     
>
> the dialog ix 420x420 and thus it should fit.
>   
Interesting - that's not what I'm seeing.  I've just tried xwininfo on 
bluez-gnome-1.7 on both an Eee PC and a full sized PC (possibly with 
slightly different support library versions).

Full sized PC geometry for the preferences window is 420x521.  EeePC 
geometry for the same is 420x523.
  I'm not sure where the 2 pixel difference comes from (I don't think 
the geometry here is including the window manager decorations).  But 
neither are close to 420x420.  You weren't thinking 420x520 perchance?

^ permalink raw reply	[flat|nested] 14+ messages in thread

* RE: [PATCH] Make bluetooth-properties fit on smaller displays
  2008-09-30  8:56             ` David Sainty
@ 2008-09-30 13:38               ` Mario_Limonciello
  2008-09-30 22:14                 ` David Sainty
  0 siblings, 1 reply; 14+ messages in thread
From: Mario_Limonciello @ 2008-09-30 13:38 UTC (permalink / raw)
  To: david.sainty, marcel; +Cc: hadess, linux-bluetooth

Hi Folks:

I would think the DPI of the environment is playing into this.  David, =
what DPI is on your EEE?

Regards

Mario Limonciello=20
Dell | Linux Engineering=20
Mario_Limonciello@Dell.com=20



-----Original Message-----
From: David Sainty [mailto:david.sainty@dtsp.co.nz]
Sent: Tue 9/30/2008 3:56 AM
To: Marcel Holtmann
Cc: Bastien Nocera; Limonciello, Mario; linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Make bluetooth-properties fit on smaller displays
=20
Marcel Holtmann wrote:
> Hi David,
>
>  =20
>>>> A lot of these MID devices don't have screens bigger than 1024x600
>>>> (some 800x600 depending on their aspect ratio).  This change really
>>>> just reorganizes the GUI so that both laptops and MID devices can =
use
>>>> the same layout.  I'm attaching an updated patch relative to 1.6.
>>>>    =20
>>>>        =20
>>> Both versions would fit on both those screens. What's wrong with =
leaving
>>> it as is? In the worst case, I'd move the contextual buttons to the =
side
>>> of the treeview, instead of underneath, and add labels to those =
buttons.
>>>  =20
>>>      =20
>> The preferences dialog on an Eee PC (701) screen is a real pain, it =
is=20
>> too big vertically.  800x480 screen, plus a window manager bar at the =

>> bottom, plus some chunky window decorations up the top.  For a window =
to=20
>> fit conveniently on a standard Eee PC screen it needs to be 422 =
pixels=20
>> vertically it looks like (the standard decorations are VERY chunky :)
>>    =20
>
> the dialog ix 420x420 and thus it should fit.
>  =20
Interesting - that's not what I'm seeing.  I've just tried xwininfo on=20
bluez-gnome-1.7 on both an Eee PC and a full sized PC (possibly with=20
slightly different support library versions).

Full sized PC geometry for the preferences window is 420x521.  EeePC=20
geometry for the same is 420x523.
  I'm not sure where the 2 pixel difference comes from (I don't think=20
the geometry here is including the window manager decorations).  But=20
neither are close to 420x420.  You weren't thinking 420x520 perchance?

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] Make bluetooth-properties fit on smaller displays
  2008-09-30 13:38               ` Mario_Limonciello
@ 2008-09-30 22:14                 ` David Sainty
  2008-10-01 16:26                   ` Jim Carter
  0 siblings, 1 reply; 14+ messages in thread
From: David Sainty @ 2008-09-30 22:14 UTC (permalink / raw)
  To: Mario_Limonciello; +Cc: marcel, hadess, linux-bluetooth

xdpyinfo says the DPI is 100x101... heh...

  dimensions:    800x480 pixels (203x121 millimeters)
  resolution:    100x101 dots per inch

In reality it's around 133dpi (153mm x 92mm).


Mario_Limonciello@Dell.com wrote:
> Hi Folks:
>
> I would think the DPI of the environment is playing into this.  David, what DPI is on your EEE?
>
> Regards
>
> Mario Limonciello 
> Dell | Linux Engineering 
> Mario_Limonciello@Dell.com 
>
>
>
> -----Original Message-----
> From: David Sainty [mailto:david.sainty@dtsp.co.nz]
> Sent: Tue 9/30/2008 3:56 AM
> To: Marcel Holtmann
> Cc: Bastien Nocera; Limonciello, Mario; linux-bluetooth@vger.kernel.org
> Subject: Re: [PATCH] Make bluetooth-properties fit on smaller displays
>  
> Marcel Holtmann wrote:
>   
>> Hi David,
>>
>>   
>>     
>>>>> A lot of these MID devices don't have screens bigger than 1024x600
>>>>> (some 800x600 depending on their aspect ratio).  This change really
>>>>> just reorganizes the GUI so that both laptops and MID devices can use
>>>>> the same layout.  I'm attaching an updated patch relative to 1.6.
>>>>>     
>>>>>         
>>>>>           
>>>> Both versions would fit on both those screens. What's wrong with leaving
>>>> it as is? In the worst case, I'd move the contextual buttons to the side
>>>> of the treeview, instead of underneath, and add labels to those buttons.
>>>>   
>>>>       
>>>>         
>>> The preferences dialog on an Eee PC (701) screen is a real pain, it is 
>>> too big vertically.  800x480 screen, plus a window manager bar at the 
>>> bottom, plus some chunky window decorations up the top.  For a window to 
>>> fit conveniently on a standard Eee PC screen it needs to be 422 pixels 
>>> vertically it looks like (the standard decorations are VERY chunky :)
>>>     
>>>       
>> the dialog ix 420x420 and thus it should fit.
>>   
>>     
> Interesting - that's not what I'm seeing.  I've just tried xwininfo on 
> bluez-gnome-1.7 on both an Eee PC and a full sized PC (possibly with 
> slightly different support library versions).
>
> Full sized PC geometry for the preferences window is 420x521.  EeePC 
> geometry for the same is 420x523.
>   I'm not sure where the 2 pixel difference comes from (I don't think 
> the geometry here is including the window manager decorations).  But 
> neither are close to 420x420.  You weren't thinking 420x520 perchance?
>
>   



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] Make bluetooth-properties fit on smaller displays
  2008-09-30 22:14                 ` David Sainty
@ 2008-10-01 16:26                   ` Jim Carter
  2008-10-01 16:33                     ` Bastien Nocera
  0 siblings, 1 reply; 14+ messages in thread
From: Jim Carter @ 2008-10-01 16:26 UTC (permalink / raw)
  To: David Sainty; +Cc: Mario_Limonciello, hadess, linux-bluetooth

On Wed, 1 Oct 2008, David Sainty wrote:

> xdpyinfo says the DPI is 100x101... heh...
> 
>  dimensions:    800x480 pixels (203x121 millimeters)
>  resolution:    100x101 dots per inch
> 
> In reality it's around 133dpi (153mm x 92mm).

I'm sure the erratic sizing comes from nonuniform font selection.

I had endless trouble printing web pages from a Dell Inspiron 6400 
(1680x1050px, 128dpi if I remember right, Opera browser) and a Nokia N810 
(800x480px, 226dpi, Mozilla clonoid for GTK) -- the text glyphs were way 
oversize, even overlapping.  To fix, I lied to my X-server claiming 96dpi. 
As I understand it, one of the libraries scales the PostScript font, but 
not the graphical content, so the glyphs are the same size as those on the 
physical screen, which of course is a crock on the N810, or on an Eee, and 
is also a poor strategy on the laptop.

My current opinion is that all the apps should specify a font of Serif or 
Sans-Serif (according to the theme), and the user (with the help of good 
defaults in the distro) should set the default font size so he can read 
them with his eyes (blurred with age) and physical screen, and the apps 
should never override that setting, at most making small relative changes 
for titles or fine print notes.  Erratic font sizes are one objection I 
have to Maemo on the N810, but Maemo is definitely not the only offender.

I wonder if the Bluetooth applet follows this rule?  Judging from the 
discussion, most likely it does, and it's then at the mercy of the distro's 
setup.

Judging the screenshots that were shown, I think the landscape layout (new) 
is more practical for the N810.  However, the smallest screen I have to 
deal with at work is the Palm Treo 650 at 320x320px.  It wouldn't be 
running Linux, but if it were, both orientations would be equally bad.  I 
suspect that handheld devices are the most likely to have Bluetooth 
accessories, since they have the most limitation in power and USB ports, so 
special effort should be put in to fit any dialog boxes reliably on the 
small screens, assuming the distro provides defaults that make this 
possible.

James F. Carter          Voice 310 825 2897    FAX 310 206 6673
UCLA-Mathnet;  6115 MSA; 520 Portola Plaza; Los Angeles, CA, USA  90095-1555
Email: jimc@math.ucla.edu    http://www.math.ucla.edu/~jimc (q.v. for PGP key)

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] Make bluetooth-properties fit on smaller displays
  2008-10-01 16:26                   ` Jim Carter
@ 2008-10-01 16:33                     ` Bastien Nocera
  0 siblings, 0 replies; 14+ messages in thread
From: Bastien Nocera @ 2008-10-01 16:33 UTC (permalink / raw)
  To: Jim Carter; +Cc: David Sainty, Mario_Limonciello, linux-bluetooth

On Wed, 2008-10-01 at 09:26 -0700, Jim Carter wrote:
> On Wed, 1 Oct 2008, David Sainty wrote:
> 
> > xdpyinfo says the DPI is 100x101... heh...
> > 
> >  dimensions:    800x480 pixels (203x121 millimeters)
> >  resolution:    100x101 dots per inch
> > 
> > In reality it's around 133dpi (153mm x 92mm).
> 
> I'm sure the erratic sizing comes from nonuniform font selection.
<snip>

What does all that have to do with the discussion at hand?

> I wonder if the Bluetooth applet follows this rule?  Judging from the 
> discussion, most likely it does, and it's then at the mercy of the distro's 
> setup.

There's resolution independence patches ready to be merged into GTK+.
See:
http://bugzilla.gnome.org/show_bug.cgi?id=546711

> Judging the screenshots that were shown, I think the landscape layout (new) 
> is more practical for the N810.

The N810 doesn't use bluez-gnome.

>   However, the smallest screen I have to 
> deal with at work is the Palm Treo 650 at 320x320px.

Which doesn't run Linux, or bluez-gnome, does it?

>   It wouldn't be 
> running Linux, but if it were, both orientations would be equally bad.  I 
> suspect that handheld devices are the most likely to have Bluetooth 
> accessories, since they have the most limitation in power and USB ports, so 
> special effort should be put in to fit any dialog boxes reliably on the 
> small screens, assuming the distro provides defaults that make this 
> possible.

Please don't go off on tangents. There's a pretty clear discussion
happening, I don't think we want to hear ramblings about other devices
that don't even use bluez-gnome.


^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2008-10-01 16:33 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-28 17:44 [PATCH] Make bluetooth-properties fit on smaller displays Mario_Limonciello
2008-09-29  9:07 ` Marcel Holtmann
2008-09-29  9:15   ` Bastien Nocera
2008-09-29 15:05     ` Mario_Limonciello
2008-09-29 15:22       ` Bastien Nocera
2008-09-29 16:47         ` Emmet Hikory
2008-09-29 23:41         ` Marcel Holtmann
2008-09-30  8:00         ` David Sainty
2008-09-30  8:17           ` Marcel Holtmann
2008-09-30  8:56             ` David Sainty
2008-09-30 13:38               ` Mario_Limonciello
2008-09-30 22:14                 ` David Sainty
2008-10-01 16:26                   ` Jim Carter
2008-10-01 16:33                     ` Bastien Nocera

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox