public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Bastien Nocera <hadess@hadess.net>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Mario_Limonciello@Dell.com, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Don't show (null) in wizard
Date: Mon, 06 Oct 2008 07:43:05 +0100	[thread overview]
Message-ID: <1223275385.3743.1.camel@cookie.hadess.net> (raw)
In-Reply-To: <1223274346.28401.54.camel@macbook.infradead.org>

On Mon, 2008-10-06 at 07:25 +0100, David Woodhouse wrote:
> On Mon, 2008-10-06 at 01:21 -0500, Mario_Limonciello@Dell.com wrote:
> > I've noticed that the wizard will show (null) if the device name is
> > not yet recognized when pairing.  This is a bit confusing to the user
> > experience.  The attached patch makes the behavior a little bit
> > better.
> 
> Thanks; I noticed that too a couple of days ago but hadn't got round to
> the patch yet.
> 
> Perhaps showing the bdaddr would be better, though?

That should fix both problems:

diff --git a/wizard/main.c b/wizard/main.c
index 3accd7f..3c9e017 100644
--- a/wizard/main.c
+++ b/wizard/main.c
@@ -351,7 +351,7 @@ static void select_callback(GtkTreeSelection *selection, gpointer user_data)
                gtk_tree_model_get(model, &iter,
                                BLUETOOTH_COLUMN_PAIRED, &paired,
                                BLUETOOTH_COLUMN_ADDRESS, &address,
-                               BLUETOOTH_COLUMN_NAME, &name,
+                               BLUETOOTH_COLUMN_ALIAS, &name,
                                BLUETOOTH_COLUMN_TYPE, &type, -1);
 
                if (paired == TRUE)



  reply	other threads:[~2008-10-06  6:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-06  6:21 [PATCH] Don't show (null) in wizard Mario_Limonciello
2008-10-06  6:25 ` David Woodhouse
2008-10-06  6:43   ` Bastien Nocera [this message]
2008-10-06  8:02     ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1223275385.3743.1.camel@cookie.hadess.net \
    --to=hadess@hadess.net \
    --cc=Mario_Limonciello@Dell.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox