Re: [PATCH] Don't show (null) in wizard

[Marcel Holtmann <marcel@holtmann.org>]

Hi Bastien,

> > > I've noticed that the wizard will show (null) if the device name is
> > > not yet recognized when pairing.  This is a bit confusing to the user
> > > experience.  The attached patch makes the behavior a little bit
> > > better.
> > 
> > Thanks; I noticed that too a couple of days ago but hadn't got round to
> > the patch yet.
> > 
> > Perhaps showing the bdaddr would be better, though?
> 
> That should fix both problems:
> 
> diff --git a/wizard/main.c b/wizard/main.c
> index 3accd7f..3c9e017 100644
> --- a/wizard/main.c
> +++ b/wizard/main.c
> @@ -351,7 +351,7 @@ static void select_callback(GtkTreeSelection *selection, gpointer user_data)
>                 gtk_tree_model_get(model, &iter,
>                                 BLUETOOTH_COLUMN_PAIRED, &paired,
>                                 BLUETOOTH_COLUMN_ADDRESS, &address,
> -                               BLUETOOTH_COLUMN_NAME, &name,
> +                               BLUETOOTH_COLUMN_ALIAS, &name,
>                                 BLUETOOTH_COLUMN_TYPE, &type, -1);
>  

this is the right fix. Let bluetoothd do the hard work for you :)

Regards

Marcel