* [PATCH] Add OUI check for the PS3 BD remote
@ 2008-10-10 15:32 Bastien Nocera
2008-10-10 22:58 ` Marcel Holtmann
0 siblings, 1 reply; 3+ messages in thread
From: Bastien Nocera @ 2008-10-10 15:32 UTC (permalink / raw)
To: linux-bluetooth
[-- Attachment #1: Type: text/plain, Size: 1 bytes --]
[-- Attachment #2: 0001-Add-OUI-check-for-the-PS3-BD-remote.patch --]
[-- Type: text/x-patch, Size: 833 bytes --]
>From 0318981c54a3396a0672b8fd2a48d4014d9aa59e Mon Sep 17 00:00:00 2001
From: Bastien Nocera <hadess@hadess.net>
Date: Fri, 10 Oct 2008 16:31:03 +0100
Subject: [PATCH] Add OUI check for the PS3 BD remote
As per Marcel's request
---
wizard/main.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/wizard/main.c b/wizard/main.c
index 860c3b1..83f2491 100644
--- a/wizard/main.c
+++ b/wizard/main.c
@@ -209,7 +209,8 @@ static void prepare_callback(GtkWidget *assistant,
path = NULL;
/* Sony PlayStation 3 Remote Control */
- if (g_str_equal(target_name, "BD Remote Control") == TRUE)
+ if (g_str_has_prefix(target_address, "00:19:C1:") != FALSE &&
+ g_str_equal(target_name, "BD Remote Control") == TRUE)
path = NULL;
bluetooth_client_create_device(client, target_address,
--
1.6.0.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Add OUI check for the PS3 BD remote
2008-10-10 15:32 [PATCH] Add OUI check for the PS3 BD remote Bastien Nocera
@ 2008-10-10 22:58 ` Marcel Holtmann
2008-10-11 0:16 ` Bastien Nocera
0 siblings, 1 reply; 3+ messages in thread
From: Marcel Holtmann @ 2008-10-10 22:58 UTC (permalink / raw)
To: Bastien Nocera; +Cc: linux-bluetooth
Hi Bastien,
the patch has been applied, but != FALSE is also == TRUE. We don't need
double negation ;)
regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Add OUI check for the PS3 BD remote
2008-10-10 22:58 ` Marcel Holtmann
@ 2008-10-11 0:16 ` Bastien Nocera
0 siblings, 0 replies; 3+ messages in thread
From: Bastien Nocera @ 2008-10-11 0:16 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: linux-bluetooth
On Sat, 2008-10-11 at 00:58 +0200, Marcel Holtmann wrote:
> Hi Bastien,
>
> the patch has been applied, but != FALSE is also == TRUE. We don't need
> double negation ;)
Actually. FALSE is defined as "0", and TRUE as "!FALSE". So depending on
the system and the compiler, TRUE could be anything, including 1, just
not 0.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-10-11 0:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-10 15:32 [PATCH] Add OUI check for the PS3 BD remote Bastien Nocera
2008-10-10 22:58 ` Marcel Holtmann
2008-10-11 0:16 ` Bastien Nocera
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox