public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Better debug when failing to probe a device
@ 2008-10-14 21:01 Bastien Nocera
  2008-10-14 21:23 ` Johan Hedberg
  0 siblings, 1 reply; 2+ messages in thread
From: Bastien Nocera @ 2008-10-14 21:01 UTC (permalink / raw)
  To: BlueZ development

[-- Attachment #1: Type: text/plain, Size: 44 bytes --]

The previous error message was a bit terse.

[-- Attachment #2: 0002-Better-debug-when-failing-to-probe-a-device.patch --]
[-- Type: text/x-patch, Size: 832 bytes --]

>From 5c71324238e5380530a298bb63ec9d79b7a1f219 Mon Sep 17 00:00:00 2001
From: Bastien Nocera <hadess@hadess.net>
Date: Tue, 14 Oct 2008 21:58:51 +0100
Subject: [PATCH] Better debug when failing to probe a device

The previous error message was a bit terse.
---
 src/device.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/device.c b/src/device.c
index 7294d3c..2a48406 100644
--- a/src/device.c
+++ b/src/device.c
@@ -646,8 +646,8 @@ void device_probe_drivers(struct btd_device *device, GSList *uuids)
 
 			err = driver->probe(device, probe_uuids);
 			if (err < 0) {
-				error("probe failed for driver %s",
-							driver->name);
+				error("probe failed with driver %s for device %s",
+							driver->name, device->path);
 
 				g_free(driver_data);
 				g_slist_free(probe_uuids);
-- 
1.5.5.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Better debug when failing to probe a device
  2008-10-14 21:01 [PATCH] Better debug when failing to probe a device Bastien Nocera
@ 2008-10-14 21:23 ` Johan Hedberg
  0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2008-10-14 21:23 UTC (permalink / raw)
  To: BlueZ development

Hi Bastien,

On Oct 15, 2008, at 0:01, Bastien Nocera wrote:
> The previous error message was a bit terse.
> <0002-Better-debug-when-failing-to-probe-a-device.patch>

This one is now pushed. I'll leave the other one for Marcel since I'm  
not so familiar with udev stuff.

Johan


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-10-14 21:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-14 21:01 [PATCH] Better debug when failing to probe a device Bastien Nocera
2008-10-14 21:23 ` Johan Hedberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox