public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Add missing IDs for Logitech MX5500
@ 2008-10-22 20:55 Mario Limonciello
  2008-10-23  4:42 ` Marcel Holtmann
  0 siblings, 1 reply; 2+ messages in thread
From: Mario Limonciello @ 2008-10-22 20:55 UTC (permalink / raw)
  To: linux-bluetooth@vger.kernel.org


[-- Attachment #1.1: Type: text/plain, Size: 242 bytes --]

Hello,

It was reported that the Logitech MX5500 has more IDs than were
previously listed in hid2hci's source.  This patch adds more of those IDs.

Thanks,
-- 
Mario Limonciello
*Dell | Linux Engineering*
mario_limonciello@dell.com

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: logitech_5500_ids.patch --]
[-- Type: text/x-patch; name="logitech_5500_ids.patch", Size: 821 bytes --]

diff -Nur -x '*.orig' -x '*~' bluez-4.12/tools/hid2hci.c bluez-4.12.new/tools/hid2hci.c
--- bluez-4.12/tools/hid2hci.c	2008-10-22 15:54:19.000000000 -0500
+++ bluez-4.12.new/tools/hid2hci.c	2008-10-22 15:55:05.000000000 -0500
@@ -260,6 +260,8 @@
 	{ HCI, 0x046d, 0xc70e, switch_logitech },	/* Logitech diNovo keyboard */
 	{ HCI, 0x046d, 0xc713, switch_logitech },	/* Logitech diNovo Edge */
 	{ HCI, 0x046d, 0xc714, switch_logitech },	/* Logitech diNovo Edge */
+	{ HCI, 0x046d, 0xc71c, switch_logitech },	/* Logitech diNovo Edge */
+	{ HCI, 0x046d, 0xc71b, switch_logitech },	/* Logitech diNovo Edge */
 	{ HCI, 0x413c, 0x8162, switch_dell     },	/* Dell Wireless 365 */
 	{ HCI, 0x413c, 0x8158, switch_dell     },	/* Dell Wireless 370 */
 	{ HCI, 0x413c, 0x8154, switch_dell     },	/* Dell Wireless 410 */

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Add missing IDs for Logitech MX5500
  2008-10-22 20:55 [PATCH] Add missing IDs for Logitech MX5500 Mario Limonciello
@ 2008-10-23  4:42 ` Marcel Holtmann
  0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2008-10-23  4:42 UTC (permalink / raw)
  To: Mario Limonciello; +Cc: linux-bluetooth@vger.kernel.org

Hi Mario,

> It was reported that the Logitech MX5500 has more IDs than were
> previously listed in hid2hci's source.  This patch adds more of those IDs.

please always make patches against the latest bluez.git tree. Yours was
against something that is not upstream. Also the IDs should go in order.

I fixed it for you this time, but next time, I make you re-submit it :)

Regards

Marcel



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-10-23  4:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-22 20:55 [PATCH] Add missing IDs for Logitech MX5500 Mario Limonciello
2008-10-23  4:42 ` Marcel Holtmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox